Re: [Linuxptp-devel] [PATCH v3 07/11] synce4l: add synce_port interface

2022-06-01 Thread Miroslav Lichvar
On Wed, Jun 01, 2022 at 02:44:14PM +, Kubalewski, Arkadiusz wrote: > > Maybe the create and init function could be merged to make the > > error handling easier? > > Well, init is already long function, I would rather leave it separated, > Isn't it enough to zero-memory here? Maybe. I didn't t

Re: [Linuxptp-devel] [PATCH v3 07/11] synce4l: add synce_port interface

2022-06-01 Thread Kubalewski, Arkadiusz
-Original Message- From: Miroslav Lichvar Sent: Wednesday, June 1, 2022 11:39 AM > On Mon, May 30, 2022 at 09:34:15PM +0200, Arkadiusz Kubalewski wrote: > > Used by synce_dev to interact with its ports. > > > +struct synce_port *synce_port_create(const char *port_name) > > +{ > > + s

Re: [Linuxptp-devel] [PATCH v3 07/11] synce4l: add synce_port interface

2022-06-01 Thread Miroslav Lichvar
On Mon, May 30, 2022 at 09:34:15PM +0200, Arkadiusz Kubalewski wrote: > Used by synce_dev to interact with its ports. > +struct synce_port *synce_port_create(const char *port_name) > +{ > + struct synce_port *p = NULL; > + > + if (!port_name) { > + pr_err("%s failed - port_name

[Linuxptp-devel] [PATCH v3 07/11] synce4l: add synce_port interface

2022-05-30 Thread Arkadiusz Kubalewski
Used by synce_dev to interact with its ports. Co-developed-by: Anatolii Gerasymenko Signed-off-by: Anatolii Gerasymenko Co-developed-by: Michal Michalik Signed-off-by: Michal Michalik Signed-off-by: Arkadiusz Kubalewski --- v2: updated license headers v3: rebase patch series synce_port.c |