Re: [Linuxptp-devel] [PATCH v5 07/13] ts2phc: instantiate a full clock structure for every PPS source of the PHC kind

2022-08-08 Thread Richard Cochran
On Fri, Aug 05, 2022 at 07:56:38PM +0300, Vladimir Oltean wrote: > > Need to keep this include in order to make sure declaration and > > definition of ts2phc_phc_pps_source_create() are consistent. > > ts2phc.h includes ts2phc_phc_pps_source.h. Still it is best practice NOT to rely on transitive

Re: [Linuxptp-devel] [PATCH v5 07/13] ts2phc: instantiate a full clock structure for every PPS source of the PHC kind

2022-08-05 Thread Vladimir Oltean
On Mon, Jun 13, 2022 at 03:27:13PM -0700, Richard Cochran wrote: > On Tue, Nov 23, 2021 at 02:14:15AM +0200, Vladimir Oltean wrote: > > > diff --git a/ts2phc_phc_pps_source.c b/ts2phc_phc_pps_source.c > > index ffb96ef7299a..fca653f99499 100644 > > --- a/ts2phc_phc_pps_source.c > > +++

Re: [Linuxptp-devel] [PATCH v5 07/13] ts2phc: instantiate a full clock structure for every PPS source of the PHC kind

2022-06-13 Thread Richard Cochran
On Tue, Nov 23, 2021 at 02:14:15AM +0200, Vladimir Oltean wrote: > diff --git a/ts2phc_phc_pps_source.c b/ts2phc_phc_pps_source.c > index ffb96ef7299a..fca653f99499 100644 > --- a/ts2phc_phc_pps_source.c > +++ b/ts2phc_phc_pps_source.c > @@ -12,15 +12,14 @@ > #include "phc.h" > #include

[Linuxptp-devel] [PATCH v5 07/13] ts2phc: instantiate a full clock structure for every PPS source of the PHC kind

2021-11-22 Thread Vladimir Oltean
This propagates the use of "struct ts2phc_private" all the way into the PPS source API, in preparation of a new use case that will be supported soon: some PPS sources (to be precise, the "PHC" kind) instantiate a struct clock which could be disciplined by ts2phc. When a PHC A emits a pulse and