Re: [Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for monitoring.

2021-01-26 Thread Miroslav Lichvar
On Sat, Jan 23, 2021 at 05:41:12AM -0800, Richard Cochran wrote: > We'll have to do something about the port numbering. The "real" ports > must start with 1, 2, 3, ... as this is part of the standard. > > Also, there is some code in port_open() and maybe elsewhere that > treats zero as a special

Re: [Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for monitoring.

2021-01-23 Thread Richard Cochran
On Wed, Jan 20, 2021 at 04:15:21PM +0100, Miroslav Lichvar wrote: > Add a second UDS port to allow unprivileged applications to monitor > ptp4l. On this "read-only" port, disable non-GET actions, forwarding, > and access to subscriptions. > > Ignore non-management messages on both UDS ports to pre

Re: [Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for monitoring.

2021-01-21 Thread Jacob Keller
On 1/21/2021 12:31 AM, Miroslav Lichvar wrote: > On Wed, Jan 20, 2021 at 10:13:25PM +, Keller, Jacob E wrote: >> It makes sense to remove forwarding, but I am not sure I understand the >> justification for removing access to subscriptions.. if the subscription is >> for read only data, why

Re: [Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for monitoring.

2021-01-21 Thread Miroslav Lichvar
On Wed, Jan 20, 2021 at 10:13:25PM +, Keller, Jacob E wrote: > It makes sense to remove forwarding, but I am not sure I understand the > justification for removing access to subscriptions.. if the subscription is > for read only data, why doesn't it make sense to allow that over the read > o

Re: [Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for monitoring.

2021-01-20 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar > Sent: Wednesday, January 20, 2021 7:15 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for > monitoring. > > Add a second UDS port to allow unpr

[Linuxptp-devel] [RFC PATCH] clock: Add read-only UDS port for monitoring.

2021-01-20 Thread Miroslav Lichvar
Add a second UDS port to allow unprivileged applications to monitor ptp4l. On this "read-only" port, disable non-GET actions, forwarding, and access to subscriptions. Ignore non-management messages on both UDS ports to prevent them from changing the clock or port state. (This should be a separate