Re: [Linuxptp-devel] [PATCH RFC v2 00/16] New configuration implementation

2015-08-13 Thread Richard Cochran
On Thu, Aug 13, 2015 at 11:13:17PM +, Keller, Jacob E wrote: > Ok. What I meant was that we today have per-port via: > > [enp2s0f0] > > > which indicates a port, and not a section. Maybe we should change this > to be: > > [port:enp2s0f0] or something in the oddball case where someone uses >

Re: [Linuxptp-devel] [PATCH RFC v2 00/16] New configuration implementation

2015-08-13 Thread Keller, Jacob E
On Thu, 2015-08-13 at 08:48 +0200, Richard Cochran wrote: > On Thu, Aug 13, 2015 at 08:20:51AM +0200, Richard Cochran wrote: > > The only built in assumption is that every option can appear under > > [global] as a default. It does *not* support options that can only > > appear in a non-global sect

Re: [Linuxptp-devel] [PATCH RFC v2 00/16] New configuration implementation

2015-08-13 Thread Keller, Jacob E
On Thu, 2015-08-13 at 08:20 +0200, Richard Cochran wrote: > On Wed, Aug 12, 2015 at 09:12:57PM +, Keller, Jacob E wrote: > > General comments: > > > > it doesn't appear to enforce any specific change on configuration > > file > > format. I know my earlier proposal was maybe to at some point >

Re: [Linuxptp-devel] [PATCH RFC v2 00/16] New configuration implementation

2015-08-12 Thread Richard Cochran
On Thu, Aug 13, 2015 at 08:20:51AM +0200, Richard Cochran wrote: > The only built in assumption is that every option can appear under > [global] as a default. It does *not* support options that can only > appear in a non-global section. No, I am mistaken. The new code doesn't support overriding

Re: [Linuxptp-devel] [PATCH RFC v2 00/16] New configuration implementation

2015-08-12 Thread Richard Cochran
On Wed, Aug 12, 2015 at 09:12:57PM +, Keller, Jacob E wrote: > General comments: > > it doesn't appear to enforce any specific change on configuration file > format. I know my earlier proposal was maybe to at some point update > the format. Specifically, change the per-port configurations to u

Re: [Linuxptp-devel] [PATCH RFC v2 00/16] New configuration implementation

2015-08-12 Thread Keller, Jacob E
Hi Richard, On Wed, 2015-08-12 at 21:45 +0200, Richard Cochran wrote: > Changes in V2: > - API is much simpler to use > - numerous details in the implementation have been improved > - half dozen legacy options converted > Nice changes. Looks very straight forward to use. > The config code was s