Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-12-03 Thread Richard Cochran
On Sun, Dec 03, 2023 at 06:15:52PM -0800, Kishen Maloor wrote: > On 12/1/23 10:07 PM, Richard Cochran wrote: > > Does the standard require that either ALL the nodes in a network use > > CMLDS, or none do at all? > > > > When the time-aware system supports multiple domains, IEEE >

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-12-03 Thread Kishen Maloor
On 12/1/23 10:07 PM, Richard Cochran wrote: On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote: CMLDS ptp4l process would be configured with transportSpecific/domain=0x2/0. Question about the spec: How on earth is this going to work? I mean, if the link partner is not also using

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-12-01 Thread Richard Cochran
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote: > CMLDS ptp4l process would be configured with > transportSpecific/domain=0x2/0. Question about the spec: How on earth is this going to work? I mean, if the link partner is not also using CMLDS, then it won't reply because of the

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-12-01 Thread Richard Cochran
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote: > If serviceMeasurementValid=true, then we set both peer_portid_valid and > p->nrate.ratio_valid to true so that port_capable() could evaluate to true. Even simpler: include asCapable from the CMLDS Link Port in the TLV, and just

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-11-30 Thread Richard Cochran
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote: > > + p->cmlds_pmc = pmc_create(cfg, TRANS_UDS, > > + config_get_string(cfg, p->name, > > "cmlds_client_address"), > > + config_get_string(cfg, p->name, > >

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-11-30 Thread Kishen Maloor
Hi Richard, Firstly, thanks so much for your reviews and efforts to get this done. I'll just rehash a couple of points also raised by Andrew. On this change below: > +static int port_cmlds_initialize(struct port *p) > +{ > + struct config *cfg = clock_config(p->clock); > + struct

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-11-30 Thread Richard Cochran
On Thu, Nov 30, 2023 at 07:12:54PM +0100, Andrew Zaborowski wrote: > On Thu, 30 Nov 2023 at 17:44, Richard Cochran > wrote: > > On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote: > > > > + PORT_ITEM_STR("cmlds_client_address", "/var/run/cmlds_cleint"), > > > > > > I assume

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-11-30 Thread Andrew Zaborowski
On Thu, 30 Nov 2023 at 17:44, Richard Cochran wrote: > On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote: > > > + PORT_ITEM_STR("cmlds_client_address", "/var/run/cmlds_cleint"), > > > > I assume the use of this is simply to set unique names for per-port > > sockets. Maybe

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-11-30 Thread Richard Cochran
On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote: > > @@ -249,6 +250,9 @@ struct config_item config_tab[] = { > > GLOB_ITEM_INT("clock_class_threshold", > > CLOCK_CLASS_THRESHOLD_DEFAULT, 6, CLOCK_CLASS_THRESHOLD_DEFAULT), > > GLOB_ITEM_ENU("clock_servo",

Re: [Linuxptp-devel] [PATCH v1 5/5] Implement the COMMON_P2P delay mechanism.

2023-11-30 Thread Andrew Zaborowski
Hi Richard, I haven't tested this but here are some comments. On Thu, 30 Nov 2023 at 08:58, Richard Cochran wrote: > From: Kishen Maloor > > Signed-off-by: Richard Cochran > --- > config.c | 4 ++ > dm.h | 3 + > fd.h | 1 + > makefile | 4 +- > port.c