Re: [Linuxptp-devel] [PATCH v3 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-12-13 Thread Geva, Erez
On Tue, 2022-12-13 at 10:56 +0530, Devasish Dey wrote: > + /* Megabits per secon converted to attoseconds per bit. */ > + return 1ULL/ iface->if_info.speed; Performing division in running is not a very good idea. It is better to perform the division when updating the speed

Re: [Linuxptp-devel] [PATCH v3 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-12-13 Thread Geva, Erez
On Tue, 2022-12-13 at 17:27 +0100, Erez Geva wrote: On Tue, 2022-12-13 at 10:56 +0530, Devasish Dey wrote: > + /* Megabits per secon converted to attoseconds per bit. */ > + return 1ULL/ iface->if_info.speed; Performing division in running is not a very good idea. It is

Re: [Linuxptp-devel] [PATCH v3 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-12-12 Thread Devasish Dey
> > > + /* Megabits per secon converted to attoseconds per bit. */ > > + return 1ULL/ iface->if_info.speed; > Performing division in running is not a very good idea. > It is better to perform the division when updating the speed and store > it in if_info. > > Are you sure

Re: [Linuxptp-devel] [PATCH v3 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-12-09 Thread Geva, Erez
On Wed, 2022-12-07 at 17:34 +0530, SyncMonk Technologies wrote: > Delay asymmetry calculation based on the PTP port interface speed of > master obtained from TLV and the slave interface rate obtained by > ethtool. > > v3: updating network/host byte order handling. > v1: initial commit > >