Re: [Linuxptp-devel] [PATCH v3 02/11] Respond with an error to management messages to non-existing ports

On Fri, May 02, 2014 at 12:37:45PM +0200, Jiri Benc wrote: > Signed-off-by: Jiri Benc > --- Applied. Thanks, Richard -- "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium

Re: [Linuxptp-devel] [PATCH v3 01/11] uds: don't output "Connection refused"

On Fri, May 02, 2014 at 12:37:44PM +0200, Jiri Benc wrote: > When phc2sys is started before ptp4l or it is interrupted before ptp4l has > a chance to reply to its query, the "uds: sendto failed: Connection refused" > message is output. This is not an interesting message. > > Also, don't output the

Re: [Linuxptp-devel] [PATCH v3 03/11] Remove unneeded parameter in port_forward

On Fri, May 02, 2014 at 12:37:46PM +0200, Jiri Benc wrote: > This parameter was made obsolete by the common address refactoring. > > Signed-off-by: Jiri Benc > --- Applied. Thanks, Richard -- "Accelerate Dev Cycles wit

Re: [Linuxptp-devel] [PATCH v3 04/11] Implement port_forward_to

On Fri, May 02, 2014 at 12:37:47PM +0200, Jiri Benc wrote: > Signed-off-by: Jiri Benc > --- Applied. Thanks, Richard -- "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium

Re: [Linuxptp-devel] [PATCH v3 05/11] Event subscribing

On Fri, May 02, 2014 at 12:37:48PM +0200, Jiri Benc wrote: > This puts groundwork for event subscription and notification. The individual > events are added by subsequent patches. I like this patch, but I still would want a few changes, mostly minor ones. > Signed-off-by: Jiri Benc > --- > clo

Re: [Linuxptp-devel] [PATCH v3 06/11] Include TLV in replies to management commands

On Fri, May 02, 2014 at 12:37:49PM +0200, Jiri Benc wrote: > The standard requires management TLV in replies to commands: > > An acknowledge management message is a response to a command > management message. The value of the managementId shall be identical > to that in the comma

Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

On Fri, May 02, 2014 at 12:37:50PM +0200, Jiri Benc wrote: > Add expiration time to subscriptions; they need to be renewed before they > expiry. This way, the subscription automatically times out when phc2sys is > killed. > > Signed-off-by: Jiri Benc > --- > clock.c | 27 ++

Re: [Linuxptp-devel] [PATCH v3 08/11] port: event notification

On Fri, May 02, 2014 at 12:37:51PM +0200, Jiri Benc wrote: > Split management message creation to more fine-grained functions to allow > notification messages to be created. I must admit I didn't understand what you did, at first reading. Can you lose a few words about how you split the code and w