Re: [Linuxptp-devel] [PATCH] ptp4l: Add IPoIB interface support for ptp4l

2017-08-09 Thread Richard Cochran
Looks good now, except for a couple of nits... On Tue, Aug 08, 2017 at 10:50:35AM +0300, Feras Daoud wrote: > +static int sk_interface_guidaddr(const char *name, unsigned char *guid) > +{ > + char file_name[64], buf[64], addr[8]; > + FILE *f; > + int rc; > + > + snprintf(file_name,

Re: [Linuxptp-devel] [PATCHv2 7/9] port.c: fix port_dispatch event flood when change ts_iface info

2017-08-09 Thread Hangbin Liu
On Sat, Aug 05, 2017 at 10:13:07AM +0200, Richard Cochran wrote: > On Sat, Jul 15, 2017 at 09:33:09PM +0800, Hangbin Liu wrote: > > When bond active slave interface changed. We will receive multi rtnl > > messages, i.e. bond and slave interfaces status changing information. > > > > No matter what'

Re: [Linuxptp-devel] [PATCHv2 7/9] port.c: fix port_dispatch event flood when change ts_iface info

2017-08-09 Thread Hangbin Liu
On Sat, Aug 05, 2017 at 10:13:07AM +0200, Richard Cochran wrote: > > enum fsm_event port_event(struct port *p, int fd_index) > > @@ -2301,7 +2313,7 @@ enum fsm_event port_event(struct port *p, int > > fd_index) > > case FD_RTNL: > > pr_debug("port %hu: received link status notific

[Linuxptp-devel] [PATCH] ptp4l: Add IPoIB interface support for ptp4l

2017-08-09 Thread Feras Daoud
The current implementation of ptp4l always assumes 6 octets MAC address, which is correct for Ethernet interfaces but not for IPoIB interfaces (that have 20 octets MAC), therefore running ptp4l over IPoIB interface does not function correctly. In Infiniband, every interface has three identifiers: