>I appreciate your taking the effort to review the series. However, in the
>future, please do not top-post!
>Instead, comment directly in-line, and trim the reply to remove any patch
>hunks that are not being commented upon.
Ok, I will comment inline in the future, sorry about that.
>> +static
On Tue, Mar 06, 2018 at 08:04:45AM +, Anders Selhammer wrote:
> I got them all from PATCH RFC V2 08/11 sent to me by mail, just did
> copy and pasted on the top. If there is something that is mismatched
> with your implementation I cannot say.
It appears that like your mail client is mangling
On Mon, Mar 05, 2018 at 08:36:58AM +, Anders Selhammer wrote:
> Why initialize the local variable datalen to zero at start? Start value is
> not used.
The initialization was from before. This patch did not change that.
It only moved the line down.
But you are right. The new code adds a "de
On Mon, Mar 05, 2018 at 12:53:22PM +, Anders Selhammer wrote:
> We always put braces around 'if' blocks. 😉
Almost always. :P
Thanks,
Richard
--
Check out the vibrant tech community on one of the world's most
engagin
On Mon, Mar 05, 2018 at 01:00:03PM +, Anders Selhammer wrote:
> Shouldn't this be moved also from pmc.c to util:
No, we only move code when we have to. That function is not (yet)
needed outside of pmc.c.
Thanks,
Richard
---