Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

2018-03-06 Thread Anders Selhammer
>I appreciate your taking the effort to review the series. However, in the >future, please do not top-post! >Instead, comment directly in-line, and trim the reply to remove any patch >hunks that are not being commented upon. Ok, I will comment inline in the future, sorry about that. >> +static

Re: [Linuxptp-devel] [PATCH RFC V2 08/11] port: Implement the NetSync Monitor protocol.

2018-03-06 Thread Richard Cochran
On Tue, Mar 06, 2018 at 08:04:45AM +, Anders Selhammer wrote: > I got them all from PATCH RFC V2 08/11 sent to me by mail, just did > copy and pasted on the top. If there is something that is mismatched > with your implementation I cannot say. It appears that like your mail client is mangling

Re: [Linuxptp-devel] [PATCH RFC 04/10] port: Simplify management response logic.

2018-03-06 Thread Richard Cochran
On Mon, Mar 05, 2018 at 08:36:58AM +, Anders Selhammer wrote: > Why initialize the local variable datalen to zero at start? Start value is > not used. The initialization was from before. This patch did not change that. It only moved the line down. But you are right. The new code adds a "de

Re: [Linuxptp-devel] [PATCH RFC V2 10/10] port: Accept multiple TLVs on receive.

2018-03-06 Thread Richard Cochran
On Mon, Mar 05, 2018 at 12:53:22PM +, Anders Selhammer wrote: > We always put braces around 'if' blocks. 😉 Almost always. :P Thanks, Richard -- Check out the vibrant tech community on one of the world's most engagin

Re: [Linuxptp-devel] [PATCH RFC V2 10/11] util: Relocate utility functions from pmc.c.

2018-03-06 Thread Richard Cochran
On Mon, Mar 05, 2018 at 01:00:03PM +, Anders Selhammer wrote: > Shouldn't this be moved also from pmc.c to util: No, we only move code when we have to. That function is not (yet) needed outside of pmc.c. Thanks, Richard ---