Re: [Linuxptp-devel] [PATCH v2 1/4] phc2sys: Implement configuration file handling

2018-03-24 Thread Richard Cochran 
On Fri, Mar 23, 2018 at 01:24:35PM +0100, Peter Schneider wrote:
> @@ -1477,6 +1482,10 @@ int main(int argc, char *argv[])
>   }
>   }
>  
> + if (config && (c = config_read(config, cfg))) {
> + return c;
> + }
> +

This is not quite right.  I noticed that some of the run time
variables do *not* go through the config API, but they should:

   | phc2sys variable   | config. option|
   |+---|
   | domain_number  | domainNumber  |
   | node.kernel_leap   | kernel_leap   |
   | node.sanity_freq_limit | sanity_freq_limit |
   | node.servo_type| clock_servo   |
   | print_level| logging_level |
   | use_syslog | use_syslog|
   | verbose| verbose   |

After adding the '-f' option, the user expects that changing the
option in the file will change the variable in the program, but as of
now this will have no effect.

So before adding the config file option, we first must clean up how
these variables are assigned.

Thanks,
Richard


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Re: [Linuxptp-devel] [PATCH v2 3/3] pmc: Documentation for long opts / cfg file

2018-03-24 Thread Richard Cochran 
On Thu, Mar 22, 2018 at 12:28:34AM +0100, Peter Schneider wrote:
> +Be cautious when the same configuration file is used for both ptp4l and pmc.
> +Keep in mind, that values specified in the configuration file take precedence
> +over their default values. If a certain option, which is common to ptp4l and
> +pmc, is specified to a non-default value in the configuration file
> +(p.e., for ptp4l), then this non-default value applies also for pmc. This
> +might be not what is expected.

I removed some of the commas.  (I know that proper German requires way
more commas than English ;)

Thanks,
Richard


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Re: [Linuxptp-devel] [PATCH v3 0/2] Add TAILQ for sent delay_req

2018-03-24 Thread Richard Cochran 
On Wed, Mar 21, 2018 at 08:24:24PM +0100, Anders Selhammer wrote:
> In a ptp unaware network (like the telecom profile for frequency sync
> G.8265.1), both the RTD and the PDV can be substantially higher than
> in a ptp aware network. To achieve more accurate measurements, the
> rate may need to be configured higher to get more data and increase
> the chance of lucky packets.
> In a combination of a high configured rate of delay_req and high
> RTD/PDV in network, the risk that the response from the previously
> sent delay_req have not been received before a new delay_req is sent
> also become high. In that case, the need of storing more than the
> latest sent delay_req arise.
> 
> Anders Selhammer (2):
>   port: Fix coding style
>   port: Added TAILQ for sent delay_req

Series applied.

Thanks,
Richard

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel