Re: [Linuxptp-devel] [PATCH 0/8] unicast part III - server support

2018-07-06 Thread Anders Selhammer
Richard Cochran > This series completes the unicast and telecom support by adding the > server side of the equation. The first patch introduces a priority > queue in order to service any number of clients, each with its own > interval (as required by the telecom profile). In that way we can >

Re: [Linuxptp-devel] [PATCH_SNMP_v3 0/5] Add support of snmp

2018-07-06 Thread Anders Selhammer
Friday, July 6, 2018 8:17 AM > These first two patches are fine, and I'll merge them soon. Great > The code in snmpd.c looks fine to me. It´s not that complicated when using this AgentX master agent > The name 'snmpd' is a not a good choice. The net-snmp project already > delivers a program

Re: [Linuxptp-devel] [PATCH_SNMP_v3 0/5] Add support of snmp

2018-07-06 Thread Anders Selhammer
Richard Cochran Maybe I was too fast on the send button. > We are building an AgentX, are we not? So let's use a unique name >that is also more descriptive. We are building an snmp sub agent using the AgentX protocol towards the master agent supporting AgentX protocol. So we are not really

Re: [Linuxptp-devel] [PATCH 0/8] unicast part III - server support

2018-07-06 Thread Richard Cochran
On Fri, Jul 06, 2018 at 08:11:54AM +, Anders Selhammer wrote: > When are you planning to merge the unicast and telecom support? I already pushed the finished series out to git master. > What if there are limitations such as maximum number of slaves or > maximum number of packets / second

Re: [Linuxptp-devel] [PATCH_SNMP_v3 0/5] Add support of snmp

2018-07-06 Thread Richard Cochran
On Fri, Jul 06, 2018 at 07:33:12AM +, Anders Selhammer wrote: > snmp4lptp - SNMP 4 Linux PTP > > like the last one Ok, I'll re-work your patches using that name and post them for your review. (I think its easier for me just to change the makefile myself rather than trying to explain what

Re: [Linuxptp-devel] [PATCH_SNMP_v3 2/5] pdt: Added check if already defined

2018-07-06 Thread Richard Cochran
On Mon, Jun 18, 2018 at 12:21:39PM +0200, Anders Selhammer wrote: > TRUE and FALSE is also defined in net-snmp library. Without this check, > compilation and includes must be made in a certain order. Applied. Thanks, Richard

Re: [Linuxptp-devel] [PATCH_SNMP_v3 1/5] pmc: Move new common funtionality into pmc_common

2018-07-06 Thread Richard Cochran
On Mon, Jun 18, 2018 at 12:21:38PM +0200, Anders Selhammer wrote: > Code from pmc.c will be reused by new snmpd.c in later commit. Applied. Thanks, Richard -- Check out the vibrant tech community on one of the world's

[Linuxptp-devel] [PATCH RFC 1/3] snmp4lptp: Add snmp sub agent

2018-07-06 Thread Richard Cochran
From: Anders Selhammer The sub agent use net-snmp library and AgentX protocol for the communication towards the snmp master agent. snmp4lptp.c should only include general setup needed for handling snmp. Supported MIBs should be implemented in separate files. Makefile will include snmp4lptp if

[Linuxptp-devel] [PATCH RFC 0/3] Basis for SNMP support

2018-07-06 Thread Richard Cochran
This series is a rework of Anders' SNMP v3 series. Here is what changed: - dropped first two patches as they have been merged - renamed snmpd to snmp4lptp to avoid clash with net-snmp - simplified build - support cross compilation Please review and test! Thanks, Richard Anders Selhammer (3):

[Linuxptp-devel] [PATCH RFC 2/3] snmp4lptp: Added communication to ptp4l via the UDS port.

2018-07-06 Thread Richard Cochran
From: Anders Selhammer UDS transport is configured using pmc_common functions. [ RC: trivial makefile update ] Signed-off-by: Anders Selhammer Signed-off-by: Richard Cochran --- makefile| 3 +- snmp4lptp.c | 102 ++-- 2 files

[Linuxptp-devel] [PATCH RFC 3/3] snmp4lptp: Add snmp4lptp_run_pmc for data collection from ptp4l program.

2018-07-06 Thread Richard Cochran
From: Anders Selhammer General function to use for sending signals for data collection from ptp4l program. Signed-off-by: Anders Selhammer Signed-off-by: Richard Cochran --- snmp4lptp.c | 37 + snmp4lptp_mib.h | 30 ++ 2

Re: [Linuxptp-devel] [PATCH_SNMP_v3 0/5] Add support of snmp

2018-07-06 Thread Richard Cochran
On Mon, Jun 18, 2018 at 12:21:37PM +0200, Anders Selhammer wrote: > Add of the first step of supporting SNMP communication to linuxptp. > This patchset only adds the basics for SNMP. The support of published > MIBs will be added later on. > Support of cross compilation will also be included later