Re: [Linuxptp-devel] [PATCH] add report of PTP_SYS_OFFSET_PRECISE support to phc_ctl

2018-08-20 Thread Miroslav Lichvar
On Sat, Aug 18, 2018 at 10:07:59AM -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 03:22:51PM +, FUSTE Emmanuel wrote: > > diff --git a/phc_ctl.c b/phc_ctl.c > > index 4a78a19..f6234da 100644 > > --- a/phc_ctl.c > > +++ b/phc_ctl.c > > @@ -353,12 +353,14 @@ static int do_caps(clockid_t

Re: [Linuxptp-devel] [PATCH RFC 0/3] Basis for SNMP support

2018-08-20 Thread Richard Cochran
On Mon, Aug 20, 2018 at 08:03:58AM +, Anders Selhammer wrote: > I guess you want me to update the serie with the updates before, right? Yes, please. IIRC, you had some additional changes... Thanks, Richard -- Check

Re: [Linuxptp-devel] [PATCH] add report of PTP_SYS_OFFSET_PRECISE support to phc_ctl

2018-08-20 Thread Richard Cochran
On Mon, Aug 20, 2018 at 09:00:33AM +0200, Miroslav Lichvar wrote: > Do we? In this case the string is printed by pr_notice(), which should > add a newline automatically when printing to terminal. Oh, you're right. Never mind! Thanks, Richard -

Re: [Linuxptp-devel] [PATCH RFC 0/3] Basis for SNMP support

2018-08-20 Thread Anders Selhammer
Thursday, July 26, 2018 9:34 AM >Thursday, July 26, 2018 2:39 AM >> Sounds good. >You will apply the series without updates and I include it in next series then? >Then I do not need to poll the mail the next few days 😊 Hi Im back from vacation and since you have not applied the patches yet, I gue

[Linuxptp-devel] Master still sends out DELAY_REQ

2018-08-20 Thread Vincent Li X
Hi, We found a tricky scenario is that after port goes from SLAVE->MASTER state, it still sends out DELAY_REQ continuously by default interval. Given that we are running interval as -6, the delay interval is random(0, 2*2pow interval), the timer could be short. Could the reason be like this?

Re: [Linuxptp-devel] Master still sends out DELAY_REQ

2018-08-20 Thread Richard Cochran
On Mon, Aug 20, 2018 at 03:20:12PM +, Vincent Li X wrote: > Could the reason be like this? > > 1. Event we cancel the FD_DELAY_TIMER? ... > 1. But there is already timeout event on epoll? > 2. Soon epoll event comes, we re-arm the FD_DELAY_TIMER again. This was changed in: commi

Re: [Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

2018-08-20 Thread Patel, Vedang
Thanks for the feedback Richard. On Fri, 2018-08-17 at 23:33 -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 10:42:10AM -0700, Vedang Patel wrote: > > > > > > Changes in V2: > > ~~~ > This looks a lot better, thanks!  I'll have a few small comments on > the patches... >   > > >

Re: [Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

2018-08-20 Thread Patel, Vedang
On Fri, 2018-08-17 at 23:50 -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 10:42:10AM -0700, Vedang Patel wrote: > > > > - In port_p2p_transition(), we are setting up the delay timer when > > BMCA is set > >   as ‘noop’. Usually it is initialized then the device transitions > > to > >   P

Re: [Linuxptp-devel] [RFC v2 0/5] Adding support for AVnu Automotive Profile

2018-08-20 Thread Patel, Vedang
On Sat, 2018-08-18 at 00:03 -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 10:42:10AM -0700, Vedang Patel wrote: > > > > - In port_p2p_transition(), we are setting up the delay timer when > > BMCA is set > >   as ‘noop’. Usually it is initialized then the device transitions > > to > >   P

Re: [Linuxptp-devel] [RFC v2 2/5] Add BMCA config option.

2018-08-20 Thread Patel, Vedang
On Sat, 2018-08-18 at 00:07 -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 10:42:12AM -0700, Vedang Patel wrote: > > > > diff --git a/fsm.c b/fsm.c > > index ce6efad30937..a0c98891e39f 100644 > > --- a/fsm.c > > +++ b/fsm.c > > @@ -335,3 +335,103 @@ enum port_state ptp_slave_fsm(enum port

Re: [Linuxptp-devel] [RFC v2 4/5] Add ignore_source_id config option.

2018-08-20 Thread Patel, Vedang
On Sat, 2018-08-18 at 00:11 -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 10:42:14AM -0700, Vedang Patel wrote: > > > > > +static int check_source_identity(struct port *p, struct > > ptp_message *m) > > +{ > > + struct PortIdentity master; > > + > > + if (!p->ignore_source_id) { > >

Re: [Linuxptp-devel] [RFC v2 5/5] Add example configuration for AVnu Automotive Profile.

2018-08-20 Thread Patel, Vedang
On Sat, 2018-08-18 at 00:22 -0400, Richard Cochran wrote: > On Thu, Aug 16, 2018 at 10:42:15AM -0700, Vedang Patel wrote: > > > >  create mode 100644 configs/AVnu-master.cfg > >  create mode 100644 configs/AVnu-slave.cfg > IIRC, AVnu had some earlier best practice paper about using 802.1-AS. > So

Re: [Linuxptp-devel] [RFC v2 5/5] Add example configuration for AVnu Automotive Profile.

2018-08-20 Thread Richard Cochran
On Tue, Aug 21, 2018 at 12:51:18AM +, Patel, Vedang wrote: > Also, do you want me to remove AVnu from the whole series code/commit > message or just the config file names? I would just remove the word "AVnu" everywhere and just say, the automotive profile. I want to avoid making the impressio