Re: [Linuxptp-devel] PPS generation on BeagleBoneBlack

2020-03-11 Thread Richard Cochran
On Wed, Mar 11, 2020 at 02:31:29PM +0530, Lokesh Vutla wrote: > > This is the userspace program I have worked on to get the synchronization > working. Currently the servo part of the tool is in very hacky shape. Before > cleanup I wanted to get more inputs on where it can be integrated. But

Re: [Linuxptp-devel] PPS generation on BeagleBoneBlack

2020-03-11 Thread Lokesh Vutla via Linuxptp-devel
Hi Richard, On 10/03/20 7:02 PM, Richard Cochran wrote: > On Tue, Mar 10, 2020 at 01:17:40PM +0530, Lokesh Vutla wrote: >> Timer resolution is entirely dependent on the input clock frequency. 30us >> resolution is true only if the input clock frequency of DMTIMER is 32KHz. >> AM335x[0] and later

[Linuxptp-devel] [PATCH V2 1/6] clock: Safely remove event subscribers from list.

2020-03-11 Thread Richard Cochran
When updating and potentially removing event subscribers, the code uses the simple list traversal macro. As a result, the list will become corrupted whenever a subscriber is removed. This patch fixes the issue by using the appropriate macro. Fixes: 5104e3e56b59 ("Event subscribing")

[Linuxptp-devel] [PATCH V2 2/6] Remove the unfinished SNMP code.

2020-03-11 Thread Richard Cochran
Unfortunately the SNMP code still has issues like not passing the valgrind test, and no one is able to finish this up right now. This patch removes the SNMP program so that the upcoming release does not contain unfinished work, potentially misleading end users about the scope and completeness of

[Linuxptp-devel] [PATCH V2 6/6] Provide a method to convert a tmv_t into a timespec.

2020-03-11 Thread Richard Cochran
Currently there is a method to convert a timespec into a tmv_t, but not the other way round. This patch adds the missing function in anticipation of a new feature that will need this conversion. Signed-off-by: Richard Cochran --- tmv.h | 10 ++ 1 file changed, 10 insertions(+) diff

[Linuxptp-devel] [PATCH V2 3/6] Balance the posix clock open function with a close method.

2020-03-11 Thread Richard Cochran
The one user of the function, posix_clock_open(), simply open codes the closing call to phc_close(). This patch provides a method to balance closing and opening of a posix clock. In addition, the phc_ctl program never explicitly closed the opened clock, and so this patch adds the missing call.

[Linuxptp-devel] [PATCH V2 4/6] Add definitions for PTP pin ioctls for backwards kernel compatibility.

2020-03-11 Thread Richard Cochran
Upcoming functionality will need to configure the input and output pins of PHC devices. However, this requires fairly recent kernel support. This patch adds the needed definitions for compiling with older kernel headers. In addition, kernel v5.4 introduced a second set of ioctls for the

[Linuxptp-devel] [PATCH V2 0/6] Clean up in preparation for GrandMaster support.

2020-03-11 Thread Richard Cochran
I have been preparing Balint Ferencz's ts2phc program for review on this list. The present series presents a mixture of fixes and new code in support of the upcoming GrandMaster features. Patches 1-3 are random fixes found along the way. Patches 4-6 add new helper code, preparing for GM support.

[Linuxptp-devel] [PATCH V2 5/6] Add PHC methods for querying and configuring the pin functionality.

2020-03-11 Thread Richard Cochran
In anticipation of support for external time stamping in PHC devices, this patch adds wrapper functions around the pin functionality. Signed-off-by: Richard Cochran --- phc.c | 23 +-- phc.h | 21 + 2 files changed, 42 insertions(+), 2 deletions(-) diff

Re: [Linuxptp-devel] [PATCH V2 4/6] Add definitions for PTP pin ioctls for backwards kernel compatibility.

2020-03-11 Thread Jacob Keller
On 3/11/2020 11:24 AM, Richard Cochran wrote: > Upcoming functionality will need to configure the input and output pins of > PHC devices. However, this requires fairly recent kernel support. This > patch adds the needed definitions for compiling with older kernel headers. > > In addition,

Re: [Linuxptp-devel] [PATCH V2 2/6] Remove the unfinished SNMP code.

2020-03-11 Thread Jacob Keller
On 3/11/2020 11:24 AM, Richard Cochran wrote: > Unfortunately the SNMP code still has issues like not passing the > valgrind test, and no one is able to finish this up right now. This > patch removes the SNMP program so that the upcoming release does not > contain unfinished work, potentially

Re: [Linuxptp-devel] [PATCH V2 1/6] clock: Safely remove event subscribers from list.

2020-03-11 Thread Jacob Keller
On 3/11/2020 11:24 AM, Richard Cochran wrote: > When updating and potentially removing event subscribers, the code uses > the simple list traversal macro. As a result, the list will become > corrupted whenever a subscriber is removed. This patch fixes the issue > by using the appropriate macro.