Re: [Linuxptp-devel] [PATCH] improve port log messages

2021-01-04 Thread Cliff Spradlin via Linuxptp-devel
On Mon, Jan 4, 2021 at 4:28 AM Richard Cochran wrote: > Why not refactor them all to use a helper function? The new function could be called port2str(struct port *p) and live in port.c. >See cid2str() in util.c as an example. This sounds good to me. However, cid2str() uses static storage and th

Re: [Linuxptp-devel] [PATCH] improve port log messages

2021-01-04 Thread Richard Cochran
On Tue, Jan 05, 2021 at 11:20:09AM +0900, Cliff Spradlin wrote: > This sounds good to me. However, cid2str() uses static storage and > there are several log messages that log information about multiple > ports. You mean 2+ ports appear in the same pr_xyz() message? I guess I didn't notice that...