Read returns 0 (the traditional "end-of-file" return) when a remote
peer performs an orderly shutdown. Hence, ts2phc needs to close the
socket and try to establish a new connection.
Signed-off-by: Lars Munch
---
ts2phc_nmea_master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Add serial baudrate configuration option. Default to 9600 bps.
Signed-off-by: Lars Munch
---
config.c | 1 +
ts2phc.8 | 23 ---
ts2phc_nmea_master.c | 10 +-
3 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/config.c b/config.c
tm_isdst needs to be initialized to make sure mktime does not fail
on recent versions of glibc
See:
https://bugzilla.redhat.com/show_bug.cgi?id=1653340
https://sourceware.org/bugzilla/show_bug.cgi?id=24630
Signed-off-by: Lars Munch
---
nmea.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Update leapfile documentation to note the file will be
reloaded if modified.
Signed-off-by: Lars Munch
---
ts2phc.8 | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ts2phc.8 b/ts2phc.8
index 0bd523d..99067c5 100644
--- a/ts2phc.8
+++ b/ts2phc.8
@@ -117,12 +117,12
So much work for a one-liner. I see If I can come up with a better explanation.
On Fri, May 14, 2021 at 4:34 PM Geva, Erez wrote:
>
> Hi,
>
>
>
> I think it is better to use a short explanation how does mktime() use the
> tm_isdst flag, and why should it be set to 0.
>
> For me the problem is
Yes.
-Original Message-
From: Lars Munch
Sent: Friday, 14 May 2021 18:20
To: Geva, Erez (ext) (DI PA DCP R 3)
Cc: linuxptp-devel@lists.sourceforge.net
Subject: Re: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer shutdown
On Fri, May 14, 2021 at 4:24 PM Geva, Erez wrote:
>
>
On Fri, May 14, 2021 at 4:45 PM Geva, Erez wrote:
>
> A great idea to add baud-rate.
>
> Just a suggestion,
> As I remember from gtkterm application.
>
> It provide setting: port name, Baud rate, parity, bits, stop bit, and flow
> control.
>
> What do you think of adding all of the setting?
I
On Fri, May 14, 2021 at 4:24 PM Geva, Erez wrote:
>
> Make sense to handle 0, end of file.
> But as it is NOT an error, perhaps it should use a proper pr_info().
So something like this?
cnt = read(pfd.fd, input, sizeof(input));
if (cnt <= 0) {
if (cnt == 0)
pr_info("disconnected
Make sense to handle 0, end of file.
But as it is NOT an error, perhaps it should use a proper pr_info().
Erez
-Original Message-
From: Lars Munch
Sent: Friday, 14 May 2021 13:34
To: linuxptp-devel@lists.sourceforge.net
Subject: [Linuxptp-devel] [PATCH 2/4] ts2phc: Close socket on peer
A great idea to add baud-rate.
Just a suggestion,
As I remember from gtkterm application.
It provide setting: port name, Baud rate, parity, bits, stop bit, and flow
control.
What do you think of adding all of the setting?
Erez
-Original Message-
From: Lars Munch
Sent: Friday, 14
Hi,
I think it is better to use a short explanation how does mktime() use the
tm_isdst flag, and why should it be set to 0.
For me the problem is that we did not comply with proper use of mktime().
Fixing glibc only revealed the bug in linuxptp.
So we fix linuxptp, not trying to comply with
On Fri, May 14, 2021 at 7:33 PM Richard Cochran
wrote:
>
> On Thu, May 13, 2021 at 07:31:27PM +0200, Lars Munch wrote:
> > On Sat, May 8, 2021 at 8:47 PM Richard Cochran
> > wrote:
> > >
> > > On Sat, May 08, 2021 at 02:57:30PM +0200, Lars Munch wrote:
> > >
> > > > 1. Use the time provided by
I will just take your comment suggestion. I do not want to spend more
time on this.
On Fri, May 14, 2021 at 7:50 PM Geva, Erez wrote:
>
> I think you can mention you are talking on UTC (Every one know UTC).
>
> May be something like:
> "As UTC do not use daylight savings time and with accords to
> -Original Message-
> From: Lars Munch
> Sent: Friday, May 14, 2021 4:34 AM
> To: linuxptp-devel@lists.sourceforge.net
> Subject: [Linuxptp-devel] [PATCH 3/4] ts2phc: Update leapfile documentation
>
> Update leapfile documentation to note the file will be
> reloaded if modified.
>
>
> -Original Message-
> From: Aya Levin
> Sent: Thursday, May 13, 2021 4:37 AM
> To: linuxptp-devel@lists.sourceforge.net
> Subject: [Linuxptp-devel] ptp4l L2 with rx-fcs
>
> Hi,
>
> While debugging the same issue, I found this thread
>
No, ts2phc does. That is the man page updated.
On Fri, May 14, 2021 at 8:52 PM Keller, Jacob E
wrote:
>
>
>
> > -Original Message-
> > From: Lars Munch
> > Sent: Friday, May 14, 2021 4:34 AM
> > To: linuxptp-devel@lists.sourceforge.net
> > Subject: [Linuxptp-devel] [PATCH 3/4] ts2phc:
One of my hardest bug was one a single bit.
Do not measure bugs by code. Measure by complexity.
Erez
-Original Message-
From: Lars Munch
Sent: Friday, 14 May 2021 18:14
To: Geva, Erez (ext) (DI PA DCP R 3)
Cc: linuxptp-devel@lists.sourceforge.net
Subject: Re: [Linuxptp-devel] [PATCH
So how about the following simple explanation?
According to POSIX.1-2017 tm_isdst must be set to 0 to indicate that
Daylight Savings Time
is not in effect for the specified time.
On Fri, May 14, 2021 at 6:28 PM Geva, Erez wrote:
>
> One of my hardest bug was one a single bit.
> Do not measure
> I did think of that, yet of the many serial devices I have used they have all
> been running with the setting 8/N/1 and no HW flow control.
The HP Z3801A is 19200 baud, 7 data bits, odd parity
--
These are my opinions. I hate spam.
___
On Thu, May 13, 2021 at 07:31:27PM +0200, Lars Munch wrote:
> On Sat, May 8, 2021 at 8:47 PM Richard Cochran
> wrote:
> >
> > On Sat, May 08, 2021 at 02:57:30PM +0200, Lars Munch wrote:
> >
> > > 1. Use the time provided by gpsd to ntpshm. This can be implemented
> > > without
> > >
I think you can mention you are talking on UTC (Every one know UTC).
May be something like:
"As UTC do not use daylight savings time and with accords to POSIX, disable the
use of daylight savings by setting tm_isdst to 0".
Feel free to find a better syntax.
Or just copy the 2 lines from the
21 matches
Mail list logo
