Re: [Linuxptp-devel] [PATCH v2 1/1] Fix management TLV print.

On Sun, 15 May 2022 at 03:03, Richard Cochran wrote: > On Mon, May 02, 2022 at 12:09:42PM +0200, Erez Geva wrote: > > Use proper management TLV name in print. > > Use a simple 16 unsigned bits format. > > > > Signed-off-by: Erez Geva > > Applied. > > Could you also submit a patch to fix up test

[Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2

From: SyncMonk 1. Inclusion of virtual PTP port on a PTP clock. (G.8275 Annex B) 2. Alternate master support (G.8275.2 Section 6.9 and G.8275.2 Appendix III) 3. TLV support for interface rate (G.8275.2 Annex D) When master and slave instance interacting with each other operating at differen

Re: [Linuxptp-devel] [PATCHv2 3/4] sysoff: Retry on failure when probing supported ioctls.

On Sat, May 14, 2022 at 12:38:31PM -0700, Richard Cochran wrote: > On Thu, Mar 24, 2022 at 02:19:51PM +0100, Miroslav Lichvar wrote: > > When probing support for a PTP_SYS_OFFSET ioctl, assume errors other > > than EOPNOTSUPP and EINVAL are temporary errors (some drivers are known > > to return wit

[Linuxptp-devel] Question regarding terminology of Master and Slave

Hi, I remember we had a discussion on the matter. And decide to rename "Master" to "source" and "Slave" to "sink". My questions are: 1. I see in the code "client", for example "clientOnly" mode. When do we use "client" and when do we use "sink"? Are they the same or represent different

Re: [Linuxptp-devel] Question regarding terminology of Master and Slave

We should be following the guidelines being set by the IEEE 1588 working group – on this topic, specifically IEEE SA - P1588g This amendment adds an optional alternative suitable and inclusive terminology to the terms “master” and “slave” but it do

Re: [Linuxptp-devel] Question regarding terminology of Master and Slave

On Mon, May 16, 2022 at 12:02:22PM +0200, Erez wrote: > Hi, > > I remember we had a discussion on the matter. > And decide to rename "Master" to "source" and "Slave" to "sink". > > My questions are: > >1. I see in the code "client", for example "clientOnly" mode. >When do we use "client"

Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2

On Mon, May 16, 2022 at 02:08:06PM +0530, SyncMonk Technologies wrote: > From: SyncMonk > > 1. Inclusion of virtual PTP port on a PTP clock. (G.8275 Annex B) > 2. Alternate master support (G.8275.2 Section 6.9 and G.8275.2 Appendix III) > 3. TLV support for interface rate (G.8275.2 Annex D) >

Re: [Linuxptp-devel] [PATCHv2 3/4] sysoff: Retry on failure when probing supported ioctls.

On Mon, May 16, 2022 at 11:37:58AM +0200, Miroslav Lichvar wrote: > On Sat, May 14, 2022 at 12:38:31PM -0700, Richard Cochran wrote: > > On Thu, Mar 24, 2022 at 02:19:51PM +0100, Miroslav Lichvar wrote: > > > When probing support for a PTP_SYS_OFFSET ioctl, assume errors other > > > than EOPNOTSUPP

Re: [Linuxptp-devel] [PATCHv3 2/8] rtnl: Add function to detect virtual clocks.

On Tue, Mar 08, 2022 at 11:46:59AM +0100, Miroslav Lichvar wrote: > Add a function using ethtool netlink to check whether a PHC is a virtual > clock of an interface. > > Signed-off-by: Miroslav Lichvar > Acked-by: Hangbin Liu > --- > incdefs.sh | 4 +++ > missing.h | 101

Re: [Linuxptp-devel] [PATCH v5 05/13] ts2phc: create a private data structure

On Sun, May 15, 2022 at 01:24:13PM -0700, Richard Cochran wrote: > On Tue, Nov 23, 2021 at 02:14:13AM +0200, Vladimir Oltean wrote: > > > diff --git a/ts2phc.h b/ts2phc.h > > new file mode 100644 > > index ..14cb2b0c21a3 > > --- /dev/null > > +++ b/ts2phc.h > > @@ -0,0 +1,23 @@ > > +/*

Re: [Linuxptp-devel] [PATCH v5 05/13] ts2phc: create a private data structure

On Mon, May 16, 2022 at 06:48:04PM +0300, Vladimir Oltean wrote: > Anyway I've moved it here, will resend after retesting if there are no > other comments. I'll go through the rest, so hold off for now please... Thanks, Richard ___ Linuxptp-devel mai

Re: [Linuxptp-devel] [PATCHv3 2/8] rtnl: Add function to detect virtual clocks.

On Mon, May 16, 2022 at 06:19:01PM +0300, Vladimir Oltean wrote: > What I usually do when I need to determine whether a feature is > available is to compile a dummy C program using the same CFLAGS as the > main program itself. Well you probably love autoconf then. I don't. What I have for linux

Re: [Linuxptp-devel] [PATCHv3 2/8] rtnl: Add function to detect virtual clocks.

On Mon, May 16, 2022 at 09:30:22AM -0700, Richard Cochran wrote: > On Mon, May 16, 2022 at 06:19:01PM +0300, Vladimir Oltean wrote: > > > What I usually do when I need to determine whether a feature is > > available is to compile a dummy C program using the same CFLAGS as the > > main program itse