[Linuxptp-devel] [PATCHv3 3/5] sysoff: Change log level of ioctl error messages.

2022-05-18 Thread Miroslav Lichvar
Change the log level of ioctl error messages to the error level to make them visible in default configuration, with the exception of EOPNOTSUPP which is expected in probing and should stay at the debug level to avoid confusing users. Signed-off-by: Miroslav Lichvar --- sysoff.c | 14 +++-

[Linuxptp-devel] [PATCHv3 4/5] sysoff: Retry on EBUSY when probing supported ioctls.

2022-05-18 Thread Miroslav Lichvar
Handle EBUSY when probing support for a PTP_SYS_OFFSET ioctl. Try each ioctl up to three times before giving up on it to make the detection more reliable. Signed-off-by: Miroslav Lichvar --- sysoff.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sysoff.c b/s

[Linuxptp-devel] [PATCHv3 5/5] phc2sys: Don't exit when reading of PHC fails with EBUSY.

2022-05-18 Thread Miroslav Lichvar
Reading of the PHC can occasionally fail with some drivers, e.g. the ice driver returns EBUSY when it fails to get a lock. Continue in the loop instead of exiting on the error. Signed-off-by: Miroslav Lichvar --- phc2sys.c | 50 +- 1 file changed,

[Linuxptp-devel] [PATCHv3 0/5] Handle temporary errors in reading of PHC

2022-05-18 Thread Miroslav Lichvar
v3: - limited ignored errors to EBUSY - requires new patch for clockadj_compare() - reduced number of retries from 99 to 2 - changed log level of non-EOPNOTSUPP ioctl error messages v2: - added patches to make probing more reliable This patchset improves phc2sys to handle the EBUSY error in rea

[Linuxptp-devel] [PATCHv3 1/5] clockadj: Change clockadj_compare() to return errno.

2022-05-18 Thread Miroslav Lichvar
Return -errno from the failed clock_gettime() to allow the callers to check for specific errors. Signed-off-by: Miroslav Lichvar --- clockadj.c | 3 ++- clockadj.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/clockadj.c b/clockadj.c index e8c5789..957dc57 100644 --- a/c

[Linuxptp-devel] [PATCHv3 2/5] sysoff: Change sysoff_measure() to return errno.

2022-05-18 Thread Miroslav Lichvar
Return -errno from failed ioctl instead of the SYSOFF_* enum from the measurement functions to allow the callers to check for specific errors. Signed-off-by: Miroslav Lichvar --- sysoff.c | 15 --- sysoff.h | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/sysof

Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2

2022-05-18 Thread Richard Cochran
On Wed, May 18, 2022 at 11:27:08AM +0530, Devasish Dey wrote: > 1. We have invested time in development and have been verified by the team > as a complete solution which is addressing the requirements of G.8275.2 > Breaking the changes into small patches may lead to intermediate > functionality br

Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2

2022-05-18 Thread Richard Cochran
On Wed, May 18, 2022 at 11:27:08AM +0530, Devasish Dey wrote: > That's why we have added, "> + * @note Copyright (C) 2022 SyncMonk > Technologies " in all the files modified by SyncMonk > Technologies. And we recommend that this practice should be adopted by > community members. Good luck with t

Re: [Linuxptp-devel] [PATCH] Adding following features to support Telecom profile G.8275.2

2022-05-18 Thread Devasish Dey
Hi Petr, Seems it was misinterpreted, it was just a suggestion from our end if the patch can be taken as a full for G.8275.2 functionality. We are in the process of making the changes in small multiple patches so that they can be easily acceptable by the community. Thanks, Devasish On Wed, 18 May