Re: [Linuxptp-devel] [PATCH] ptp4l: Allow setting of socket priority for UDPv4/UDPv6

2022-09-25 Thread Richard Cochran
On Mon, Sep 05, 2022 at 04:35:58PM +0200, Kurt Kanzenbach wrote: > Yes, this should work. Thanks! Kurt, Does this mean you can use the dscp_ settings, and the new "socket_priority" from your patch isn't needed? Thanks, Richard ___ Linuxptp-devel ma

Re: [Linuxptp-devel] Planning release 3.2

2022-09-25 Thread Richard Cochran
On Tue, May 04, 2021 at 04:46:59AM -0700, Richard Cochran wrote: > On Mon, May 03, 2021 at 05:09:09PM +0200, Michael Walle wrote: > > did I miss something or wasn't there a 3.2 release? > > You didn't miss anything. I have been delayed in pushing out the 3.2 > release. Next release will be 4.0 a

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Richard Cochran
On Thu, Jul 21, 2022 at 03:10:40PM +0530, Siddharth Vadapalli via Linuxptp-devel wrote: > Remove the unreachable switch case TS_SOFTWARE. > > Signed-off-by: Siddharth Vadapalli > --- > sk.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/sk.c b/sk.c > index b55d6b5..a49bcf4 100644 >

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Richard Cochran
On Thu, Jul 21, 2022 at 01:20:47PM +, Geva, Erez wrote: > Hi, > > I think the "if (type != TS_SOFTWARE" is wrong. > The "type" only refer to TX. No, "type" is an enumerated value, timestamp_type, and it describes the flavor of time stamping in use. > But hwts_init() also set the RX. > So no

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Richard Cochran
On Sun, Sep 25, 2022 at 11:37:31AM -0700, Michael Galassi wrote: > I've developed the habit of closing all non-exhaustive switches where > no sensible default exists with a default which asserts with a > meaningful diagnostic. Doing so has helped me find a number of my own > mistaken assumptions.

Re: [Linuxptp-devel] [PATCH] sk.c: Unreachable switch case TS_SOFTWARE

2022-09-25 Thread Michael Galassi
On Sun, Sep 25, 2022 at 11:23 AM Richard Cochran wrote: > > On Thu, Jul 21, 2022 at 03:10:40PM +0530, Siddharth Vadapalli via > Linuxptp-devel wrote: > > Remove the unreachable switch case TS_SOFTWARE. > > > > Signed-off-by: Siddharth Vadapalli > > --- > > sk.c | 3 --- > > 1 file changed, 3 de