Re: [Linuxptp-devel] [PATCH v3 3/3] Adding support for passing announce message from external source

2022-10-08 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:13PM +0530, SyncMonk Technologies wrote: > @@ -426,7 +427,10 @@ int ts2phc_pps_sink_poll(struct ts2phc_pps_source *src) > > err = ts2phc_pps_source_getppstime(src, &source_ts.ts); > source_ts.valid = err ? false : true; > - > + if (source_ts.valid) {

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-08 Thread Richard Cochran
On Thu, Oct 06, 2022 at 08:58:31PM +0530, SyncMonk Tech Services wrote: > Please let us know if there are any action items on us related to this or > other patches raised by SyncMonk. You need to address the review comments: As presented, this functionality won't work correctly. If the ts2phc

Re: [Linuxptp-devel] [PATCH v3 2/3] adding virtual port support for ts2phc

2022-10-08 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:12PM +0530, SyncMonk Technologies wrote: > +static int ts2phc_vport_init_sync(struct ts2phc_vport *p, > + struct address address) > +{ > + > + struct ptp_message *msg; > + > + msg = msg_allocate(); > + if (!msg) { > +

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-08 Thread Richard Cochran
On Fri, Sep 02, 2022 at 12:26:11PM +0530, SyncMonk Technologies wrote: > diff --git a/clock.c b/clock.c > index d37bb87..eba0833 100644 > --- a/clock.c > +++ b/clock.c > @@ -97,9 +97,10 @@ struct clock { > LIST_HEAD(ports_head, port) ports; > struct port *uds_rw_port; > struct po

Re: [Linuxptp-devel] [PATCH v3 1/3] Adding virtual PTP port support

2022-10-08 Thread Richard Cochran
On Sat, Oct 08, 2022 at 01:24:23PM -0700, Richard Cochran wrote: > Why can't the virtual port function be an option for the UDS port > already in place? To answer my own question, it needs to be in the list of "normal" ports in order to participate in the BCMA. But as I said, there is no need fo

Re: [Linuxptp-devel] [PATCH v5] Strip Parallel Redundancy Protocol (PRP) trailer

2022-10-08 Thread Richard Cochran
On Tue, Aug 09, 2022 at 08:26:08AM +0300, Magnus Armholt wrote: > Strip the IEC62439-3 PRP trailer if it is present > to support PTP over PRP. Fails when building against Linux kernel 3.0 headers (the earliest supported kernel version). /home/richard/git/linuxptp/raw.c: In function ‘has_prp_trail

Re: [Linuxptp-devel] [PATCH 3/3] [Interface Rate TLV] adding TLV support

2022-10-08 Thread Richard Cochran
On Tue, Jul 26, 2022 at 06:26:46PM +0530, Devasish Dey wrote: > > > + GLOB_ITEM_INT("interface_rate_tlv", 0, 0, 1), > > > > Why is it not a port-specific option? If you reject a suggestion, it's > > a good practice to explain your reasoning. > > > [Devasish]: It is for TLV support and this see

Re: [Linuxptp-devel] [PATCH 1/4] [Interface Rate TLV] function to support get interface speed via ethtool

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:19PM +0530, SyncMonk Technologies wrote: > +/** > + * Contains interface information returned by theGLINKSETTINGS ioctl. > + * @valid:set to non-zero when the info struct contains valid > data. > + * @speed:interface speed. > + */ > +struct sk

Re: [Linuxptp-devel] [PATCH 3/4] [Interface Rate TLV] organization TLV support for interface rate

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:21PM +0530, SyncMonk Technologies wrote: > @@ -241,6 +241,7 @@ struct config_item config_tab[] = { > GLOB_ITEM_ENU("clock_type", CLOCK_TYPE_ORDINARY, clock_type_enu), > GLOB_ITEM_ENU("dataset_comparison", DS_CMP_IEEE1588, dataset_comp_enu), > PORT_IT

Re: [Linuxptp-devel] [PATCH 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:22PM +0530, SyncMonk Technologies wrote: > diff --git a/interface.c b/interface.c > index 9bcb343..ec8964c 100644 > --- a/interface.c > +++ b/interface.c > @@ -93,3 +93,12 @@ int interface_get_vclock(struct interface *iface) > { > return iface->vclock; > } > +

Re: [Linuxptp-devel] [PATCH 4/4] [Interface Rate TLV] adding delay asymmetry calculation

2022-10-08 Thread Richard Cochran
On Wed, Jul 27, 2022 at 01:25:22PM +0530, SyncMonk Technologies wrote: > @@ -705,6 +705,12 @@ the interval, the sample will be printed instead of the > statistics. The > messages are printed at the LOG_INFO level. > The default is 0 (1 second). > .TP > +.B interface_rate_tlv > +When master and

Re: [Linuxptp-devel] [PATCH 1/3] Packet Timing Signal Fail (PTSF)(G.8275.2 Section 6.7.11)

2022-10-08 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:31:44PM +0200, Erez wrote: > On Wed, 24 Aug 2022 at 12:37, SyncMonk Technologies > wrote: > > > - adding sync receipt timeout, delay response timeout and signal fail > > support to portDS as per G.8275.2. > > - This also sets the signal fail condition for timeout. > >

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-10-08 Thread Richard Cochran
I read Annex B and Appendix III of T-REC-G.8275-202010, and I claim that linuxptp already implements this functionality, even though there is no "virtual port" explicitly modeled. I also read about APTS in T-REC-G.8275.2-202003. This is what I learned... On Mon, Jul 25, 2022 at 02:02:11AM +,