Re: [Linuxptp-devel] [PATCH] Add source only option to phc2sys autoconfiguration

2022-10-14 Thread Jakub Raczyński
After some thought, my patch was huge overkill. The correct solution (with same result) should be as in following patch. I don't see a point in forcing CLOCK_REALTIME being master and completely ignoring current portState. This patch is supposed to fix that. --- a/phc2sys.c 2022-10-14 0

Re: [Linuxptp-devel] [PATCH] Add source only option to phc2sys autoconfiguration

2022-10-14 Thread Jakub Raczyński
> 14.10.2022 09:29 Jakub Raczyński > napisał(a): > > > > > After some thought, my patch was huge overkill. The correct solution (with > same result) should be as in following patch. > > I don't see a point in forcing CLOCK_REALTIME being master and completely > ignoring current portSt

Re: [Linuxptp-devel] [PATCH] Inclusion of a virtual PTP port on a PTP clock

2022-10-14 Thread Richard Cochran
On Sat, Oct 08, 2022 at 04:05:17PM -0700, Richard Cochran wrote: > > So I really don't see any reason for merging the Virtual Port patch > series. It merely adds a second way to accomplish existing > functionality, but having two ways of doing the same thing violated > best software design practi

Re: [Linuxptp-devel] [PATCH] ptp4l: Add profile_id configuration support for G.8275.1 and G.8275.2.

2022-10-14 Thread Richard Cochran
On Tue, Aug 16, 2022 at 01:08:35PM -0400, izunna.otiji...@renesas.com wrote: > From: Izunna Otiji > > Signed-off-by: Izunna Otiji > --- > port.c | 13 - > transport.c | 5 + > transport.h | 5 + > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/port

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > diff --git a/config.c b/config.c > index b5cf397..ce8a3ae 100644 > --- a/config.c > +++ b/config.c > @@ -226,6 +226,7 @@ static struct config_enum bmca_enu[] = { > }; > > struct config_item config_tab[] = { > + PORT_I

Re: [Linuxptp-devel] [PATCH 1/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:11PM +0530, SyncMonk Technologies wrote: > Slave Event Monitoring channel for the alternate connections AFACIT this patch has nothing to do with alternate master as described in IEEE 1588. No thanks, Richard ___ Linuxptp

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > @@ -1595,6 +1611,10 @@ int port_tx_announce(struct port *p, struct address > *dst, uint16_t sequence_id) > > msg->header.flagField[1] = tp.flags; > > + if (p->state != PS_MASTER && clock_telecom_profile(p->cloc

Re: [Linuxptp-devel] [PATCH 2/2] Alternate master support

2022-10-14 Thread Richard Cochran
On Wed, Aug 24, 2022 at 03:57:12PM +0530, SyncMonk Technologies wrote: > adding alternate master support for linuxptp > > A PTP Master Clock, which is not the Best Master, > may act as a master with the Alternate Master flag > set on the messages it sends. > Need to support Alternate Master, inclu