Re: [Linuxptp-devel] [PATCH 0/1] Unselected master port may unintentionally continue to request announce/sync/delay_resp packets

2022-12-08 Thread Richard Cochran
On Fri, Dec 02, 2022 at 03:33:41PM -0500, vincent.cheng...@renesas.com wrote: > Problem > === > Unselected master port may unintentionally continue to request > announce/sync/delay_resp packets. > Expecting port with unselected master to only maintain announce messages. This detailed and cl

Re: [Linuxptp-devel] [PATCH 1/1] clock: Fix stale clock parent pid usage after best master change

2022-12-08 Thread Richard Cochran
On Fri, Dec 02, 2022 at 03:33:42PM -0500, vincent.cheng...@renesas.com wrote: > @@ -2015,6 +2027,8 @@ static void handle_state_decision_event(struct clock *c) > c->best = best; > c->best_id = best_id; > > + clock_update_parent_identity(c); Calling this unconditionally, regardles

Re: [Linuxptp-devel] [PATCH 2/2] phc_ctl: use PTP_CLOCK_GETCAPS2 ioctl if available

2022-12-08 Thread Geva, Erez
On Wed, 2022-12-07 at 06:59 -0800, Richard Cochran wrote: > On Thu, Nov 17, 2022 at 02:15:23PM -0800, Jacob Keller wrote: > > On 11/17/2022 1:34 PM, Geva, Erez wrote: > > > > The problem is the fallback works only on build. > > > But if the build system is newer than the running system, the > > >

Re: [Linuxptp-devel] [PATCH 1/1] clock: Fix stale clock parent pid usage after best master change

2022-12-08 Thread Geva, Erez
On Mon, 2022-12-05 at 12:52 -0500, vincent.cheng...@renesas.com wrote: > On Mon, Dec 05, 2022 at 02:44:07AM EST, Geva, Erez wrote: > > On Fri, 2022-12-02 at 15:33 -0500, > > vincent.cheng...@renesas.com wrote: > > > From: Vincent Cheng > > > > > > In handle_state_decision_event(), the update of t

Re: [Linuxptp-devel] [PATCH 1/1] clock: Fix stale clock parent pid usage after best master change

2022-12-08 Thread vincent.cheng...@renesas.com
On Thu, Dec 08, 2022 at 04:06:08PM EST, Geva, Erez wrote: >On Mon, 2022-12-05 at 12:52 -0500, vincent.cheng...@renesas.com wrote: >> On Mon, Dec 05, 2022 at 02:44:07AM EST, Geva, Erez wrote: >> > On Fri, 2022-12-02 at 15:33 -0500, >> > vincent.cheng...@renesas.com wrote: >> > > From: Vincent Cheng

[Linuxptp-devel] [PATCH v2 1/1] clock: Fix stale clock parent pid usage after best master change

2022-12-08 Thread vincent.cheng.xh
From: Vincent Cheng Signed-off-by: Vincent Cheng --- clock.c| 6 ++ port.c | 12 ++-- port.h | 7 +++ port_private.h | 1 + 4 files changed, 24 insertions(+), 2 deletions(-) diff --git a/clock.c b/clock.c index 134c7c3..a68a732 100644 --- a/clock.c ++

[Linuxptp-devel] [PATCH v2 0/1] Unselected master port may unintentionally continue to request announce/sync/delay_resp packets

2022-12-08 Thread vincent.cheng.xh
From: Vincent Cheng Problem === Unselected master port may unintentionally continue to request announce/sync/delay_resp packets. Expecting port with unselected master to only maintain announce messages. Setup = Client running with unicast mode and 2 ports, each port has single entry

Re: [Linuxptp-devel] [PATCH 1/1] clock: Fix stale clock parent pid usage after best master change

2022-12-08 Thread Vincent Cheng
On Thu, Dec 08, 2022 at 10:36:57AM EST, Richard Cochran wrote: >On Fri, Dec 02, 2022 at 03:33:42PM -0500, vincent.cheng...@renesas.com wrote: > >> @@ -2015,6 +2027,8 @@ static void handle_state_decision_event(struct clock >> *c) >> c->best = best; >> c->best_id = best_id; >> >> +cl