Re: [Linuxptp-devel] [PATCH v2] Add support for DELAY_REQ and SYNC packets RX filters

2023-11-26 Thread IlorDash
Could you, please, explain why you think my hardware is broken? I thought, since SYNC and DELAY_REQ filters are defined in Linux, ptp4l can use them to set type-specific hardware filters. On Sat, 25 Nov 2023 at 22:22, Richard Cochran wrote: > On Fri, Nov 24, 2023 at 10:29:12PM +0300, IlorDash

Re: [Linuxptp-devel] [PATCH v2] Add support for DELAY_REQ and SYNC packets RX filters

2023-11-26 Thread Richard Cochran
On Sun, Nov 26, 2023 at 01:38:15PM +0300, IlorDash wrote: > Could you, please, explain why you think my hardware is broken? I thought, > since SYNC and DELAY_REQ filters are defined in Linux, ptp4l can use them > to set type-specific hardware filters. Here is another reason why: The Rx filters

Re: [Linuxptp-devel] [PATCH] Add scaledLastGmFreqChange computation

2023-11-26 Thread Richard Cochran
On Thu, Nov 23, 2023 at 01:39:45PM +0100, Erez wrote: > On Thu, 23 Nov 2023 at 04:26, Chwee-Lin Choong > wrote: > > > Add the computation for scaledLastGmFreqChange, as specified in > > IEEE 802.1AS-2020, clause 11.4.4.3.9. This incorporates the > > necessary logic to calculate

Re: [Linuxptp-devel] [PATCH v4 2/2] ptp4l: Allow advertisement of legacy PTP 2.0 protocol

2023-11-26 Thread Richard Cochran
On Fri, Nov 10, 2023 at 06:46:57PM +0100, Maciek Machnikowski wrote: > Some hardware can't properly timestamp packets with the new PTP > header version 2.1. This patch adds legacy_ptp_ver config option that > allows advertising of the legacy 2.0 protocol. > > Additionally, forcing PTP minor

Re: [Linuxptp-devel] [PATCH v4 1/2] msg: Enable changing PTP message header version

2023-11-26 Thread Richard Cochran
On Fri, Nov 10, 2023 at 06:46:56PM +0100, Maciek Machnikowski wrote: > Some hardware can't properly timestamp packets with the new PTP > header version 2.1. This patch introduces a global var ptp_hdr_ver > that can be changed externally to allow legacy PTP version to be > advertised. > > Forcing

Re: [Linuxptp-devel] [PATCH 0/2] Enhanced Handling of Multiple Pdelay Responses

2023-11-26 Thread Richard Cochran
On Wed, Nov 08, 2023 at 03:14:04AM +0800, Chwee-Lin Choong wrote: > The patches aim to enhance the handling of multiple pdelay responses. > These improvements are aligned with both IEEE 802.1AS-2011 and > IEEE 802.1AS-2020 standards. > > The first patch introduces configurability for

Re: [Linuxptp-devel] [PATCH v2] Add support for DELAY_REQ and SYNC packets RX filters

2023-11-26 Thread Richard Cochran
On Sun, Nov 26, 2023 at 01:38:15PM +0300, IlorDash wrote: > Could you, please, explain why you think my hardware is broken? I thought, > since SYNC and DELAY_REQ filters are defined in Linux, ptp4l can use them > to set type-specific hardware filters. The port role can and will suddenly change at

Re: [Linuxptp-devel] [RFC PATCH 0/1] Support for Port level Perforamnce Monitoring Counters

2023-11-26 Thread Richard Cochran
On Mon, Nov 13, 2023 at 02:38:19PM +0100, Erez wrote: > I think Richard means using the SUBSCRIBE_EVENTS_NP. Yes. > Adding new events, and make sure the ptp4l sends all the statistics you > need together. Yes, but please don't "overload" the existing counters. Just add new fields with names

Re: [Linuxptp-devel] [PATCH v2 1/2] include string.h for strncpy()

2023-11-26 Thread Richard Cochran
On Mon, Oct 23, 2023 at 10:43:42AM +0100, Luca Fancellu wrote: > From: Khem Raj > > Signed-off-by: Khem Raj > --- > Changes from v1: > - no changes > --- > interface.c | 1 + > 1 file changed, 1 insertion(+) Applied. Thanks, Richard ___

Re: [Linuxptp-devel] [PATCH v2 2/2] linuxptp: Use ${CC} in incdefs.sh

2023-11-26 Thread Richard Cochran
On Mon, Oct 23, 2023 at 10:43:43AM +0100, Luca Fancellu wrote: > The Makefile is defining CC and incdefs.sh is using > ${CROSS_COMPILE}cpp inside it, allowing both to use different > compilers depending on what the user pass during make invocation > as CC. > > Align them using ${CC} also inside

Re: [Linuxptp-devel] [PATCH v2] Add support for DELAY_REQ and SYNC packets RX filters

2023-11-26 Thread IlorDash
Thanks, Richard, for such a detailed answer! I'll try to find another solution to handle it. On Sun, 26 Nov 2023 at 22:10, Richard Cochran wrote: > On Sun, Nov 26, 2023 at 01:38:15PM +0300, IlorDash wrote: > > Could you, please, explain why you think my hardware is broken? I > thought, > >