On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote:
> > + p->cmlds_pmc = pmc_create(cfg, TRANS_UDS,
> > + config_get_string(cfg, p->name,
> > "cmlds_client_address"),
> > + config_get_string(cfg, p->name,
> >
This is how CMLD should be done, IMHO.
Currently, because of the quirks of the UDS module, a program can be a
PMC server or PMC client, but not both. Patches 1 and 2 address this
issue, allowing ptp4l program to be both a UDS server and client.
Still TODO:
- replace hard coded 1-hour one shot
From: Kishen Maloor
Signed-off-by: Richard Cochran
---
config.c | 4 ++
dm.h | 3 +
fd.h | 1 +
makefile | 4 +-
port.c | 166 +++--
port_private.h | 3 +
6 files changed, 174 insertions(+), 7
Add a new TLV to convey link delay measurements by the Common Mean
Link Delay Service (CMLDS) (as specified in IEEE 1588/16.6.3) over the
management interface.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
Signed-off-by: Richard Cochran
---
clock.c | 1 -
pmc.c|
Signed-off-by: Richard Cochran
---
clock.c | 4 ++--
config.c | 2 +-
interface.c | 12 ++--
interface.h | 10 +-
pmc_common.c | 2 +-
5 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/clock.c b/clock.c
index b66dda5..6f7722c 100644
--- a/clock.c
+++
Signed-off-by: Richard Cochran
---
pmc.c| 6 --
pmc_agent.c | 3 ++-
pmc_common.c | 8
pmc_common.h | 6 +++---
tz2alt.c | 3 ++-
uds.c| 6 --
6 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/pmc.c b/pmc.c
index 9faf790..d18fea0 100644
---
On Wed, Nov 29, 2023 at 11:57:16PM -0800, Richard Cochran wrote:
> This is how CMLD should be done, IMHO.
Sample configs...
CMLDS_server.cfg
[global]
clientOnly 1
free_running1
uds_address /var/run/cmlds_server
use_syslog 0
verbose 1
Signed-off-by: Richard Cochran
---
notification.h | 1 +
pmc.c | 6 --
pmc_common.c | 14 ++
port.c | 5 +
4 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/notification.h b/notification.h
index c1a6395..7a8f641 100644
--- a/notification.h
On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote:
> > @@ -249,6 +250,9 @@ struct config_item config_tab[] = {
> > GLOB_ITEM_INT("clock_class_threshold",
> > CLOCK_CLASS_THRESHOLD_DEFAULT, 6, CLOCK_CLASS_THRESHOLD_DEFAULT),
> > GLOB_ITEM_ENU("clock_servo",
Hi Richard,
I haven't tested this but here are some comments.
On Thu, 30 Nov 2023 at 08:58, Richard Cochran wrote:
> From: Kishen Maloor
>
> Signed-off-by: Richard Cochran
> ---
> config.c | 4 ++
> dm.h | 3 +
> fd.h | 1 +
> makefile | 4 +-
> port.c
On Thu, 30 Nov 2023 at 17:44, Richard Cochran wrote:
> On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote:
> > > + PORT_ITEM_STR("cmlds_client_address", "/var/run/cmlds_cleint"),
> >
> > I assume the use of this is simply to set unique names for per-port
> > sockets. Maybe
On Thu, Nov 30, 2023 at 07:12:54PM +0100, Andrew Zaborowski wrote:
> On Thu, 30 Nov 2023 at 17:44, Richard Cochran
> wrote:
> > On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote:
> > > > + PORT_ITEM_STR("cmlds_client_address", "/var/run/cmlds_cleint"),
> > >
> > > I assume
Hi Richard,
Firstly, thanks so much for your reviews and efforts to get
this done.
I'll just rehash a couple of points also raised by Andrew.
On this change below:
> +static int port_cmlds_initialize(struct port *p)
> +{
> + struct config *cfg = clock_config(p->clock);
> + struct
13 matches
Mail list logo
