Re: [Linuxptp-devel] [PATCH v3 5/6] Implement the COMMON_P2P delay mechanism.

2023-12-04 Thread Miroslav Lichvar
On Sat, Dec 02, 2023 at 03:38:18PM -0800, Richard Cochran wrote: > --- a/config.c > +++ b/config.c > @@ -171,6 +171,7 @@ static struct config_enum delay_filter_enu[] = { > > static struct config_enum delay_mech_enu[] = { > { "Auto", DM_AUTO }, > + { "COMMON_P2P", DM_COMMON_P2P }, The

Re: [Linuxptp-devel] [PATCH v3 5/6] Implement the COMMON_P2P delay mechanism.

2023-12-04 Thread Miroslav Lichvar
On Mon, Dec 04, 2023 at 04:06:31PM +0100, Miroslav Lichvar wrote: > On Sat, Dec 02, 2023 at 03:38:18PM -0800, Richard Cochran wrote: > > --- a/config.c > > +++ b/config.c > > @@ -171,6 +171,7 @@ static struct config_enum delay_filter_enu[] = { > > > > static struct config_enum delay_mech_enu[] =

Re: [Linuxptp-devel] [PATCH v7 1/2] pmc_agent: Add option to run callback for signaling messages

2023-12-04 Thread Richard Cochran
On Mon, Dec 04, 2023 at 08:39:47AM +0100, Maciek Machnikowski wrote: > Hey, please take a look at these patches and merge them if there are no > bugs in this code. I don't understand the need for this series. What problem does it solve? Thanks, Richard __

Re: [Linuxptp-devel] [PATCH v7 1/2] pmc_agent: Add option to run callback for signaling messages

2023-12-04 Thread Maciek Machnikowski
On 04/12/2023 17:46, Richard Cochran wrote: > On Mon, Dec 04, 2023 at 08:39:47AM +0100, Maciek Machnikowski wrote: >> Hey, please take a look at these patches and merge them if there are no >> bugs in this code. > > I don't understand the need for this series. > What problem does it solve? > >

Re: [Linuxptp-devel] [PATCH v3 6/6] Add example Common Mean Link Delay Service configuration files.

2023-12-04 Thread Andrew Zaborowski
On Sun, 3 Dec 2023 at 00:39, Richard Cochran wrote: > +# Common Mean Link Delay Service (CMLDS) example configuration for a > +# CMLDS Link Port, containing those attributes which differ from the While there's only one Link Port here I wouldn't mention this because the CMLDS config basically has

Re: [Linuxptp-devel] [PATCH v3 4/6] Add a push notification for the CMLDS TLV.

2023-12-04 Thread Andrew Zaborowski
On Sun, 3 Dec 2023 at 00:39, Richard Cochran wrote: > @@ -306,13 +307,15 @@ static void do_set_action(struct pmc *pmc, int action, > int index, char *str) > "duration %hu " > "NOTIFY_PORT_STATE %3s " >

Re: [Linuxptp-devel] [PATCH v3 6/6] Add example Common Mean Link Delay Service configuration files.

2023-12-04 Thread Andrew Zaborowski
I tested a basic 802.1AS type scenario with this v3 patchset on both ends, and it worked! We may have more test results in a few days if my colleague runs a real test suite. The only caveats were: * if I stop a CMLDS client and rerun it, it will receive the CMLDS notifications twice until the ol

Re: [Linuxptp-devel] [PATCH v1 4/4] phc_ctl: Use util.h NSEC_PER_SEC macro instead of local macro

2023-12-04 Thread Rahul Rameshbabu via Linuxptp-devel
On Sat, 02 Dec, 2023 13:56:50 -0800 Richard Cochran wrote: > On Wed, Nov 22, 2023 at 09:36:36AM -0800, Rahul Rameshbabu via Linuxptp-devel > wrote: >> Use the common NSEC_PER_SEC macro in phc_ctl. >> >> Signed-off-by: Rahul Rameshbabu > > Series applied, but I fixed up one more NSEC2SEC that w