Re: [Linuxptp-devel] clock_adjtime not work in arm linux 3.0

2014-05-05 Thread Richard Cochran
On Tue, May 06, 2014 at 10:56:22AM +0800, Arnold kang wrote: > Dear Richard, > i'm sorry ask for your help , clock_adjtime may not work in arm linux > v3.0, this syscall return success, but can not change time nor get time, > anything wrong, or need add a patch ? I think you told us before th

[Linuxptp-devel] clock_adjtime not work in arm linux 3.0

2014-05-05 Thread Arnold kang
Dear Richard, i'm sorry ask for your help , clock_adjtime may not work in arm linux v3.0, this syscall return success, but can not change time nor get time, anything wrong, or need add a patch ? -- Is your legacy SCM s

Re: [Linuxptp-devel] [PATCH v3 05/11] Event subscribing

2014-05-05 Thread Richard Cochran
On Mon, May 05, 2014 at 02:39:58PM +0200, Jiri Benc wrote: > > I'll wrap them but the result will look uglier than this. You version looks like this: msg->management.targetPortIdentity.clockIdentity = s->targetPortIdentity.clockIdentity; msg->management.targetPor

Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-05 Thread Richard Cochran
On Mon, May 05, 2014 at 02:54:04PM +0200, Jiri Benc wrote: > > I even thought about limiting the maximum value to a hour or so. The > client is supposed to renew the subscription, otherwise the time limit > would be useless. Fair enough. Thanks, Richard -

Re: [Linuxptp-devel] [PATCH v3 08/11] port: event notification

2014-05-05 Thread Jiri Benc
On Sat, 3 May 2014 20:49:16 +0200, Richard Cochran wrote: > On Fri, May 02, 2014 at 12:37:51PM +0200, Jiri Benc wrote: > > Split management message creation to more fine-grained functions to allow > > notification messages to be created. > > I must admit I didn't understand what you did, at first

Re: [Linuxptp-devel] [PATCH v3 07/11] Subscription time limit

2014-05-05 Thread Jiri Benc
On Sat, 3 May 2014 20:32:01 +0200, Richard Cochran wrote: > 1. It is a good idea to let the client set the duration? You wanted to get rid of the magic constant in ptp4l, this allowed me to move it to phc2sys ;-) Okay, seriously: I don't think this is a problem. It is limited to UDS and the worst

Re: [Linuxptp-devel] [PATCH v3 05/11] Event subscribing

2014-05-05 Thread Jiri Benc
On Sat, 3 May 2014 20:19:10 +0200, Richard Cochran wrote: > On Fri, May 02, 2014 at 12:37:48PM +0200, Jiri Benc wrote: > > +static void clock_flush_subscriptions(struct clock *c) > > +{ > > + struct clock_subscriber *s, *tmp; > > + > > + LIST_FOREACH_SAFE(s, &c->subscribers, list, tmp) { > > +