Re: [Linuxptp-devel] [PATCH 1/1] Added support for non-forwardable option

2018-11-09 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Friday, November 09, 2018 6:54 AM > To: Anders Selhammer > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 1/1] Added support for non-forwardable > option > > On Fri,

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Keller, Jacob E
> -Original Message- > From: Geva, Erez [mailto:erez.geva@siemens.com] > Sent: Friday, November 09, 2018 5:50 AM > To: Anders Selhammer > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as > config parameter > >

Re: [Linuxptp-devel] [PATCH 1/1] Added support for non-forwardable option

2018-11-09 Thread Richard Cochran
On Fri, Nov 09, 2018 at 07:41:46AM +, Anders Selhammer wrote: > Some network operators consider that the PTP messages must never be > forwarded through PTP-unaware network equipment. The use of the > non-forwardable multicast address 01-80-C2-00-00-0E guarantees this > property most of the

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Geva, Erez
Do you means that you wish the ptp4l to use more then one network namespace? Or is it a more convenient to start in the default network namespace? Just ask you to clarify why do we need this patch. I'm not an export on network namespace myself. Yours Erez

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Anders Selhammer
Friday, 9 November, 2018 11:36 AM > What about "ip netns exec"? Im not an expert on this so maybe I got it wrong but do you mean that you should start the ptp4l program directly in the correct namespace? If that is what you mean, you will bump into the problem which can be solved by this

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Geva, Erez
What about "ip netns exec"? From: Anders Selhammer [anders.selham...@est.tech] Sent: 09 November 2018 10:25 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter Signed-off-by:

Re: [Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Erez
What about using "ip netns exec"? Erez On Fri, 9 Nov 2018 at 11:01, Anders Selhammer wrote: > Signed-off-by: Anders Selhammer > --- > config.c | 1 + > ptp4l.8 | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/config.c b/config.c > index b8e7977..fef31b3 100644 > ---

[Linuxptp-devel] [PATCH 1/1] tmv: Avoid overflow when byte shift in tmv_to_TimeInterval

2018-11-09 Thread Anders Selhammer
Signed-off-by: Anders Selhammer --- tmv.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tmv.h b/tmv.h index b8339e6..fbe228d 100644 --- a/tmv.h +++ b/tmv.h @@ -26,6 +26,8 @@ #include "pdt.h" #define NS_PER_SEC 10LL +#define MIN_TMV_TO_TIMEINTERVAL 0x8000ll

[Linuxptp-devel] [PATCH 5/6] sk: Added functionality for reassociate namespace

2018-11-09 Thread Anders Selhammer
Signed-off-by: Anders Selhammer --- sk.c | 49 + sk.h | 18 ++ 2 files changed, 67 insertions(+) diff --git a/sk.c b/sk.c index 69492d4..059980a 100644 --- a/sk.c +++ b/sk.c @@ -25,6 +25,8 @@ #include #include #include

[Linuxptp-devel] [PATCH 2/6] config: Added network_namespace as config parameter

2018-11-09 Thread Anders Selhammer
Signed-off-by: Anders Selhammer --- config.c | 1 + ptp4l.8 | 6 ++ 2 files changed, 7 insertions(+) diff --git a/config.c b/config.c index b8e7977..fef31b3 100644 --- a/config.c +++ b/config.c @@ -260,6 +260,7 @@ struct config_item config_tab[] = {

[Linuxptp-devel] [PATCH 3/6] sk: Removed unused initialization of sk_tx_timeout

2018-11-09 Thread Anders Selhammer
Signed-off-by: Anders Selhammer --- sk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sk.c b/sk.c index e2b1f28..0fe009a 100644 --- a/sk.c +++ b/sk.c @@ -38,8 +38,8 @@ /* globals */ -int sk_tx_timeout = 1; -int sk_check_fupsync; +int sk_tx_timeout; /*

[Linuxptp-devel] [PATCH 4/6] sk: Fix in sk_interface_guidaddr

2018-11-09 Thread Anders Selhammer
Signed-off-by: Anders Selhammer --- sk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sk.c b/sk.c index 0fe009a..69492d4 100644 --- a/sk.c +++ b/sk.c @@ -203,10 +203,10 @@ static int sk_interface_guidaddr(const char *name, unsigned char *guid) char *err;

[Linuxptp-devel] [PATCH 6/6] Added handling for reassociation of namespace

2018-11-09 Thread Anders Selhammer
Signed-off-by: Anders Selhammer --- clock.c | 3 +++ ptp4l.c | 9 - transport.c | 7 +++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/clock.c b/clock.c index 56bc79b..c494200 100644 --- a/clock.c +++ b/clock.c @@ -959,6 +959,9 @@ struct clock