Re: [Linuxptp-devel] [PATCH] udp6: Make mc6_addr transport-local

2019-09-10 Thread Richard Cochran
On Tue, Sep 10, 2019 at 12:51:35PM +, Petr Machata wrote: > mc6_addr holds the parsed multicast address to which messages should be sent. > But since each port can have a different scope, and the primary MC address > depends on the scope, it really can't be stored in a global variable. Move >

Re: [Linuxptp-devel] [PATCH v2 0/2] Introduce per-port stats for received and transmitted messages

2019-09-10 Thread Richard Cochran
On Tue, Sep 10, 2019 at 12:23:33PM +, Petr Machata wrote: > Black-box switches with PTP support commonly provide per-port statistics of > number of messages sent and received, split by the message type. Like other > statistics (ip link, ethtool, etc. etc.), network operators use the PTP >

Re: [Linuxptp-devel] [PATCH v2 0/2] Introduce per-port stats for received and transmitted messages

2019-09-10 Thread Richard Cochran
On Tue, Sep 10, 2019 at 05:59:04PM +, Keller, Jacob E wrote: > One thing (unrelated to this patch) I would love to see in the > future is a bit more of an indepth "tutorial" style manpage or > readme that explains how to use pmc, as opposed to trying to parse > the output of the ptp4l log

Re: [Linuxptp-devel] [PATCH v2 0/2] Introduce per-port stats for received and transmitted messages

2019-09-10 Thread Keller, Jacob E
> -Original Message- > From: Petr Machata [mailto:pe...@mellanox.com] > Sent: Tuesday, September 10, 2019 5:24 AM > To: linuxptp-devel@lists.sourceforge.net > Cc: Petr Machata ; Keller, Jacob E > > Subject: [PATCH v2 0/2] Introduce per-port stats for received and transmitted > messages >

Re: [Linuxptp-devel] [PATCH v2 1/2] port: Introduce per-port stats for received and transmitted messages

2019-09-10 Thread Keller, Jacob E
> -Original Message- > From: Petr Machata [mailto:pe...@mellanox.com] > Sent: Tuesday, September 10, 2019 5:24 AM > To: linuxptp-devel@lists.sourceforge.net > Cc: Petr Machata ; Keller, Jacob E > > Subject: [PATCH v2 1/2] port: Introduce per-port stats for received and > transmitted >

[Linuxptp-devel] [PATCH v2 1/2] port: Introduce per-port stats for received and transmitted messages

2019-09-10 Thread Petr Machata
Add struct PortStats to keep per-port number of messages sent and received, split by message type. Bump TX counters after messages are sent successfully, and RX counters after a message is received. To keep things simple, reserve one counter for each theoretically possible message type, including

[Linuxptp-devel] [PATCH] udp6: Make mc6_addr transport-local

2019-09-10 Thread Petr Machata
mc6_addr holds the parsed multicast address to which messages should be sent. But since each port can have a different scope, and the primary MC address depends on the scope, it really can't be stored in a global variable. Move both to struct udp6. Additionally, document the fact that the primary

[Linuxptp-devel] [PATCH v2 0/2] Introduce per-port stats for received and transmitted messages

2019-09-10 Thread Petr Machata
Black-box switches with PTP support commonly provide per-port statistics of number of messages sent and received, split by the message type. Like other statistics (ip link, ethtool, etc. etc.), network operators use the PTP message stats to monitor the (PTP) network and debug issues. When ptp4l

[Linuxptp-devel] [PATCH v2 2/2] pmc: Add a new TLV to obtain per-port statistics

2019-09-10 Thread Petr Machata
Add an ability of pmc to query per-port stats added in the previous patch. Signed-off-by: Petr Machata --- pmc.c| 47 +++ pmc_common.c | 1 + port.c | 7 +++ tlv.c| 15 +++ tlv.h| 6 ++ 5 files