Re: [Linuxptp-devel] [PATCH 2/2] Add setting of PTP_TIMESCALE flag

2021-06-14 Thread Greg Armstrong
The latest 802.1AS has clarified ptpTimescale flag is only used for Announce. For all other messages, it should be FALSE (and still ignored on reception). Thus, the patch should not be the default. I agree with Jacob that a use of a flag may be better to allow interop with other gPTP implementat

Re: [Linuxptp-devel] [PATCH 2/2] Add setting of PTP_TIMESCALE flag

2021-06-14 Thread Jacob Keller
On 6/14/2021 5:03 AM, Miklas, Marcin via Linuxptp-devel wrote: > From: Marcin Miklas > > In gPTP PTP_TIMESCALE flag should be set to 1. It looks like the flags > where not properly set for any of messages used in gPTP. > > Some of the automotive gPTP bridges where rejecting the PDelayReq mess

[Linuxptp-devel] [PATCH 2/2] Add setting of PTP_TIMESCALE flag

2021-06-14 Thread Miklas, Marcin via Linuxptp-devel
From: Marcin Miklas In gPTP PTP_TIMESCALE flag should be set to 1. It looks like the flags where not properly set for any of messages used in gPTP. Some of the automotive gPTP bridges where rejecting the PDelayReq messages because of missing flag. I would say that both linuxptp and the bridge d

[Linuxptp-devel] [PATCH 1/2] Do not use SIGNAL_SET_INITIAL in Signaling messages

2021-06-14 Thread Miklas, Marcin via Linuxptp-devel
From: Marcin Miklas Use client's configured initialLogSyncInterval instead. Signed-off-by: Marcin Miklas --- port.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/port.c b/port.c index b5b775f..8175f28 100644 --- a/port.c +++ b/port.c @@ -1208,7 +1208,7 @@ static void port

[Linuxptp-devel] [PATCH 0/2] gPTP profile interoperability problems

2021-06-14 Thread Miklas, Marcin via Linuxptp-devel
From: Marcin Miklas Hi, I've noticed couple of problems when using linuxptp with other gPTP implementations. gPTP requires that PTP_TIMESCALE flag is set in messages. I noticed that PDelayReq, PDelayResp, PDelayRespFollowUp, Sync, FollowUp and Signaling all have that flag set to 0. One of the b