Re: [Linuxptp-devel] [PATCH v2 0/6] Common Mean Link Delay Service (CMLDS)

2023-12-02 Thread Richard Cochran
On Sat, Dec 02, 2023 at 02:28:54PM -0800, Richard Cochran wrote: > On Sat, Dec 02, 2023 at 02:24:52PM -0800, Richard Cochran wrote: > > > Changes in v2 > > ~ > > - Added timer to renew push subscription and detect missing server. > > - Addressed Andrew and Kishen's review comments. >

[Linuxptp-devel] [PATCH v3 2/6] pmc/uds: Configure the remote server address using the interface API.

2023-12-02 Thread Richard Cochran
The UDS uses a global setting from the configuration to set the remote server address. As a result, a program cannot act as both a UDS client and server, because the source and destination addresses would be identical. Fix the issue by allowing the remote address to be configurable.

[Linuxptp-devel] [PATCH v3 6/6] Add example Common Mean Link Delay Service configuration files.

2023-12-02 Thread Richard Cochran
Signed-off-by: Richard Cochran --- configs/CMLDS_client.cfg | 10 ++ configs/CMLDS_server.cfg | 16 2 files changed, 26 insertions(+) create mode 100644 configs/CMLDS_client.cfg create mode 100644 configs/CMLDS_server.cfg diff --git a/configs/CMLDS_client.cfg

[Linuxptp-devel] [PATCH v3 3/6] Introduce the Common Mean Link Delay Information TLV.

2023-12-02 Thread Richard Cochran
Add a new TLV to convey link delay measurements by the Common Mean Link Delay Service (CMLDS) (as specified in IEEE 1588/16.6.3) over the management interface. Co-authored-by: Andrew Zaborowski Signed-off-by: Kishen Maloor Signed-off-by: Richard Cochran --- clock.c | 1 - pmc.c|

[Linuxptp-devel] [PATCH v3 5/6] Implement the COMMON_P2P delay mechanism.

2023-12-02 Thread Richard Cochran
If a given port selects the COMMON_P2P delay mechanism, let it open a local PTP Management channel to the Common Mean Link Delay Service over a UNIX domain socket. Signed-off-by: Richard Cochran --- config.c| 6 ++ configs/default.cfg | 5 ++ dm.h| 3 + fd.h

[Linuxptp-devel] [PATCH v3 1/6] interface: Add an optional remote address for use by the UDS transport.

2023-12-02 Thread Richard Cochran
Because of the implementation of the UDS module, it is not possible for a process to act as both a PTP management client (PMC) and server. Going forward, one ptp4l instance will need to subscribe to another using the PMC methods. Pave the way by allowing the interface to include an optional

[Linuxptp-devel] [PATCH v3 0/6] Common Mean Link Delay Service (CMLDS)

2023-12-02 Thread Richard Cochran
The CMLDS lets one peer-to-peer delay measurement be shared among multiple PTP stack instances running on the same host. To try it, connect the Ethernet ports of two hosts directly: On one host run CMLDS setup: ptp4l -mqf CMLDS_server.cfg ptp4l -mqf CMLDS_client.cfg and on the other host

[Linuxptp-devel] [PATCH v3 4/6] Add a push notification for the CMLDS TLV.

2023-12-02 Thread Richard Cochran
Signed-off-by: Richard Cochran --- notification.h | 1 + pmc.c | 6 -- pmc_common.c | 14 ++ port.c | 7 +++ 4 files changed, 22 insertions(+), 6 deletions(-) diff --git a/notification.h b/notification.h index c1a6395..7a8f641 100644 ---

Re: [Linuxptp-devel] [PATCH v2 0/6] Common Mean Link Delay Service (CMLDS)

2023-12-02 Thread Richard Cochran
On Sat, Dec 02, 2023 at 02:24:52PM -0800, Richard Cochran wrote: > Changes in v2 > ~ > - Added timer to renew push subscription and detect missing server. > - Addressed Andrew and Kishen's review comments. > - Added example configuration files. I also updated the man page with the

[Linuxptp-devel] [PATCH v2 5/6] Implement the COMMON_P2P delay mechanism.

2023-12-02 Thread Richard Cochran
If a given port selects the COMMON_P2P delay mechanism, let it open a local PTP Management channel to the Common Mean Link Delay Service over a UNIX domain socket. Signed-off-by: Richard Cochran --- config.c| 6 ++ configs/default.cfg | 5 ++ dm.h| 3 + fd.h

[Linuxptp-devel] [PATCH v2 2/6] pmc/uds: Configure the remote server address using the interface API.

2023-12-02 Thread Richard Cochran
The UDS uses a global setting from the configuration to set the remote server address. As a result, a program cannot act as both a UDS client and server, because the source and destination addresses would be identical. Fix the issue by allowing the remote address to be configurable.

[Linuxptp-devel] [PATCH v2 3/6] Introduce the Common Mean Link Delay Information TLV.

2023-12-02 Thread Richard Cochran
Add a new TLV to convey link delay measurements by the Common Mean Link Delay Service (CMLDS) (as specified in IEEE 1588/16.6.3) over the management interface. Co-authored-by: Andrew Zaborowski Signed-off-by: Kishen Maloor Signed-off-by: Richard Cochran --- clock.c | 1 - pmc.c|

[Linuxptp-devel] [PATCH v2 4/6] Add a push notification for the CMLDS TLV.

2023-12-02 Thread Richard Cochran
Signed-off-by: Richard Cochran --- notification.h | 1 + pmc.c | 6 -- pmc_common.c | 14 ++ port.c | 7 +++ 4 files changed, 22 insertions(+), 6 deletions(-) diff --git a/notification.h b/notification.h index c1a6395..7a8f641 100644 ---

[Linuxptp-devel] [PATCH v2 0/6] Common Mean Link Delay Service (CMLDS)

2023-12-02 Thread Richard Cochran
The CMLDS lets one peer-to-peer delay measurement be shared among multiple PTP stack instances running on the same host. To try it, connect the Ethernet ports of two hosts directly: On one host run CMLDS setup: ptp4l -mqf CMLDS_server.cfg ptp4l -mqf CMLDS_client.cfg and on the other host

[Linuxptp-devel] [PATCH v2 1/6] interface: Add an optional remote address for use by the UDS transport.

2023-12-02 Thread Richard Cochran
Because of the implementation of the UDS module, it is not possible for a process to act as both a PTP management client (PMC) and server. Going forward, one ptp4l instance will need to subscribe to another using the PMC methods. Pave the way by allowing the interface to include an optional

[Linuxptp-devel] [PATCH v2 6/6] Add example Common Mean Link Delay Service configuration files.

2023-12-02 Thread Richard Cochran
Signed-off-by: Richard Cochran --- configs/CMLDS_client.cfg | 10 ++ configs/CMLDS_server.cfg | 16 2 files changed, 26 insertions(+) create mode 100644 configs/CMLDS_client.cfg create mode 100644 configs/CMLDS_server.cfg diff --git a/configs/CMLDS_client.cfg

Re: [Linuxptp-devel] [PATCH v1 4/4] phc_ctl: Use util.h NSEC_PER_SEC macro instead of local macro

2023-12-02 Thread Richard Cochran
On Wed, Nov 22, 2023 at 09:36:36AM -0800, Rahul Rameshbabu via Linuxptp-devel wrote: > Use the common NSEC_PER_SEC macro in phc_ctl. > > Signed-off-by: Rahul Rameshbabu Series applied, but I fixed up one more NSEC2SEC that was added into phc_ctl.c since this series was posted. Thanks, Richard