as mismatch.
Signed-off-by: Petr Machata
---
sk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sk.c b/sk.c
index 93ba77a..416d784 100644
--- a/sk.c
+++ b/sk.c
@@ -105,7 +105,8 @@ static int hwts_init(int fd, const char *device, int
rx_filter,
if (cfg.tx_type
Petr Machata writes:
> @@ -105,7 +105,8 @@ static int hwts_init(int fd, const char *device, int
> rx_filter,
> if (cfg.tx_type != tx_type ||
> (cfg.rx_filter != rx_filter &&
>cfg.rx_filter != rx_filter2 &&
> - cf
as mismatch.
Signed-off-by: Petr Machata
---
Notes:
v2: Fix whitespace.
sk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sk.c b/sk.c
index 93ba77a..416d784 100644
--- a/sk.c
+++ b/sk.c
@@ -105,7 +105,8 @@ static int hwts_init(int fd, const char *device, int
Keller, Jacob E writes:
>> index 93ba77a..416d784 100644
>> --- a/sk.c
>> +++ b/sk.c
>> @@ -105,7 +105,8 @@ static int hwts_init(int fd, const char *device, int
>> rx_filter,
>> if (cfg.tx_type != tx_type ||
>> (cfg.rx_filter != rx_filter &&
>> cfg.rx_filter != rx_filte
as mismatch.
Cc: "Keller, Jacob E"
Signed-off-by: Petr Machata
---
Notes:
v3:
- Do not permit HWTSTAMP_FILTER_SOME for SIOCGHWTSTAMP.
v2:
- Fix whitespace.
sk.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/sk.c b/sk.c
index 93ba77
TAMP_FILTER_ALL is a higher state
>
> HWTS_FILTER_FULL
> set Rx filter HWTSTAMP_FILTER_ALL
> check if RX filter one of Rx filter 1, Rx filter 2, HWTSTAMP_FILTER_ALL
> Filter should be HWTSTAMP_FILTER_ALL,
> but if NIc driver only set filter to be one of Rx filter 1
fy the HWTS_FILTER_NORMAL then.
> Neither can you use rx_filter in this case, since it was not used in
> the SIOCSHWTSTAMP request.
>
> Erez
>
> ________
> From: Petr Machata [pe...@mellanox.com]
> Sent: 11 June 2019 15:18
> To: linuxptp-de
, instead of rejecting it as mismatch.
Cc: "Keller, Jacob E"
Cc: "Geva, Erez"
Signed-off-by: Petr Machata
---
Notes:
v4:
- Do not permit HWTSTAMP_FILTER_SOME for HWTS_FILTER_FULL either.
v3:
- Do not permit HWTSTAMP_FILTER_SOME for SIOCGHWTSTAMP.
Keller, Jacob E writes:
>> > From: Sanjay Bhandari [mailto:san...@ziffusion.com]
>> > Is there a way to set a port in the PASSIVE role with ptp4l?
>> >
>> > Essentially, we want to listen in on the protocol, but not generate ANY
>> > protocol
>> messages ourselves. Nor do we want to set the PHC
the reserved ones.
Signed-off-by: Petr Machata
---
ddt.h | 5 +
port.c | 25 +++--
port_private.h | 1 +
3 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/ddt.h b/ddt.h
index 4acaa4f..5486203 100644
--- a/ddt.h
+++ b/ddt.h
@@ -100,4 +100,9
Add an ability of pmc to query per-port stats added in the previous patch.
Signed-off-by: Petr Machata
---
pmc.c| 47 +++
pmc_common.c | 1 +
port.c | 7 +++
tlv.c| 15 +++
tlv.h| 6 ++
5 files
linuxptp. A natural
way to obtain these stats is then through pmc, which is implemented in
patch #2, by way of a new TLV type.
Petr Machata (2):
port: Introduce per-port stats for received and transmitted messages
pmc: Add a new TLV to obtain per-port statistics
ddt.h | 5
Keller, Jacob E writes:
>> diff --git a/ddt.h b/ddt.h
>> index 4acaa4f..5486203 100644
>> --- a/ddt.h
>> +++ b/ddt.h
>> @@ -100,4 +100,9 @@ struct FaultRecord {
>> struct PTPText faultDescription;
>> };
>>
>> +struct PortStats {
>> +uint64_t rxMsgType[16];
>> +uint64_t txMsgType
Add an ability of pmc to query per-port stats added in the previous patch.
Signed-off-by: Petr Machata
---
pmc.c| 47 +++
pmc_common.c | 1 +
port.c | 7 +++
tlv.c| 15 +++
tlv.h| 6 ++
5 files
logical
way to obtain these stats is then through pmc, which is implemented in
patch #2, by way of a new TLV type.
v2:
- Patch #1:
- Add MAX_MESSAGE_TYPES with comment instead of using a bare constant.
Petr Machata (2):
port: Introduce per-port stats for received and transmitted messages
pmc
imary multicast address is changed at
runtime.
Reported-by: Alex Veber
Signed-off-by: Petr Machata
---
udp6.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/udp6.c b/udp6.c
index 908f307..74ebc7f 100644
--- a/udp6.c
+++ b/udp6.c
@@ -39,14 +
the reserved ones.
Signed-off-by: Petr Machata
---
Notes:
v2:
- Add MAX_MESSAGE_TYPES with comment instead of using a bare constant.
ddt.h | 7 +++
port.c | 25 +++--
port_private.h | 1 +
3 files changed, 31 insertions(+), 2 deletions(-)
diff
Keller, Jacob E writes:
> I know we have the pmc man page
Gah, and I forgot to update it with the new stats message. I'll do that
shortly.
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/list
In commit 2b5bec8d2740 ("pmc: Add a new TLV to obtain per-port
statistics"), pmc gained a new TLV to obtain port stats from ptp4l. Mention
the TLV in the pmc man page.
Signed-off-by: Petr Machata
---
pmc.8 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/pmc.8 b/pmc.8
ind
at allows human-readable rendering of timestamping
type, which is one of the reported properties. Patch #2 then extends pmc.
Petr Machata (2):
util: Add a function to render timestamp type
pmc: Support querying TLV_PORT_PROPERTIES_NP
pmc.8| 2 ++
pmc.c| 16
pm
TLV_PORT_PROPERTIES_NP carries, among other attributes, a timestamp type
used for that port. In order to make it possible to format the value for
user consumption, introduce a new function ts_str().
Signed-off-by: Petr Machata
---
util.c | 18 ++
util.h | 7 +++
2 files
-off-by: Mykola Zhuravel
Signed-off-by: Petr Machata
---
pmc.8| 2 ++
pmc.c| 16
pmc_common.c | 1 +
3 files changed, 19 insertions(+)
diff --git a/pmc.8 b/pmc.8
index acf2d90..e0ab5ac 100644
--- a/pmc.8
+++ b/pmc.8
@@ -193,6 +193,8 @@ The MAC address to which
Jiri Benc writes:
> On Thu, 12 Sep 2019 11:06:30 +0000, Petr Machata wrote:
>> +text2str(&ppn->interface));
>
> How does this work when net name spaces are in use? There's no guarantee
> that pmc is run in the same net name space where pt
Jiri Benc writes:
> pmc is different. It's not tied to the service start time, it's used by
> administrators and by various scripts from varying environment. While
> you can reasonably expect that ptp4l and phc2sys will be run in the
> same name space, it's not necessarily the case for pmc.
Hm
Keller, Jacob E writes:
>> From: Petr Machata [mailto:pe...@mellanox.com]
>> Sent: Friday, September 13, 2019 7:58 AM
>> To: Jiri Benc
>> Cc: linuxptp-devel@lists.sourceforge.net
>> Subject: Re: [Linuxptp-devel] [PATCH 2/2] pmc: Support querying
>> TL
Jiri Benc writes:
> On Mon, 16 Sep 2019 14:04:00 +0000, Petr Machata wrote:
>> I was actually thinking about /var/run/netns being mounted elsewhere or
>> some such, which would prevent "ip netns id" from working. The symbolic
>> names seem to be accessible from o
Jiri Benc writes:
> On Mon, 16 Sep 2019 09:56:29 +0000, Petr Machata wrote:
>> Inside the namespace you can do "ip netns id" to get the namespace that
>> you are in.
>
> Beware that this netnsid is only valid in the net name space that the
> 'ip' c
27 matches
Mail list logo
