Dear LinuxPTP developers,
New posts to this list has been disabled. If you want to continue to
participate on the mailing lists, please subscribe to the new list at
the Network Time Foundation.
https://lists.nwtime.org/sympa/info/linuxptp-devel
Thanks,
Richard
On Wed, Dec 06, 2023 at 03:43:15PM +0100, Andrew Zaborowski wrote:
> Again feel free to include it or leave it for us to send separately.
I prefer to roll your fixes into this series.
Thanks,
Richard
___
Linuxptp-devel mailing list
On Tue, Dec 05, 2023 at 02:44:18AM +0100, Andrew Zaborowski wrote:
> * if I stop a CMLDS client and rerun it, it will receive the CMLDS
> notifications twice until the old subscription expires. If I restart
> it again quickly enough it'll receive each notification 3 times. This
> is because
On Mon, Dec 04, 2023 at 10:51:15PM +0100, Andrew Zaborowski wrote:
> I assume ignore_transport_specific can be dropped in this version.
Actually it is critical, if you care about being able to
inter-operate. After all, nothing guarantees that the link partner is
also running CMLDS. Experience
On Tue, Dec 05, 2023 at 08:57:36AM +0100, Miroslav Lichvar wrote:
> On Mon, Dec 04, 2023 at 11:25:00PM +0100, Andrew Zaborowski wrote:
> > Doing cnt != 4 && cnt != 5 should just work as sscanf() should stop
> > parsing when it doesn't find NOTIFY_CMLDS and leave onoff_cmlds as
> > "off".
On Mon, Dec 04, 2023 at 08:39:47AM +0100, Maciek Machnikowski wrote:
> Hey, please take a look at these patches and merge them if there are no
> bugs in this code.
I don't understand the need for this series.
What problem does it solve?
Thanks,
Richard
On Sun, Dec 03, 2023 at 06:15:52PM -0800, Kishen Maloor wrote:
> On 12/1/23 10:07 PM, Richard Cochran wrote:
> > Does the standard require that either ALL the nodes in a network use
> > CMLDS, or none do at all?
> >
>
> When the time-aware system supports multiple d
On Sat, Dec 02, 2023 at 02:28:54PM -0800, Richard Cochran wrote:
> On Sat, Dec 02, 2023 at 02:24:52PM -0800, Richard Cochran wrote:
>
> > Changes in v2
> > ~
> > - Added timer to renew push subscription and detect missing server.
> > - Addressed Andre
-by: Richard Cochran
---
pmc.c| 6 --
pmc_agent.c | 3 ++-
pmc_common.c | 8
pmc_common.h | 6 +++---
tz2alt.c | 3 ++-
uds.c| 6 --
6 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/pmc.c b/pmc.c
index 9faf790..d18fea0 100644
--- a/pmc.c
+++ b
Signed-off-by: Richard Cochran
---
configs/CMLDS_client.cfg | 10 ++
configs/CMLDS_server.cfg | 16
2 files changed, 26 insertions(+)
create mode 100644 configs/CMLDS_client.cfg
create mode 100644 configs/CMLDS_server.cfg
diff --git a/configs/CMLDS_client.cfg b
Add a new TLV to convey link delay measurements by the Common Mean
Link Delay Service (CMLDS) (as specified in IEEE 1588/16.6.3) over the
management interface.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
Signed-off-by: Richard Cochran
---
clock.c | 1 -
pmc.c
If a given port selects the COMMON_P2P delay mechanism, let it open a
local PTP Management channel to the Common Mean Link Delay Service
over a UNIX domain socket.
Signed-off-by: Richard Cochran
---
config.c| 6 ++
configs/default.cfg | 5 ++
dm.h| 3 +
fd.h
remote UDS address.
Signed-off-by: Richard Cochran
---
clock.c | 4 ++--
config.c | 2 +-
interface.c | 12 ++--
interface.h | 10 +-
pmc_common.c | 2 +-
5 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/clock.c b/clock.c
index b66dda5..6f7722c 100644
the right thing.
- Add COMMOM_P2P to the list of delay mechanisms in the man page.
Changes in v2
~
- Added timer to renew push subscription and detect missing server.
- Addressed Andrew and Kishen's review comments.
- Added example configuration files.
Richard Cochran (6):
interface
Signed-off-by: Richard Cochran
---
notification.h | 1 +
pmc.c | 6 --
pmc_common.c | 14 ++
port.c | 7 +++
4 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/notification.h b/notification.h
index c1a6395..7a8f641 100644
On Sat, Dec 02, 2023 at 02:24:52PM -0800, Richard Cochran wrote:
> Changes in v2
> ~
> - Added timer to renew push subscription and detect missing server.
> - Addressed Andrew and Kishen's review comments.
> - Added example configuration files.
I also updat
If a given port selects the COMMON_P2P delay mechanism, let it open a
local PTP Management channel to the Common Mean Link Delay Service
over a UNIX domain socket.
Signed-off-by: Richard Cochran
---
config.c| 6 ++
configs/default.cfg | 5 ++
dm.h| 3 +
fd.h
-by: Richard Cochran
---
pmc.c| 6 --
pmc_agent.c | 3 ++-
pmc_common.c | 8
pmc_common.h | 6 +++---
tz2alt.c | 3 ++-
uds.c| 6 --
6 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/pmc.c b/pmc.c
index 9faf790..d18fea0 100644
--- a/pmc.c
+++ b
Add a new TLV to convey link delay measurements by the Common Mean
Link Delay Service (CMLDS) (as specified in IEEE 1588/16.6.3) over the
management interface.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
Signed-off-by: Richard Cochran
---
clock.c | 1 -
pmc.c
Signed-off-by: Richard Cochran
---
notification.h | 1 +
pmc.c | 6 --
pmc_common.c | 14 ++
port.c | 7 +++
4 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/notification.h b/notification.h
index c1a6395..7a8f641 100644
and detect missing server.
- Addressed Andrew and Kishen's review comments.
- Added example configuration files.
Richard Cochran (6):
interface: Add an optional remote address for use by the UDS
transport.
pmc/uds: Configure the remote server address using the interface API.
Introduce the Common
remote UDS address.
Signed-off-by: Richard Cochran
---
clock.c | 4 ++--
config.c | 2 +-
interface.c | 12 ++--
interface.h | 10 +-
pmc_common.c | 2 +-
5 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/clock.c b/clock.c
index b66dda5..6f7722c 100644
Signed-off-by: Richard Cochran
---
configs/CMLDS_client.cfg | 10 ++
configs/CMLDS_server.cfg | 16
2 files changed, 26 insertions(+)
create mode 100644 configs/CMLDS_client.cfg
create mode 100644 configs/CMLDS_server.cfg
diff --git a/configs/CMLDS_client.cfg b
On Wed, Nov 22, 2023 at 09:36:36AM -0800, Rahul Rameshbabu via Linuxptp-devel
wrote:
> Use the common NSEC_PER_SEC macro in phc_ctl.
>
> Signed-off-by: Rahul Rameshbabu
Series applied, but I fixed up one more NSEC2SEC that was added into
phc_ctl.c since this series was posted.
Thanks,
Richard
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote:
> CMLDS ptp4l process would be configured with
> transportSpecific/domain=0x2/0.
Question about the spec:
How on earth is this going to work?
I mean, if the link partner is not also using CMLDS, then it won't
reply because of the
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote:
> If serviceMeasurementValid=true, then we set both peer_portid_valid and
> p->nrate.ratio_valid to true so that port_capable() could evaluate to true.
Even simpler: include asCapable from the CMLDS Link Port in the TLV,
and just
On Thu, Nov 30, 2023 at 04:52:44PM -0800, Kishen Maloor wrote:
> > + p->cmlds_pmc = pmc_create(cfg, TRANS_UDS,
> > + config_get_string(cfg, p->name,
> > "cmlds_client_address"),
> > + config_get_string(cfg, p->name,
> >
On Thu, Nov 30, 2023 at 07:12:54PM +0100, Andrew Zaborowski wrote:
> On Thu, 30 Nov 2023 at 17:44, Richard Cochran
> wrote:
> > On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote:
> > > > + PORT_ITEM_STR("cmlds_client_address", "/var/r
On Thu, Nov 30, 2023 at 04:32:20PM +0100, Andrew Zaborowski wrote:
> > @@ -249,6 +250,9 @@ struct config_item config_tab[] = {
> > GLOB_ITEM_INT("clock_class_threshold",
> > CLOCK_CLASS_THRESHOLD_DEFAULT, 6, CLOCK_CLASS_THRESHOLD_DEFAULT),
> > GLOB_ITEM_ENU("clock_servo",
On Wed, Nov 29, 2023 at 11:57:16PM -0800, Richard Cochran wrote:
> This is how CMLD should be done, IMHO.
Sample configs...
CMLDS_server.cfg
[global]
clientOnly 1
free_running1
uds_address /var/run/cmlds_server
use_syslog 0
verbose
Signed-off-by: Richard Cochran
---
notification.h | 1 +
pmc.c | 6 --
pmc_common.c | 14 ++
port.c | 5 +
4 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/notification.h b/notification.h
index c1a6395..7a8f641 100644
--- a/notification.h
Add a new TLV to convey link delay measurements by the Common Mean
Link Delay Service (CMLDS) (as specified in IEEE 1588/16.6.3) over the
management interface.
Co-authored-by: Andrew Zaborowski
Signed-off-by: Kishen Maloor
Signed-off-by: Richard Cochran
---
clock.c | 1 -
pmc.c
From: Kishen Maloor
Signed-off-by: Richard Cochran
---
config.c | 4 ++
dm.h | 3 +
fd.h | 1 +
makefile | 4 +-
port.c | 166 +++--
port_private.h | 3 +
6 files changed, 174 insertions(+), 7
subscription with renewal logic
- man page update for new cmlds options
Please review and test to shake out the bugs.
Thanks,
Richard
Kishen Maloor (1):
Implement the COMMON_P2P delay mechanism.
Richard Cochran (4):
interface: Add an optional remote address for use by the UDS transport
Signed-off-by: Richard Cochran
---
pmc.c| 6 --
pmc_agent.c | 3 ++-
pmc_common.c | 8
pmc_common.h | 6 +++---
tz2alt.c | 3 ++-
uds.c| 6 --
6 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/pmc.c b/pmc.c
index 9faf790..d18fea0 100644
Signed-off-by: Richard Cochran
---
clock.c | 4 ++--
config.c | 2 +-
interface.c | 12 ++--
interface.h | 10 +-
pmc_common.c | 2 +-
5 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/clock.c b/clock.c
index b66dda5..6f7722c 100644
--- a/clock.c
+++ b
On Tue, Nov 28, 2023 at 12:53:38PM +0100, Miroslav Lichvar wrote:
> On Sun, Nov 26, 2023 at 11:10:05AM -0800, Richard Cochran wrote:
> > The Rx filters are applied globally at the device level, but the PTP
> > operates at the application level. This means that the Rx filter are
>
On Mon, Nov 27, 2023 at 10:47:48AM +0300, IlorDash wrote:
> Thanks, Richard, for such a detailed answer!
> I'll try to find another solution to handle it.
You can always keep your patches for your custom build. After all, it
is open source, free for you to adapt. But I don't want to include
On Mon, Nov 27, 2023 at 10:20:56AM +0100, Erez wrote:
> It is public if you change the printed name in PMC.
You mean scripts that invoke pmc?
Yeah, that could cause users' setups to break.
Thanks,
Richard
___
Linuxptp-devel mailing list
On Wed, Nov 08, 2023 at 03:14:04AM +0800, Chwee-Lin Choong wrote:
> The patches aim to enhance the handling of multiple pdelay responses.
> These improvements are aligned with both IEEE 802.1AS-2011 and
> IEEE 802.1AS-2020 standards.
>
> The first patch introduces configurability for
On Thu, Nov 23, 2023 at 01:39:45PM +0100, Erez wrote:
> On Thu, 23 Nov 2023 at 04:26, Chwee-Lin Choong
> wrote:
>
> > Add the computation for scaledLastGmFreqChange, as specified in
> > IEEE 802.1AS-2020, clause 11.4.4.3.9. This incorporates the
> > necessary logic to calculate
On Fri, Nov 10, 2023 at 06:46:57PM +0100, Maciek Machnikowski wrote:
> Some hardware can't properly timestamp packets with the new PTP
> header version 2.1. This patch adds legacy_ptp_ver config option that
> allows advertising of the legacy 2.0 protocol.
>
> Additionally, forcing PTP minor
On Fri, Nov 10, 2023 at 06:46:56PM +0100, Maciek Machnikowski wrote:
> Some hardware can't properly timestamp packets with the new PTP
> header version 2.1. This patch introduces a global var ptp_hdr_ver
> that can be changed externally to allow legacy PTP version to be
> advertised.
>
> Forcing
On Mon, Nov 13, 2023 at 02:38:19PM +0100, Erez wrote:
> I think Richard means using the SUBSCRIBE_EVENTS_NP.
Yes.
> Adding new events, and make sure the ptp4l sends all the statistics you
> need together.
Yes, but please don't "overload" the existing counters. Just add new
fields with names
On Mon, Oct 23, 2023 at 10:43:43AM +0100, Luca Fancellu wrote:
> The Makefile is defining CC and incdefs.sh is using
> ${CROSS_COMPILE}cpp inside it, allowing both to use different
> compilers depending on what the user pass during make invocation
> as CC.
>
> Align them using ${CC} also inside
On Mon, Oct 23, 2023 at 10:43:42AM +0100, Luca Fancellu wrote:
> From: Khem Raj
>
> Signed-off-by: Khem Raj
> ---
> Changes from v1:
> - no changes
> ---
> interface.c | 1 +
> 1 file changed, 1 insertion(+)
Applied.
Thanks,
Richard
___
On Sun, Nov 26, 2023 at 01:38:15PM +0300, IlorDash wrote:
> Could you, please, explain why you think my hardware is broken? I thought,
> since SYNC and DELAY_REQ filters are defined in Linux, ptp4l can use them
> to set type-specific hardware filters.
Here is another reason why:
The Rx filters
On Sun, Nov 26, 2023 at 01:38:15PM +0300, IlorDash wrote:
> Could you, please, explain why you think my hardware is broken? I thought,
> since SYNC and DELAY_REQ filters are defined in Linux, ptp4l can use them
> to set type-specific hardware filters.
The port role can and will suddenly change at
On Fri, Nov 24, 2023 at 10:29:12PM +0300, IlorDash wrote:
> From: Ilya Orazov
>
> I’m using an Ethernet controller with PTP support, which requires
> determining which PTP packets on RX must be timestamped: SYNC or
> DELAY_REQ, based on whether the device is Slave or Master respectively.
> So I
On Tue, Nov 21, 2023 at 11:04:48AM +0100, Maciek Machnikowski wrote:
> No leap seconds will happen till 28 June 2024. Update leapfile validity
> accordingly.
> Add a new source of leapsecond file from the IERS.
>
> v2: Removed obsolete links
>
> Signed-off-by: Maciek Machnikowski
Applied.
On Tue, Nov 14, 2023 at 04:23:26PM +0100, Miroslav Lichvar wrote:
> If the string specified by the message_tag option contains "{level}",
> replace it with the log level of the message as a number.
>
> This allows users to filter printed log messages by their level.
>
> Signed-off-by: Miroslav
On Tue, Nov 14, 2023 at 01:18:58PM +0100, Miroslav Lichvar wrote:
> v2:
> - changed pmc_agent_subscribe() to accept update interval instead of
> subscription duration to simplify the code and keep constants in one place
> - reordered and merged patches to better follow the previous change
> -
On Tue, Oct 10, 2023 at 12:29:22PM +0200, Paweł Modrzejewski wrote:
> Make it possible to set timeout values bigger than 2.147 sec
> and print error message in case port_set_sync_rx_tmo() fails.
>
> Signed-off-by: Paweł Modrzejewski
Applied.
Thanks,
Richard
On Mon, Jun 26, 2023 at 05:16:20PM +0200, Miroslav Lichvar wrote:
> Add a new notification event for pmc clients to receive
> PARENT_DATA_SET when a change is made there.
>
> Signed-off-by: Miroslav Lichvar
Applied.
linuxptp-testsuite test 20-pmc now fails with
"SUBSCRIBE_EVENTS_NP SET
Vincent,
Sorry for the VERY long delay in reviewing your patches...
On Mon, Mar 13, 2023 at 11:22:25PM -0400, Vincent Cheng wrote:
> +int unicast_client_delay_response_granted(struct port *p)
> +{
> + struct unicast_master_address *ucma;
> +
> + if (!unicast_client_enabled(p)) {
> +
On Fri, Nov 17, 2023 at 03:29:16PM -0800, Cliff Spradlin via Linuxptp-devel
wrote:
> I'm investigating why a port immediately enters a faulty state on
> startup (and then self-recovers).
>
> It looks like there might be some buggy rtnl logic.
This sounds familiar... wasn't there a bug in this
On Fri, Nov 17, 2023 at 08:27:43PM -0800, Richard Cochran wrote:
> How does this requirement improve synchronization?
>
> What benefit does it bring to users of the PTP?
rhetorical questions :^(
___
Linuxptp-devel mailing list
Linux
On Fri, Nov 17, 2023 at 01:51:18PM +0100, Andrew Zaborowski wrote:
> It is exposed on the wire in the Pdelay messages. Compliance tests
> look at this. They also simulate a few hypothetical scenarios like a
> domain 0 PTP port trying to communicate with a CMLDS link port since
> 1588 talks
On Fri, Nov 17, 2023 at 01:41:19AM +0100, Andrew Zaborowski wrote:
> On Thu, 16 Nov 2023 at 23:46, Richard Cochran
> wrote:
> > No, I mean the PTP port number. These are taken from the order of the
> > interfaces on the command line and in the configuration file.
>
>
On Thu, Nov 16, 2023 at 11:11:50PM +0100, Andrew Zaborowski wrote:
> The two timestamps are passed to clock_peer_delay() by the receiving
> port and stored in c->tsproc. Then they're accessed by
> get_raw_delay() which is used in the filter logic. I'm not sure how
> much value that has, we can
On Thu, Nov 16, 2023 at 10:42:33AM +, ramesh t wrote:
> Under GNSS fluctuation condition due bad weather or improper
> location of GNSS antenna, observed ts2phc process updates 1 sec
> difference into the physical hard clock (PHC) of the NIC. This 1
> sec jump is seen momentarily as captured
On Mon, Jun 26, 2023 at 12:03:29PM -0700, Jacob Keller wrote:
> Extend phc_ctl with a new get_pins_cfg command which calls the
> PTP_PIN_GETFUNC ioctl on a PHC clock and prints the pin configuration for
> each pin.
>
> Changes since v3:
> * remove use of PTP_PIN_SETFUNC2 and PTP_PIN_GETFUNC2 at
On Wed, Nov 15, 2023 at 09:45:52PM -0800, Richard Cochran wrote:
> On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:
>
> > @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv {
> > UInteger16numberOfBitsAfterTimestamp;
> > } PACKED;
> &g
On Wed, Nov 15, 2023 at 08:58:58PM -0800, Richard Cochran wrote:
> The text of 1588 strongly suggests that the CMLDS service be stand
> alone daemon. However, we can provide the same functionality without
> the extra complexity, by simply letting ptp4l serve the measured peer
> delay
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:
> @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv {
> UInteger16numberOfBitsAfterTimestamp;
> } PACKED;
>
> +struct cmlds_info_np {
> + Integer8 serviceMeasurementValid;
> + TimeInterval meanLinkDelay;
>
On Wed, Nov 15, 2023 at 09:05:45PM -0800, Richard Cochran wrote:
> I'd like to have this:
>
> 1. provide the new TLV via the PUSH mechanism.
>
> 2. let clients using DM_COMMON_P2P subscribe to the new TLV.
>
> 3. let the client update their peer delay values bas
On Mon, Aug 21, 2023 at 10:44:27AM +0200, Walfred Tedeschi wrote:
> On 11.08.23 19:13, Richard Cochran wrote:
> > The CMLDS series will require careful review. My superficial review
> > gave me the impression that the approach was too complex.
> Do you have an indicati
On Mon, May 15, 2023 at 06:26:07PM -0400, Kishen Maloor wrote:
> For ports that are configured with "run_cmlds=1", i.e. CMLDS Link
> Ports, this change updates port_pdelay_request(), process_pdelay_req() and
> port_peer_delay() to utilize the CMLDS sdoid/domainNumber/portId
> along code paths
On Mon, May 15, 2023 at 06:26:12PM -0400, Kishen Maloor wrote:
> This change adds 'allowedLostResponses' as a per-port parameter
> with a default value of 3 (per IEEE 802.1AS-2011, clause 11.5.3).
> (Note that this matches the value of the previously #define'd
> ALLOWED_LOST_RESPONSES, so this
On Mon, May 15, 2023 at 06:26:10PM -0400, Kishen Maloor wrote:
> From: Andrew Zaborowski
>
> This change implements the COMMON_P2P DM by issuing a request
> to the CMLDS for CommonMeanLinkDelayInformation upon expiry of
> the delay timer and handles the response to assimilate the
> received
On Mon, May 15, 2023 at 06:26:09PM -0400, Kishen Maloor wrote:
> This change furnishes the plumbing for interacting with CMLDS
> Link Ports (i.e. ports with "run_cmlds=1").
>
> It adds internal functions for PTP Ports which employ the
> COMMON_P2P delay mechanism to issue requests to a CMLDS Link
On Mon, May 15, 2023 at 06:26:08PM -0400, Kishen Maloor wrote:
> port_cmlds_ignore() assesses incoming messages per the following
> policy:
>
> * All messages that bear the CMLDS sdoid/domainNumber are directed
> to a CMLDS Link Port context and processed by this function. All other
> messages go
On Mon, May 15, 2023 at 06:26:07PM -0400, Kishen Maloor wrote:
> For ports that are configured with "run_cmlds=1", i.e. CMLDS Link
> Ports, this change updates port_pdelay_request(), process_pdelay_req() and
> port_peer_delay() to utilize the CMLDS sdoid/domainNumber/portId
> along code paths
On Mon, May 15, 2023 at 06:26:06PM -0400, Kishen Maloor wrote:
> This change adds COMMON_P2P (IEEE 802.1AS-2020, clause 14.8.5) to the
> enumeration of delay mechanisms and incorporates it into existing code
> paths pertaining to DM_P2P to (where appropriate) maintain parity with
> DM_P2P.
>
>
On Mon, May 15, 2023 at 06:26:05PM -0400, Kishen Maloor wrote:
> 'cmlds_clockIdentity': This global setting assigns a CMLDS
> clockIdentity to be used by a ptp4l instance on a PTP node that exposes
> CMLDS over one or more links.
Don't really need this. I know it is specified in 1588, but it is
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:
> @@ -490,6 +491,15 @@ static int mgt_post_recv(struct management_tlv *m,
> uint16_t data_len,
> if (data_len != 0)
> goto bad_length;
> break;
> + case MID_CMLDS_INFO_NP:
> +
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:
> @@ -651,6 +652,18 @@ static void pmc_show(struct ptp_message *msg, FILE *fp)
> fprintf(fp, "LOG_MIN_PDELAY_REQ_INTERVAL "
> IFMT "logMinPdelayReqInterval %hhd", mtd->val);
> break;
>
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:
> @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv {
> UInteger16numberOfBitsAfterTimestamp;
> } PACKED;
>
> +struct cmlds_info_np {
> + Integer8 serviceMeasurementValid;
> + TimeInterval meanLinkDelay;
>
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote:
> @@ -1129,6 +1130,27 @@ static int port_management_fill_response(struct port
> *target,
> memcpy(pwr, >pwr, sizeof(*pwr));
> datalen = sizeof(*pwr);
> break;
> + case MID_CMLDS_INFO_NP:
On Fri, Nov 10, 2023 at 02:03:24PM +0100, Maciek Machnikowski wrote:
> Forcing 2.1 also breaks interoperability with some older
> grandmasters which will ignore packets with ptp_minor version set.
Please limit the subject line to one sentence.
Please avoid the phrase, "this patch".
>From
On Fri, Nov 10, 2023 at 02:03:25PM +0100, Maciek Machnikowski wrote:
> @@ -279,6 +279,7 @@ struct config_item config_tab[] = {
> PORT_ITEM_INT("interface_rate_tlv", 0, 0, 1),
> GLOB_ITEM_INT("kernel_leap", 1, 0, 1),
> GLOB_ITEM_STR("leapfile", NULL),
> +
On Fri, Nov 10, 2023 at 07:58:14AM +0100, Luigi 'Comio' Mantellini wrote:
> Using just polling on UDS is a bad idea IMHO because you need to capture at
> the exact same time point all counters of all ports spending a lot of
> effort and cpu.
So make it into a PUSH message.
> It's better to have
On Fri, Nov 10, 2023 at 11:16:38AM +0100, Maciek Machnikowski wrote:
> In my tests it worked fine, but I'd be more than happy to increase it -
> would 5s be sufficient there?
It should be more like 25 seconds, but you may have very loose
requirements.
In any case:
- The interval must be
On Thu, Oct 26, 2023 at 02:40:11PM +0200, Miroslav Lichvar wrote:
> @@ -942,8 +957,8 @@ static int auto_init_ports(struct domain *domain)
> }
>
> err = pmc_agent_subscribe(domain->agent, 1000,
> - (60 > domain->phc_interval ?
> -
On Thu, Oct 26, 2023 at 02:40:10PM +0200, Miroslav Lichvar wrote:
> @@ -1010,7 +1010,7 @@ static int clock_handle_leap(struct domain *domain,
> struct clock *clock,
> struct pmc_agent *agent;
>
> /* The system clock's domain doesn't have a subscribed agent */
> - agent =
On Thu, Nov 09, 2023 at 06:07:57PM +, ramesh t via Linuxptp-devel wrote:
> Update Code review request. Can you please provide comments?
You have not identified any problem, and so I cannot comment.
A proper commit message has three elements:
1. context
2. problem
3. solution
That means
On Mon, Sep 25, 2023 at 04:38:21PM +0200, Miroslav Lichvar wrote:
> If multiple management clients are used in the network and ptp4l
> responded at least once over UDS, it will try to forward all management
> responses received from network to the last UDS client. ptp4l doesn't
> track the
On Wed, Sep 13, 2023 at 05:09:04PM +, Maciek Machnikowski wrote:
> Implement auto mode for frequency setting. In this mode the tool
> will measure the frequency difference between PHC and CLOCK_REALTIME
> and apply the correction to the PHC to match the system clock.
...
> + /*
On Mon, Sep 11, 2023 at 09:53:54PM +, Keller, Jacob E wrote:
>
>
> > -Original Message-
> > From: Eyal Itkin via Linuxptp-devel
> > Sent: Sunday, September 10, 2023 9:23 AM
> > To: linuxptp-devel@lists.sourceforge.net
> > Subject: [Linuxptp-devel] [PATCH] [pmc] Avoid conflicting
On Wed, Sep 06, 2023 at 09:15:09AM -0400, Peter Sadrozinski via Linuxptp-devel
wrote:
> My question: is there any way to configure ptp4l to not concatenate TLVs in
> unicast grant requests?
No.
> The same boundary clock works ok with a
> proprietary ptp stack, which is sending unicast grant
On Wed, Sep 06, 2023 at 09:36:38AM +0200, Luigi Mantellini wrote:
> The PORTS_STATS_2_NP carries all the PORTS_STATS_NP RX/TX counters
> adding room for extra counters (up to 16 counters for RX and TX).
> Not all counters are filled yet.
>
> The PORTS_STATS_2_NP TLV has the following definition:
On Fri, Aug 18, 2023 at 02:34:54PM +0200, Luigi Mantellini wrote:
> Dear All,
>
> Starting from IEEE 1588-2019 Annex J, I'm trying to introduce a Performace
> monitoring Counters.
>
> The standard asks to keep up 98 records (96 for 15min records and 2 for 24h
> records).
>
> I tried to follow a
On Mon, Sep 25, 2023 at 10:03:12AM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> Adjusted frequency value displayed by do_freq is not an error, but a
> notication to the user. pr_err should not be used for providing notices
> with information about successful operations.
>
> Fixes:
On Mon, Sep 25, 2023 at 10:03:13AM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> Do not print success notices if clockadj operation fails using return
> values provided by the clockadj helpers.
>
> Signed-off-by: Rahul Rameshbabu
Applied.
Thanks,
Richard
On Mon, Sep 25, 2023 at 10:03:11AM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> Advertise the maximum offset that can be fed to the PHC phase control
> keyword.
>
> Signed-off-by: Rahul Rameshbabu
Applied.
Thanks,
Richard
___
Linuxptp-devel
On Mon, Sep 25, 2023 at 10:03:10AM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> Take double precision floating point representation of an offset value in
> seconds. Feed this value to the PHC's phase control keyword.
>
> Signed-off-by: Rahul Rameshbabu
Applied, with a trivial fixup.
On Mon, Sep 25, 2023 at 10:03:09AM -0700, Rahul Rameshbabu via Linuxptp-devel
wrote:
> The name NSEC2SEC implies converting nanoseconds to seconds, but the value
> used for the macro converts seconds to nanoseconds. NSEC_PER_SEC is the
> accurate name for this macro. Move macro to common location
On Thu, Nov 09, 2023 at 09:44:56AM -0500, Clay Kaiser via Linuxptp-devel wrote:
> The following patch introduces initial support for immediate security
> processing of
> authentication tlv as defined in IEEE1588-2019 section 16.14.
>
> Integrity Check Values (aka Message Authentication Codes)
On Tue, Nov 07, 2023 at 11:07:21PM +, Choong, Chwee Lin wrote:
> Without the proposed fix, the DUT would interpret duplicate
> Pdelay_Resp messages as valid responses, leading to undesired
> behavior, particularly in achieving the "asCapable" state.
Okay, thanks for the clarification.
On Wed, Nov 08, 2023 at 03:14:06AM +0800, Chwee-Lin Choong wrote:
> The current implementation falls short in detecting duplicate
> pdelay responses, i.e., multiple responses from the same peer.
There can only ever be one peer, and so it is pointless to track the peer.
If more than one peer
1 - 100 of 2162 matches
Mail list logo
