Re: [Linuxptp-devel] [PATCH] ptp4l: Add IPoIB interface support for ptp4l

On Tue, Aug 01, 2017 at 10:45:54AM +0300, Feras Daoud wrote: > Since this patch transfer ptp4l from non-working state to properly working > for those interfaces, I would like to see it is accepted, so other > infiniband users will enjoy from such functionality. It is on my todo list. Thanks,

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Thu, Aug 10, 2017 at 06:31:56PM +0800, Hangbin Liu wrote: > Would it be better to pass a device name? If we pass the index number. Then we > need to convert both iface->name and port->name to index in rtnl_link_info() > and port_event(). > > And if pass a device name. We can convert the name

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Thu, Aug 10, 2017 at 04:10:49PM +0800, Hangbin Liu wrote: > Yes, that would be more clear, especially the call path 1. Then how about > > 2. clock_create() -> rtnl_link_info() -> rtnl_link_status() > > > Should we get the ts_iface inside rtnl_link_status() like: No. > Or just let

Re: [Linuxptp-devel] [PATCHv2 7/9] port.c: fix port_dispatch event flood when change ts_iface info

On Sat, Aug 12, 2017 at 10:16:20PM +0800, Hangbin Liu wrote: > For example, when the first time we receive a linkup + ts_iface change > message, we need to return EV_FAULT_DETECTED. But as we know, we may > recive multi linkup message. For these kind of message, we need to return > EV_NONE.

Re: [Linuxptp-devel] [PATCHv2 7/9] port.c: fix port_dispatch event flood when change ts_iface info

On Sun, Aug 13, 2017 at 11:21:21PM +0800, Hangbin Liu wrote: > On Sat, Aug 12, 2017 at 04:41:23PM +0200, Richard Cochran wrote: > > Looks better to me, but why not place this code at the end of the > > port_link_status() function? ... > 2. If We receive one rtnl message with

Re: [Linuxptp-devel] Wrong Interface

On Tue, Jul 11, 2017 at 01:24:08PM -0400, Amritpal Bains wrote: > I apologize for the long delay in my response. No problem. > How do I check if ptp4l is running in hybrid_e2e mode? If your configuration file has hybrid_e2e 1 then you are using that mode. > > (The source address is

Re: [Linuxptp-devel] [PATCH 2/4] port: add FD_RTNL event to track per-port status

On Wed, Jul 05, 2017 at 05:59:50PM +0800, Hangbin Liu wrote: > @@ -1502,11 +1506,22 @@ static int port_initialize(struct port *p) > if (port_set_announce_tmo(p)) > goto no_tmo; > > + /* No need to open rtnl socket on UDS port. */ > + if (p->announce_span) { The type

Re: [Linuxptp-devel] [PATCH 0/4] Add rtnl per port support

On Wed, Jul 05, 2017 at 05:59:48PM +0800, Hangbin Liu wrote: > As discussed, now we convert single rtnl FD into per-port FD and remove > index2port hash table from clock.c Apart from a small issue in #2, the series looks good to go. Thanks, Richard

Re: [Linuxptp-devel] [PATCH 3/4] clock: remove rtnl fd on clock

On Wed, Jul 05, 2017 at 05:59:51PM +0800, Hangbin Liu wrote: > @@ -1164,9 +1132,7 @@ struct clock *clock_create(enum clock_type type, struct > config *config, > port_dispatch(p, EV_INITIALIZE, 0); > } > port_dispatch(c->uds_port, EV_INITIALIZE, 0); > - if

Re: [Linuxptp-devel] [PATCH 0/4] Add rtnl per port support

On Sat, Jul 08, 2017 at 10:44:19PM +0200, Richard Cochran wrote: > Apart from a small issue in #2, the series looks good to go. Also found an issue in #3 by testing... Thanks, Richard -- Check out the vibrant t

Re: [Linuxptp-devel] [PATCHv2 0/4] Add rtnl per port support

On Mon, Jul 10, 2017 at 03:39:27PM +0800, Hangbin Liu wrote: > As discussed, now we convert single rtnl FD into per-port FD and remove > index2port hash table from clock.c > > v2: > 1. Let program still work even rtnl_open() failed. > 2. Start rtnl_link_query() to check link status if rtnl_open()

Re: [Linuxptp-devel] [PATCH] pmc: support getting the port properties np.

On Mon, Jul 17, 2017 at 05:22:29PM +0300, Mykola Zhuravel wrote: > + case TLV_PORT_PROPERTIES_NP: > + ppnp = (struct port_properties_np *) mgt->data; > + if (ppnp->port_state > PS_SLAVE) { > + ppnp->port_state = 0; > + } > +

Re: [Linuxptp-devel] [PATCH] pmc: support getting the port properties np.

On Tue, Jul 18, 2017 at 12:14:54PM +, Mykola Zhuravel wrote: > Will printout below be a good example? > > [admin@arc-switch120 ~]# pmc -u -d 127 'GET PORT_PROPERTIES_NP' > sending: GET PORT_PROPERTIES_NP > e41d2d.fffe.446581-1 seq 0

Re: [Linuxptp-devel] [PATCH] pmc: support a new custom TLV the "port counters".

On Wed, Jul 19, 2017 at 06:40:35PM +0300, Mykola Zhuravel wrote: > - support getting counters of port RX/TX messages > - support set(clear) counters of port RX/TX messages This patch adds too many thing at once. It really should be a series, step by step. The naming is terrible.

[Linuxptp-devel] [PATCH RFC 0/3] Fix UTC offset issue

This patch series addresses the jumping UTC offset issue that occurs when the default TAI-UTC offset is out of date, but a then GM master appears providing the correct offset, only to disappear again. Review and comments are most welcome. Thanks, Richard Richard Cochran (3): Simplify UTC

[Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

master causes a sudden UTC offset error (in phc2sys for example) in the range of whole seconds. This patch fixes the issue by remembering the UTC offset when assuming the slave role. Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- clock.c | 5 + 1 file changed, 5 inse

[Linuxptp-devel] [PATCH RFC 3/3] Remove redundant test on the UTC flags.

Now that we test the UTC flags in clock_update_slave(), the similar code in clock_utc_correct() is redundant. Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- clock.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/clock.c b/clock.c index da1fcc4..9

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

On Thu, Jul 27, 2017 at 10:17:51AM +0800, Phil Reid wrote: > On 27/07/2017 05:02, Richard Cochran wrote: > > On Wed, Jul 26, 2017 at 10:23:05AM +0200, Miroslav Lichvar wrote: > > > On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote: > > > > + if

Re: [Linuxptp-devel] [PATCHv2 0/9] Add linuxptp bond failover support

On Wed, Jul 26, 2017 at 03:41:14PM +0800, Hangbin Liu wrote: > Hi Richard, > > Any other comments? Yes, I do have some more comments. Please be patient, I hope to have my review done by Monday... Thanks, Richard --

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

On Thu, Jul 27, 2017 at 11:54:04AM +0200, Miroslav Lichvar wrote: > Are there other values that can break slaves in such a way they have > to be restarted? Probably, but I don't know. There are lots of data set members to consider. Also, even if we could detect bad masters, the remedy would be

Re: [Linuxptp-devel] [PATCH RFC 2/3] Latch the UTC offset.

On Wed, Jul 26, 2017 at 10:23:05AM +0200, Miroslav Lichvar wrote: > On Mon, Jul 24, 2017 at 06:38:19PM +0200, Richard Cochran wrote: > > + if ((c->tds.flags & UTC_OFF_VALID && c->tds.flags & TIME_TRACEABLE) || > > + (c->tds.currentUtcOffset >

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

You should return early when there are no resources to free: +int rtnl_link_info(struct interface *iface) +{ + int fd, index; int err, fd, index; (See below for 'err') + index = if_nametoindex(iface->name); + + if (index == 0) { + pr_err("failed to get

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Thu, Jul 20, 2017 at 03:52:33PM +, Keller, Jacob E wrote: > Correct. I like your proposed solution better. I was merely > re-writing to show how the logic flow would work, and preserved the > return code the original code had. Yeah, sorry for the noise. I was so tired, I thought that your

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Wed, Jul 19, 2017 at 08:47:43PM +, Keller, Jacob E wrote: > if (rtnl_link_query(fd, index)) > err = -1; > else if (rtnl_link_status(fd, NULL, iface->ts_iface)) > err = -1; This is poor practice, because you clobber the code returned from the sub-routine that experienced the error.

Re: [Linuxptp-devel] [PATCH 1/8] rtnl: use ifinfomsg instead of rtgenmsg to request link info

rovement. Back when I introduced rtnl, I wrote this: From 0b3c045a4236f128ab4c1592e6cc91adc1cd6eb0 Mon Sep 17 00:00:00 2001 From: Richard Cochran <richardcoch...@gmail.com> Date: Sun, 31 Jul 2016 12:08:24 +0200 Subject: rtnl: Introduce RT netlink sockets. This patch adds a source module that

Re: [Linuxptp-devel] Build commands

On Sat, Jul 01, 2017 at 11:56:14PM +0200, Petr Kulhavy wrote: > is there a specific reason why Linuxptp overrides the build commands to gcc > and cpp (with the $(CROSS_COMPILE) prefix) instead of using the standard > Make variables $(CC) and $(CPP)? The only reason is that GCC is the compiler in

Re: [Linuxptp-devel] [PATCH 2/8] rtnl: extend struct interface and add new function rtnl_link_info

This patch has a number of coding style issues... On Sat, Jun 24, 2017 at 04:48:30PM +0800, Hangbin Liu wrote: > diff --git a/rtnl.c b/rtnl.c > index 39faeb7..971f273 100644 > --- a/rtnl.c > +++ b/rtnl.c > @@ -18,8 +18,6 @@ > */ > #include > #include /* Must come before linux/netlink.h on

Re: [Linuxptp-devel] [PATCH 1/8] rtnl: use ifinfomsg instead of rtgenmsg to request link info

On Tue, Jul 04, 2017 at 04:32:49PM +0800, Hangbin Liu wrote: > But for link status monitor, ifinfomsg.ifi_index doesn't do any help. We still > need to register with groupp RTNLGRP_LINK and keep receive all interfaces' > information. I see. > Back to this question, do you still want to move rtnl

Re: [Linuxptp-devel] [PATCH 1/8] rtnl: use ifinfomsg instead of rtgenmsg to request link info

On Tue, Jul 04, 2017 at 06:32:19PM +0800, Hangbin Liu wrote: > On Tue, Jul 04, 2017 at 11:02:26AM +0200, Richard Cochran wrote: > > > Back to this question, do you still want to move rtnl socket from clock to > > > per port? > > > > Yes, but only if we can

Re: [Linuxptp-devel] Fwd: PHY Hardware Time Stamping

On Tue, Jul 04, 2017 at 09:40:43AM +0200, Imanol Allende wrote: > I connected the board to wireshark and the sync message is sent. Apart from > that, I saw the following post saying that the emaclite driver does not > accept multicast message(which is true) and that it does not work with > ptp4l:

Re: [Linuxptp-devel] [PATCH 1/8] rtnl: use ifinfomsg instead of rtgenmsg to request link info

On Mon, Jul 03, 2017 at 12:27:42PM +0800, Hangbin Liu wrote: > Before v3.7 we do not support create interface with given ifindex with > RTM_NEWLINK message[1]. Since we only need to get the interface info. > It should be safe to use ifinfomsg on kernel v3.0 Okay, then we need to take two steps.

Re: [Linuxptp-devel] [PATCH 1/8] rtnl: use ifinfomsg instead of rtgenmsg to request link info

On Mon, Jul 03, 2017 at 10:28:39AM +0200, Jiri Benc wrote: > On Mon, 3 Jul 2017 09:12:46 +0200, Richard Cochran wrote: > > We can even call uname(2) to check the kernel version when bonding is > > requested in the configuration. > > Please don't do that. Always check for the

Re: [Linuxptp-devel] Wrong Interface

On Fri, Jun 23, 2017 at 11:04:38AM -0400, Amritpal Bains wrote: > > My expectation is that the kernel will choose the interface only when > > 'imr_address' and 'imr_ifindex' are both zero. > > That's also how I first interpreted the documentation. So I see what is happening, but the correct

Re: [Linuxptp-devel] [PATCH 0/8] Add linuxptp bond failover support

On Sat, Jun 24, 2017 at 04:48:28PM +0800, Hangbin Liu wrote: > Since it's a large patch set. I may miss some part. Please let me know if > you have any questions, comments, or concerns. I have only just started to review, but overall the form and structure of the series are okay. I appreciate

Re: [Linuxptp-devel] Workaround for 'timed out while polling for tx timestamp' on IGB

On Thu, Apr 27, 2017 at 03:41:03PM +1000, David Mirabito wrote: > * "Fixing" (if this is indeed a bug) was reasonably straight forward - more > or less reordering steps 4,5,6 so that we wake the app only *after* we've > unlocked the bit. If your analysis was correct, then yes, indeed this is a

Re: [Linuxptp-devel] [PATCH 0/6] Adding peer-to-peer transparent clock

On Thu, Aug 03, 2017 at 09:44:13PM +, Rodney Greenstreet wrote: > The following patches originated from patches authored by Richard Cocharan. > Unfortunately, I was unsuccessful in applying the original set of patches to > the latest master branch. As a result, I generated a new set of patches

Re: [Linuxptp-devel] Adding peer-to-peer transparent clock

On Fri, Aug 04, 2017 at 04:20:15PM +, Keller, Jacob E wrote: > I haven't had time to review the actual implementation in detail, but I did > have a few nits, and the commit subjects should probably be reworded a bit. > Thanks for the effort in bringing these patches forward though! Let's

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Sat, Jul 15, 2017 at 09:33:06PM +0800, Hangbin Liu wrote: > +static int rtnl_rtattr_parse(struct rtattr *tb[], int max, struct rtattr > *rta, int len) > +{ > + unsigned short type; > + > + memset(tb, 0, sizeof(struct rtattr *) * (max + 1)); This (max + 1) usage and ... > + while

Re: [Linuxptp-devel] [PATCHv2 8/9] transport: pass struct interface to transport_open

On Sat, Jul 15, 2017 at 09:33:10PM +0800, Hangbin Liu wrote: > Pass struct interface so we can use ts_iface in HW filter. So the problem is that the raw layer should use name = iface->ts_iface but the others need name = iface->name Let's avoid touching so many files by solving

Re: [Linuxptp-devel] [PATCHv2 1/9] config: add new element ts_iface in struct interface

On Sat, Jul 15, 2017 at 09:33:03PM +0800, Hangbin Liu wrote: > Add new element ts_iface in struct interface to track real ts interface. > > Signed-off-by: Hangbin Liu > --- > config.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config.h b/config.h > index

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Sat, Jul 15, 2017 at 09:33:06PM +0800, Hangbin Liu wrote: > @@ -92,6 +151,18 @@ int rtnl_link_status(int fd, rtnl_callback cb, void *ctx) > struct msghdr msg; > struct nlmsghdr *nh; > struct ifinfomsg *info = NULL; > + char *device; > + struct rtattr *tb[IFLA_MAX+1]; >

Re: [Linuxptp-devel] [PATCHv2 3/9] rtnl: update rtgenmsg to ifinfomsg when request link info

On Sat, Jul 15, 2017 at 09:33:05PM +0800, Hangbin Liu wrote: > diff --git a/rtnl.h b/rtnl.h > index f1871f2..b4db40e 100644 > --- a/rtnl.h > +++ b/rtnl.h > @@ -31,10 +31,11 @@ int rtnl_close(int fd); > > /** > * Request the link status from the kernel. > - * @param fd A socket obtained via

Re: [Linuxptp-devel] [PATCHv2 3/9] rtnl: update rtgenmsg to ifinfomsg when request link info

On Sat, Jul 15, 2017 at 09:33:05PM +0800, Hangbin Liu wrote: > diff --git a/port.c b/port.c > index 849a7c1..21ab3ea 100644 > --- a/port.c > +++ b/port.c > @@ -1512,7 +1512,7 @@ static int port_initialize(struct port *p) > if (p->fda.fd[FD_RTNL] == -1) >

Re: [Linuxptp-devel] [PATCHv2 6/9] clock: check required_modes before use new ts info

On Sat, Jul 15, 2017 at 09:33:08PM +0800, Hangbin Liu wrote: > diff --git a/clock.h b/clock.h > index 49ecb76..18d7250 100644 > --- a/clock.h > +++ b/clock.h > @@ -73,6 +73,13 @@ UInteger8 clock_class(struct clock *c); > struct config *clock_config(struct clock *c); > > /** > + * Obtains the

Re: [Linuxptp-devel] [PATCHv2 7/9] port.c: fix port_dispatch event flood when change ts_iface info

On Sat, Jul 15, 2017 at 09:33:09PM +0800, Hangbin Liu wrote: > When bond active slave interface changed. We will receive multi rtnl > messages, i.e. bond and slave interfaces status changing information. > > No matter what's the iface index of the rtnl messages, it will trigger > FD_RTNL event.

Re: [Linuxptp-devel] [PATCHv2 8/9] transport: pass struct interface to transport_open

On Wed, Aug 09, 2017 at 11:45:30AM +0800, Hangbin Liu wrote: > We need ts_iface in sk_timestamping_init. e.g. Ok, I overlooked that. I take my comment back. Thanks, Richard -- Check out the vibrant tech community on

Re: [Linuxptp-devel] [PATCHv2 4/9] rtnl: add function rtnl_link_info

On Tue, Aug 08, 2017 at 06:16:37PM +0800, Hangbin Liu wrote: > The goal of this call path is to call port_link_status() whenever link status > changed. And the call path should like > > 1. port_event() -> rtnl_link_status() -> port_link_status() > > > 2. clock_create() -> rtnl_link_info() ->

Re: [Linuxptp-devel] [PATCH 0/6] Adding peer-to-peer transparent clock

On Mon, Aug 07, 2017 at 06:35:46PM +, Rodney Greenstreet wrote: > Should I submit patches relative to the ‘tcng7’ branch? Yes. The p2p-tc code isn't ready for merging yet, but it can serve as a basis for your TAB work. Feel free to test and improve the p2p-tc code itself, too. Thanks,

Re: [Linuxptp-devel] [PATCH] ptp4l: Add IPoIB interface support for ptp4l

Sorry for the long wait on feedback. This patchs looks okay, but I do have a few nits to pick... On Mon, Jul 24, 2017 at 05:07:46PM +0300, Feras Daoud wrote: > diff --git a/raw.c b/raw.c > index 73e45b45bd25..559c93315154 100644 > --- a/raw.c > +++ b/raw.c > @@ -220,7 +220,7 @@ static int

Re: [Linuxptp-devel] [PATCH] ptp4l: Add IPoIB interface support for ptp4l

On Mon, Jul 24, 2017 at 05:07:46PM +0300, Feras Daoud wrote: > In Infiniband, every interface has three identifiers: > GUID, GID, and LID. > The GUID is similar in concept to a MAC address. From RFC4392: > The EUI-64 portion of a GID is referred to as the Global Unique > Identifier (GUID) and is

Re: [Linuxptp-devel] [PATCH] ptp4l: Add IPoIB interface support for ptp4l

On Mon, Aug 07, 2017 at 05:25:18PM +0300, Feras Daoud wrote: > Right, SIOCGIFHWADDR ioctl call returns the 14 msb bytes of the device > address. > In our case, the GUID is the 6 lsb bytes of the 20 byte device address, so > it is not possible > to get the GUID using SIOCGIFHWADDR ioctl call. Ok.

Re: [Linuxptp-devel] [PATCH 0/6] Adding peer-to-peer transparent clock

Rodney, On Fri, Aug 04, 2017 at 09:15:14PM +0200, Richard Cochran wrote: > I am going to make this a bit easier for you and rebase the original > series onto the current git head. Then, you can concentrate on > expanding on them. Please clone the 'tcng7' branch from: https://g

[Linuxptp-devel] [PATCH RFC 00/11] ITU G.8275 Telecom Profile

protocol telecom profile for frequency synchronization Comments and review are most welcome. Thanks, Richard Richard Cochran (11): port: Make the data set comparison algorithm into a function variable. clock: Make the data set comparison algorithm into a function variable. bmc: Allow

[Linuxptp-devel] [PATCH RFC 06/11] telecom: Add the data set comparison algorithm from the Telecom Profile.

The first half of the telecom algorithm differs from the one in 1588, making use of profile specific "localPriority" attributes. Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- bmc.h | 12 +++ makefile | 2 +-

[Linuxptp-devel] [PATCH RFC 07/11] telecom: Add a configuration option for defaultDS.localPriority.

Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- clock.c | 3 ++- config.c| 1 + default.cfg | 1 + gPTP.cfg| 1 + ptp4l.8 | 14 ++ 5 files changed, 19 insertions(+), 1 deletion(-) diff --git a/clock.c b/clock.c index d1dbb86..ac57cb5

[Linuxptp-devel] [PATCH RFC 08/11] telecom: Add a configuration option for portDS.localPriority.

Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- config.c| 1 + default.cfg | 1 + gPTP.cfg| 1 + port.c | 4 +++- ptp4l.8 | 15 +++ 5 files changed, 21 insertions(+), 1 deletion(-) diff --git a/config.c b/config.c index 3d1a752..a87598f

[Linuxptp-devel] [PATCH RFC 10/11] telecom: Introduce the "notSlave" option.

When "notSlave" is true, the port always returns NULL when computing its best foreign master. As a result, the port will never enter the SLAVE state, and the clock will ignore Announce messages received on that port. Signed-off-by: Richard Cochran <richardcoch...@gmail.com> ---

[Linuxptp-devel] [PATCH RFC 09/11] telecom: Add a configuration option to use the alternate BMCA.

Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- bmc.h | 5 + clock.c | 6 +- config.c| 9 + default.cfg | 1 + gPTP.cfg| 1 + port.c | 6 +- 6 files changed, 26 insertions(+), 2 deletions(-) diff --git a/bmc.h b/bmc.h index b

[Linuxptp-devel] [PATCH RFC 11/11] telecom: Add a default configuration for the Telecom Profile.

Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- telecom.cfg | 93 + 1 file changed, 93 insertions(+) create mode 100644 telecom.cfg diff --git a/telecom.cfg b/telecom.cfg new file mode 100644 index 000..2

[Linuxptp-devel] [PATCH RFC 04/11] bmc: Make the second part of the data set comparison algorithm public.

This code will be shared by future alternative algorithms. Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- bmc.c | 7 +-- bmc.h | 11 +++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/bmc.c b/bmc.c index 4b435b2..3c3db82 100644 --- a/bmc.c +++ b

[Linuxptp-devel] [PATCH RFC 05/11] telecom: Introduce the local priority into the data set.

The Telecom Profile invented a new per-port and per-clock attribute, not in 1588, called "localPriority". The use of this attribute is a distinguishing feature of the telecom data set comparison algorithm. This patch adds the attribute, hard coded to its default value. Signed-off-b

[Linuxptp-devel] [PATCH RFC 02/11] clock: Make the data set comparison algorithm into a function variable.

This will allow adding alternative algorithms as defined in PTP profiles. Signed-off-by: Richard Cochran <richardcoch...@gmail.com> --- clock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clock.c b/clock.c index da15882..7049706 100644 --- a/clock.c +++ b/c

Re: [Linuxptp-devel] [PATCH RFC 09/11] telecom: Add a configuration option to use the alternate BMCA.

On Fri, Aug 18, 2017 at 10:59:41PM +0200, Richard Cochran wrote: > offsetScaledLogVariance 0x > free_running 0 > freq_est_interval1 > +dataset_comparison ieee1588 I just realized that I didn't document this option on the man page. That will be fixed in

Re: [Linuxptp-devel] [PATCH 4/4] Improve detection of clock_nanosleep

On Mon, May 15, 2017 at 10:17:54AM +0200, Petr Kulhavy wrote: > On some platforms compilation issues due to clock_nanosleep were occuring. The > simple test for __uClinux__ was not sufficient. > > Implement full detection of clock_nanosleep in incdefs.h by compiling a short > C > file.

Re: [Linuxptp-devel] [PATCH 1/4] Add missing time.h header

On Mon, May 15, 2017 at 10:17:51AM +0200, Petr Kulhavy wrote: > On some targets the time_t structure was missing and the compilation was > failing. > > Signed-off-by: Petr Kulhavy > --- > util.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util.h b/util.h > index

Re: [Linuxptp-devel] [PATCH 2/4] Remove conflicting netinet/ether.h

On Mon, May 15, 2017 at 10:17:52AM +0200, Petr Kulhavy wrote: > On some platforms like br-arm-cortex-a9-musl struct ethhdr was defined twice > due to including of both linux/if_ether.h and netinet/ether.h. Which lead > to a compilation error. > > Remove netinet/ether.h as the official header for

Re: [Linuxptp-devel] [PATCH 3/4] Fix detection of clock_adjtime

On Mon, May 15, 2017 at 10:17:53AM +0200, Petr Kulhavy wrote: > On some platforms clock_adjtime is defined in timex.h instead of time.h > Due to this fact the detection in incdefs.h was failing. > Add timex.h into the list of searched files. > > Signed-off-by: Petr Kulhavy

Re: [Linuxptp-devel] [PATCH] msg: use last_tlv if there is not enough room for another tlv

On Fri, May 12, 2017 at 03:36:45PM +0800, Hangbin Liu wrote: > If the len is not enought for another tlv process. e.g. one more bytes > padding at the end of message. And we set extra to NULL instead of > msg->last_tlv in tlv_post_recv(). Then the msg->last_tlv will not be > initialised. And

Re: [Linuxptp-devel] Implement bond/team fail over support

On Thu, Jun 08, 2017 at 04:50:27PM +0800, Hangbin Liu wrote: > Do you have any comments? I was waiting for Miroslav to comment first ;) He did suggest something some time ago. I have not yet thought much about bonding, and so I not yet ready to give an opinion... Thanks, Richard

Re: [Linuxptp-devel] Wrong Interface

On Thu, Jun 22, 2017 at 04:59:04PM -0400, Amritpal Bains wrote: > The problem did NOT occur when the IP addresses were static or we were > using a dhcp server. It only occurred when we were connected using ZeroConf. Is multicast enabled on the interface, when using zeroconf? > The exact command

Re: [Linuxptp-devel] [PATCH] phc2sys: free clock device when exit

On Thu, Jun 22, 2017 at 10:36:33PM +0800, Hangbin Liu wrote: > +static void clock_destroy(struct node *node) Can't we name this differently? We already have a function called clock_destroy in clock.c. Yes, I know that that is not linked into phc2sys, but for the sake of grep and cscope we want

Re: [Linuxptp-devel] [PATCH 4/4] Improve detection of clock_nanosleep

On Mon, May 22, 2017 at 11:05:39PM +0200, Petr Kulhavy wrote: > I can't find any rational argument against test-compiling a piece of code in > that negatively loaded emotional outburst you referred to. you still have to do the hard work and figure out the right way to explain to the

Re: [Linuxptp-devel] [PATCH 4/4] Improve detection of clock_nanosleep

On Mon, May 22, 2017 at 11:05:39PM +0200, Petr Kulhavy wrote: > If you don't like it, please take my email just as a bugreport: linuxptp > fails to build with uclibc, details in my previous emails. Let me fix that for you: bugreport: Improperly configured uClibc lacks clock_nanosleep. > I don't

Re: [Linuxptp-devel] [PATCH 4/4] Improve detection of clock_nanosleep

On Mon, May 22, 2017 at 12:09:06AM +0200, Petr Kulhavy wrote: > I'm not a uclibc expert, so I can't answer under what conditions > clock_nanosleep is defined. TYou would need to ask the uclibc authors. And just who might they be? If you want this to work on uClibc, then *you* could ask them! >

Re: [Linuxptp-devel] [PATCH] phc2sys: fix maybe uninitialized warnings

On Sun, May 21, 2017 at 10:32:10PM +0200, Petr Kulhavy wrote: > Fix "may be used uninitialized in this function" warnings for state and > timestamping. Please tell us more: What gcc version produces this warning? Is the warning a false positive or not? > @@ -1037,7 +1037,7 @@ static int

Re: [Linuxptp-devel] [PATCH 4/4] Improve detection of clock_nanosleep

On Mon, May 15, 2017 at 11:37:05PM +0200, Petr Kulhavy wrote: > However it is too weak. On some targets clock_nanosleep is defined > conditionally in #if preprocessor directives. > There is no way to detect that with grep. Is this a configuration option for uClibc? If so, then correct solution

Re: [Linuxptp-devel] [PATCH 1/2] pmc: optimize duplicated code in do_set_action()

On Wed, May 17, 2017 at 03:58:39PM +0200, Petr Kulhavy wrote: > TLV_PRIORITY1 and TLV_PRIORITY2 cases in do_set_action() use the same repeated > piece of generic code for setting one-value parameter. Remove the duplicated > code and let both cases use the same code. > > Signed-off-by: Petr

Re: [Linuxptp-devel] [PATCH 2/2] Implement SET method for DOMAIN

On Sun, May 21, 2017 at 10:02:06PM +0200, Richard Cochran wrote: > On Wed, May 17, 2017 at 04:08:53PM +0200, Miroslav Lichvar wrote: > > Shouldn't this also reset the state of the clock? Thinking out loud, the cleanest way might be to introduce a new fault type called "r

Re: [Linuxptp-devel] [PATCH] clock: fix possible buffer overrun

On Tue, May 16, 2017 at 09:58:19PM +0200, Petr Kulhavy wrote: > Did I miss something? What is the reason then? Never mind, this is snprintf() and not strncpy(). The original code was confused and misleading using 31 (but not really incorrect either). Thanks, Richard

Re: [Linuxptp-devel] [PATCH] clock: fix possible buffer overrun

On Tue, May 16, 2017 at 04:56:48PM +0200, Petr Kulhavy wrote: > This is not a fix of an actual issue rather than prevention of a potential > issue. No, your patch introduces an issue that wasn't there before. > @@ -1589,7 +1589,7 @@ int clock_switch_phc(struct clock *c, int phc_index) >

Re: [Linuxptp-devel] [PATCH 0/1] Fix build when using uClinux.

On Tue, May 30, 2017 at 08:37:39AM +0200, Richard Cochran wrote: > diff --git a/package/linuxptp/linuxptp.mk b/package/linuxptp/linuxptp.mk > new file mode 100644 > index 0..44f56f98d > --- /dev/null > +++ b/package/linuxptp/linuxptp.mk

[Linuxptp-devel] [PATCH 0/1] Fix build when using uClinux.

- the DEVELOPERS hunk (which no longer applies, fix is trivial) - the patches for linuxptp, no longer necessary - the broken LINUXPTP_INSTALL_INIT_SYSV macro Richard Cochran (1): Fix build when using uClinux. missing.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) ---8

Re: [Linuxptp-devel] [PATCH 4/4] Improve detection of clock_nanosleep

On Tue, May 23, 2017 at 11:43:57AM +0200, Petr Kulhavy wrote: > I'm not sure that you fully understand the problem. It seems there are > currently four scenarios possible. Yeah, I get that. Your task then would have been to address the four possibilities. > Now the question is how to handle

[Linuxptp-devel] [PATCH 1/1] Fix build when using uClinux.

From: Richard Cochran <rcoch...@linutronix.de> Unfortunately uClinux is rather inconsistent with respect to clock_nanosleep(). Older versions of uclibc lack that function, while newer versions may include the declaration but still lack the definition, depending on whether pthreads are se

Re: [Linuxptp-devel] [PATCH 1/3] Added support for IEEE 802.1AS 2011 bridges.

On Wed, Jun 07, 2017 at 06:11:42PM +0200, Richard Cochran wrote: > On Wed, Jun 07, 2017 at 02:46:39PM +, Rodney Greenstreet wrote: > > Based on these clauses, it’s clear that each port maintains its own > > sync interval setting and needs to maintain its own sync interval >

Re: [Linuxptp-devel] [PATCH 1/3] Added support for IEEE 802.1AS 2011 bridges.

On Wed, Jun 07, 2017 at 02:46:39PM +, Rodney Greenstreet wrote: > Thank you for your feedback. I want to explain why we chose to add TAB to > your BC implementation rather than adding a new type of device. A TAB is > mathematically equivalent to a TC but is functionally equivalent to a BC.

Re: [Linuxptp-devel] [PATCH 1/3] Added support for IEEE 802.1AS 2011 bridges.

On Wed, Jun 07, 2017 at 04:24:52PM +, Rodney Greenstreet wrote: > Please read clause 10.6.2.3 ‘time-synchronization event message transmission > interval’ and clause 10.6.2.4 ‘Interval for providing synchronization > information > by ClockMaster entity’. The last clause makes it very clear

Re: [Linuxptp-devel] [PATCH 1/3] Added support for IEEE 802.1AS 2011 bridges.

On Wed, Jun 07, 2017 at 04:51:03PM +, Rodney Greenstreet wrote: > Please review this state machine again. The syncInterval is used to govern > the transition back to the ‘SEND_MD_SYNC’ state. This transition only occurs > if the the syncInterval has elapsed and the received Sync message is not

Re: [Linuxptp-devel] [PATCH 1/3] Added support for IEEE 802.1AS 2011 bridges.

On Wed, Jun 07, 2017 at 06:20:40PM +, Rodney Greenstreet wrote: > I think this SM is optimized for behaving as you suggest, with the > assumption all sync intervals are the same. However, a port’s > syncInterval, or some fraction of it, must be adhered to. Also, if a > Sync event is not

Re: [Linuxptp-devel] Implement bond/team fail over support

On Thu, Jun 08, 2017 at 03:50:13PM +0200, Miroslav Lichvar wrote: > What Hangbin is suggesting is different in that most of the work is > done in ptp4l and there are no or only minimal changes needed in the > kernel and phc2sys. ptp4l would use the master interface for > networking and slave

Re: [Linuxptp-devel] Implement bond/team fail over support

On Thu, Jun 08, 2017 at 03:50:13PM +0200, Miroslav Lichvar wrote: > The question is if you would be ok with bonding/teaming-specific code > in ptp4l and if you have any suggestions on the design. Should there > be only one port, or should each slave interface has its own port? There should be

Re: [Linuxptp-devel] Implement bond/team fail over support

Hangbin Finally getting back to this... On Tue, Jun 06, 2017 at 06:22:28PM +0800, Hangbin Liu wrote: > Now more and more customers are asking for linuxptp bond/team fail over > support. > I have a draft plan to implement this feature. Would you like to help review > it > to see if it's OK or

Re: [Linuxptp-devel] patches for RHEL 6.6, discussed on linuxptp-users

On Thu, Jun 15, 2017 at 10:16:43AM -0600, Brian Olson wrote: > Miroslav Lichvar suggested that I submit these changes to linuxptp-devel. Can you please resubmit those as two separate emails (not as attachments), adding a SOB line. See the file, README.org, under "Submitting Patches". > In file

Re: [Linuxptp-devel] [PATCH 2/2] added workaround for ticks being returned as zero from 2.6.32 kernel.

On Fri, Jun 16, 2017 at 12:58:33PM -0400, Brian Olson wrote: > --- > clockadj.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied. Thanks, Richard -- Check out the vibrant tech community on one of

Re: [Linuxptp-devel] [PATCH 1/2] fixed include order to work around issue on RHEL 6.6

On Fri, Jun 16, 2017 at 12:58:32PM -0400, Brian Olson wrote: > --- > rtnl.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, fixing up the SOB and adding a comment so as not to forget the ordering requirements. Thanks, Richard

Re: [Linuxptp-devel] [PATCH v2] phc2sys: Add described device to stats output

On Fri, Jun 16, 2017 at 03:07:19PM -0700, Cliff Spradlin via Linuxptp-devel wrote: > When phc2sys synced more than one ethernet interface, such as in a JBOD > boundary clock arrangement, it was unclear which interface a line of > statistics > referred to. Applied. Thanks, Richard

Re: [Linuxptp-devel] Implement bond/team fail over support

On Mon, Jun 19, 2017 at 10:55:21AM +0800, Hangbin Liu wrote: > > >struct interface { > > >STAILQ_ENTRY(interface) list; > > >char name[MAX_IFNAME_SIZE + 1]; > > >char slave[MAX_IFNAME_SIZE + 1]; > > >int index; > > >int slave_index; >

Re: [Linuxptp-devel] Implement bond/team fail over support

On Mon, Jun 19, 2017 at 03:35:16PM +0800, Hangbin Liu wrote: > But other device actions will also trigger a rtnl notification, i.e. mtu > change. > So we need to make sure the slave actually changed before reset clock/port. Fair enough, but that requires only one additional variable per port.

Re: [Linuxptp-devel] Implement bond/team fail over support

On Mon, Jun 19, 2017 at 02:56:00PM +0800, Hangbin Liu wrote: > Then how do we know the slave changed. Cause via netlink rta > IFLA_BOND_ACTIVE_SLAVE, we only know the current active slave. If we do not > store previous slave name/index some where and compare with current value. > How do we know

Re: [Linuxptp-devel] [PATCH 2/2] util: Fix unknown time_t types with musl-libc builds

On Sun, May 07, 2017 at 02:44:14PM -0700, Florian Fainelli wrote: > Fixes the following build errors seen with musl-libc: > > In file included from print.h:25:0, > from linreg.c:24: > util.h:364:32: error: unknown type name 'time_t' > int rate_limited(int interval, time_t

<    1   2   3   4   5   6   7   8   9   10   >