This will allow adding alternative algorithms as defined in PTP profiles.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/port.c b/port.c
index 454c60d..627fbb2 100644
--- a/port.c
+++ b/port.c
@@
This patch places the internal port data structure into a common header
for use by the original BC and the new TC code.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c | 97 +---
port_private.h
This patch makes a number of subroutines into global functions in order
to share code with the TC implementations to come.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c | 44 +---
port_private.
This will allow adding alternative algorithms as defined in PTP profiles.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
clock.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/clock.c b/clock.c
index 97f1188..9f0d3be 100644
--- a/clock.c
+++ b/c
On Wed, Mar 21, 2018 at 08:24:24PM +0100, Anders Selhammer wrote:
> In a ptp unaware network (like the telecom profile for frequency sync
> G.8265.1), both the RTD and the PDV can be substantially higher than
> in a ptp aware network. To achieve more accurate measurements, the
> rate may need to
On Mon, Mar 26, 2018 at 11:55:37AM +, Jesuiter, Henry (ALC NetworX GmbH)
wrote:
> Setup (kind of abnormal, as state in IEEE 1588-2008 ):
> - Boundary Clock
> - 2 Ports into the same subnet
May I ask why you placed two ports into the same network? Is that
supposed to be some kind of
On Thu, Mar 22, 2018 at 12:28:34AM +0100, Peter Schneider wrote:
> +Be cautious when the same configuration file is used for both ptp4l and pmc.
> +Keep in mind, that values specified in the configuration file take precedence
> +over their default values. If a certain option, which is common to
On Fri, Mar 23, 2018 at 01:24:35PM +0100, Peter Schneider wrote:
> @@ -1477,6 +1482,10 @@ int main(int argc, char *argv[])
> }
> }
>
> + if (config && (c = config_read(config, cfg))) {
> + return c;
> + }
> +
This is not quite right. I noticed that some
ended TLVs.
Note that the stack does not currently trigger this latent bug because
only single TLVs are appended.
Fixes: 4a8877f90462 ("msg: Introduce method for appending multiple TLVs on
transmit.")
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 2 ++
1
On Fri, Mar 16, 2018 at 09:37:59AM +0100, Frantisek Rysanek wrote:
> let me just briefly follow up on the past thread on "TX timestamp
> timeouts". To sum up: on the my part the problem seems gone.
...
> On tuesday I had another chance to try PTP against the TC switch at a
> substation with
On Mon, Mar 12, 2018 at 12:36:26PM +, Michael Brown wrote:
> This is a revised patch series to ensure that the tmv_t operations are
> used consistently for calculations involving hardware timestamps.
Series applied.
Thanks,
Richard
On Thu, Mar 15, 2018 at 12:00:27PM +0100, Anders Selhammer wrote:
> This patch will remove all delay requests in queue that is older than the
> latest processed. Connected responses to these are either much more delayed
> or lost. Any received response derived from an obsolete request will be
>
On Tue, Mar 20, 2018 at 08:21:09AM +, Anders Selhammer wrote:
> One thing that I might overseen is the growing part. I covered that
> some packets might be lost but if all delay resp are lost by some
> reason it might be good to have some kind of a limit of how many
> delay req the stack
On Thu, Mar 15, 2018 at 12:00:28PM +0100, Anders Selhammer wrote:
> We always but braces around 'if' blocks.
Please put any clean-up patches first in the series.
Thanks,
Richard
--
Check out the vibrant tech community
On Thu, Mar 15, 2018 at 12:00:27PM +0100, Anders Selhammer wrote:
> This patch will remove all delay requests in queue that is older than the
> latest processed. Connected responses to these are either much more delayed
> or lost. Any received response derived from an obsolete request will be
>
On Thu, Mar 15, 2018 at 12:00:27PM +0100, Anders Selhammer wrote:
> @@ -1830,7 +1830,7 @@ out:
> static void process_delay_resp(struct port *p, struct ptp_message *m)
> {
> struct delay_resp_msg *rsp = >delay_resp;
> - struct ptp_message *req;
> + struct ptp_message *req, *obs;
On Thu, Mar 15, 2018 at 12:00:26PM +0100, Anders Selhammer wrote:
> In a ptp unaware network (like the telecom profile for frequency sync
> G.8265.1), both the RTD and the PDV can be substantially higher than in a ptp
> aware network. To achieve more accurate measurements, the rate may need to
On Fri, Mar 16, 2018 at 07:31:04PM +0100, Peter Schneider wrote:
> diff --git a/pmc_common.c b/pmc_common.c
> index 91fffb3..850544c 100644
> --- a/pmc_common.c
> +++ b/pmc_common.c
> @@ -93,6 +93,10 @@ struct pmc *pmc_create(struct config *cfg, enum
> transport_type transport_type,
> }
>
On Thu, Mar 15, 2018 at 10:42:22PM +, Michael Brown wrote:
> Any comments for this patch series? Are you happy with the general approach
> to use tmv_t within struct hw_timestamp?
For my part it is just -ENOSPARECYCLES. I'll get to it eventually...
Sorry,
Richard
On Fri, Mar 16, 2018 at 06:53:13PM -0700, Richard Cochran wrote:
> For my part it is just -ENOSPARECYCLES. I'll get to it eventually...
I just scanned throught the series. Looks really good. Thanks for
avoiding the "ugly" functions, and the "early conversion" to tmv
On Tue, Mar 20, 2018 at 11:04:00PM +0100, Anders Selhammer wrote:
> In a ptp unaware network (like the telecom profile for frequency sync
> G.8265.1), both the RTD and the PDV can be substantially higher than
> in a ptp aware network. To achieve more accurate measurements, the
> rate may need to
in order to accommodate the exceptional case.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 3 ---
port.c | 10 ++
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/msg.c b/msg.c
index a36d4d0..616d937 100644
--- a/msg.c
+++ b/msg.c
@@ -390,9 +390,6
the "time_stamping" option. The "twoStepFlag" is adjusted
automatically if needed. The legacy behavior for Sync message one
step is preserved.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
clock.c | 42 +--
The 1588 standard defines one step operation for both Sync and
PDelay_Resp messages. Up until now, hardware with P2P one step has
been rare, and kernel support was lacking. This patch adds support of
the mode in anticipation of new kernel and hardware developments.
Signed-off-by: Richard
the egress time stamp into the correction field.
I am posting kernel support as an RFC on the netdev list today.
As always, comments and review are most welcome.
Thanks,
Richard
Richard Cochran (3):
msg: Move the check for missing HW time stamps into caller.
Introduce peer to peer one step
On Tue, Mar 20, 2018 at 11:04:02PM +0100, Anders Selhammer wrote:
> @@ -146,6 +146,7 @@ struct port {
> static int port_capable(struct port *p);
> static int port_is_ieee8021as(struct port *p);
> static void port_nrate_initialize(struct port *p);
> +static void flush_delay_req(struct port *p);
On Fri, Mar 23, 2018 at 11:03:50AM -0500, Alex Fontaine wrote:
> The kernel documentation states the ability to use POSIX timers with the PTP
> hardware clocks. This does not appear to be implemented in the ptp
> subsystem drivers. What is preventing this timer interface from being
>
On Fri, Mar 23, 2018 at 11:26:29AM -0500, Alex Fontaine wrote:
> The PTP subsystem only allows one pin to be mapped to one channel for
> periodic outputs. Why does the ptp subsystem force only allowing one pin
> index to one a periodic output channel?
Because this has been sufficient up until
Peter,
The patches are better WRT white space, but now some of the long lines
have been wrapped by the mailer, apparently...
On Sun, Mar 18, 2018 at 06:38:25PM +0100, Peter Schneider wrote:
> +.SH LONG OPTIONS
> +
> +Each and every configuration file option (see below in sections
> +.BR PROGRAM\
On Fri, Mar 23, 2018 at 05:00:18PM +, Keller, Jacob E wrote:
> > The PTP subsystem only allows one pin to be mapped to one channel for
> > periodic
> > outputs. Why does the ptp subsystem force only allowing one pin index to
> > one a
> > periodic output channel? It seems like a common use
The NetSync Monitor protocol will require us to report the time stamp of
the last synchronization. This patch adds new the method.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
clock.c | 5 +
clock.h | 7 +++
2 files changed, 12 insertions(+)
diff --git a/clo
to
work fine. Maybe there is a timing issue in 20-pmc?
* Changes in V2:
- simplified API
- fixed bugs
* Where is V1?
- blocked by SF as spam
Richard Cochran (10):
tlv: Implement a memory pool for TLV descriptors.
msg: Introduce a TLV list.
msg: Populate the TLV list on receive
(reposting this, because SF block me as a spammer!)
On Tue, Feb 27, 2018 at 01:19:35PM -0500, Joey DiGiorgio wrote:
> I tried commenting that section out in missing.h, but I was thinking
> it should already be handled by the #ifndef
Right.
> and I've been having
> issues getting Linux PTP
This patch adds a new "NSM" program. The new code handles only one
outstanding NSM command at a time. If and when all four event time
stamps have arrived, the code prints the instantaneous estimated
offset without any averaging or smoothing.
Signed-off-by: Richard Cochran &l
We always but braces around 'if' blocks.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/port.c b/port.c
index 263638c..2ee3ac6 100644
--- a/port.c
+++ b/port.c
@@ -2426,8 +2426,9
offset.
The details of the protocol are described in a brief PDF published by
Meinberg. If anyone would like a copy, please contact me off list.
* Changes in V2:
- rebased to use the multiple TLV API
- the NSM client is now its own program, not a part of pmc
Richard Cochran (11):
msg: Allow
All users have been converted to the TLV list, so remove the field.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 1 -
msg.h | 6 --
2 files changed, 7 deletions(-)
diff --git a/msg.c b/msg.c
index 348b7b5..8bc14f8 100644
--- a/msg.c
+++ b/msg.c
@@ -462,7
The third parameter of the function, pmc_send(), is never used. This patch
removes it.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
pmc_common.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/pmc_common.c b/pmc_common.c
index 4ece489..91fffb3
Valgrind is nagging us, saying we pass uninitialized data through a
setsockopt() call. This patch fixes the issue by clearing the entire
passed structure.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
raw.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/raw.c b/raw.c
When NSM is enabled on a given port, that port always replies to a NSM
delay request with a delay response, sync, and follow up, regardless
of the current state of the port.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c
The code uses a local variable for program flow control in a silly way.
This patch simplifies the logic by using the common switch/case/default
pattern instead.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
clock.c | 38 +-
1 file chang
---
clock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/clock.c b/clock.c
index 069795a..427ca6c 100644
--- a/clock.c
+++ b/clock.c
@@ -335,11 +335,11 @@ static int clock_management_fill_response(struct clock
*c, struct port *p,
I've been working on multiple TLV support, and I rebased the NSM
series on top of that. Along the way I made a number of minor fixes.
This series collects them all together.
Richard Cochran (10):
msg: Share a static global more globally.
raw: Fix valgrind setsockopt warning.
port: Clean up
.
As a result of the this change, the return value for the helper
functions, follow_up_info_append() and path_trace_append(), has
changed meaning. Instead of returning the TLV length, these functions
now provide an error code.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.
We indent with tabs, not spaces.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
pmc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/pmc.c b/pmc.c
index af9cc63..49282a6 100644
--- a/pmc.c
+++ b/pmc.c
@@ -233,19 +233,19 @@ static void pm
Now that the list is in place and is used on all transmit paths, simply
iterate through the list when converting to network byte order.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 23 ++-
1 file changed, 6 insertions(+), 17 deletions(-)
diff
In order to support multiple TLVs, the transmit code must be able to
append one TLV after another. This patch adds a method that checks
whether there is room, allocates the TLV descriptor, sets the buffer
pointer, and appends the descriptor to the list.
Signed-off-by: Richard Cochran
the one_step() function.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 2 ++
ptp4l.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/msg.c b/msg.c
index 4b3d926..6943431 100644
--- a/msg.c
+++ b/msg.c
@@ -32,6 +32,8 @@
#define VERSION_MASK 0x0f
#
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 3 +++
tlv.c | 32
tlv.h | 21 +
3 files changed, 56 insertions(+)
diff --git a/msg.c b/msg.c
index 6943431..52a59e7 100644
--- a/msg.c
+++ b/msg.c
@@ -213,6 +213,9 @
Re-arrange local variables into a more legible reverse Christmas tree.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/port.c b/port.c
index 6cc5dd0..76af2ae 100644
--- a/port.c
+++ b/
We are programming C, not Java, and so opening braces of a function
belong on a line all by themselves.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
tlv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tlv.c b/tlv.c
index cef10a0..a5c2eb3
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
config.c| 1 +
default.cfg | 1 +
gPTP.cfg| 1 +
port.c | 1 +
ptp4l.8 | 12 +++-
5 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/config.c b/config.c
index 56d1556..ba035ac
The NetSync Monitor protocol features a TLV with a length of zero.
Our input message parsing assumes that every TLV will have some sort
of payload, and up until now this was true. This patch adjusts the
parsing code to accept TLVs of length zero.
Signed-off-by: Richard Cochran <richardc
The file, pmc.c, contains utility functions for printing out a port address
structure. We will want to call these functions from pmc_common.c, and so
this patch moves the utility functions where they belong.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
pmc.c
The code uses a local variable for program flow control in a silly way.
This patch simplifies the logic by using the common switch/case/default
pattern instead.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
port.c | 35 ++-
1 file chang
nce =
htons(pds->grandmasterClockQuality.offsetScaledLogVariance);
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
tlv.c | 138 ++
tlv.h | 18 +
2 files changed, 156 insertions(+)
diff --git a/t
As part of the NetSync Monitor protocol, the port will need to have
access to the current data set. This patch adds the appropriate
function.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
clock.c | 5 +
clock.h | 7 +++
2 files changed, 12 insertions(+)
diff
This will be needed in order to support the NetSync Monitor protocol.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 3 ++-
msg.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/msg.c b/msg.c
index 9038616..a36d4d0 100644
--- a/msg.c
+++ b
This will be needed in order to generate a TLV for the NSM protocol.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
tmv.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tmv.h b/tmv.h
index 30b41ee..5d1e12b 100644
--- a/tmv.h
+++ b/tmv.h
@@ -96,6
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
pmc_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/pmc_common.c b/pmc_common.c
index 447cf99..c1b0d3e 100644
--- a/pmc_common.c
+++ b/pmc_common.c
@@ -314,6 +314,7 @@ struct ptp_message *pmc_recv(struct pm
In order to support multiple TLVs per message, a list is needed.
This patch adds the list to the message structure. This list will
eventually replace the 'last_tlv' field.
Signed-off-by: Richard Cochran <richardcoch...@gmail.com>
---
msg.c | 16
msg.h | 5 +
2
On Fri, Mar 02, 2018 at 05:22:50PM +0100, Miroslav Lichvar wrote:
> The problem seems to be in ptp4l using multiple interfaces. There was
> a bug in the test that pmc was using a wrong interface. That should be
> fixed now.
Thanks. Now my CI script gives the series an okay:
#!/bin/sh
On Mon, Mar 05, 2018 at 12:41:56PM +, Anders Selhammer wrote:
> We are programming C, not Java, and so opening braces of a function belong on
> a line all by themselves.
And they all are. Where is the problem?
> +static void extract_address(struct ptp_message *m, struct PortAddress
>
On Thu, Feb 15, 2018 at 12:48:39PM +0100, Miroslav Lichvar wrote:
> This option allows the clock to be updated before the path delay is
> measured in order to speed up the initial correction of the clock, e.g.
> in domains using a very long logMinDelayReqInterval.
Applied.
Thanks,
Richard
On Thu, Feb 15, 2018 at 12:48:37PM +0100, Miroslav Lichvar wrote:
> When a network interface doesn't support the most specific PTP filter
> (e.g. it can timestamp either all or no received packets), it is
> expected that the driver will report a different filter than was
> requested. Turn the
On Mon, Feb 19, 2018 at 05:59:23PM +0200, Yan Yankovskyi wrote:
> It seems now that VLAN driver isn't actually used in the system, and we use
> a custom ethernet driver. This driver has skb_tx_timestamp(skb); call in
> it's start_xmit() routine, and I implemented and registered get_ts_info()
>
On Thu, Apr 26, 2018 at 09:09:10AM +0200, Miroslav Lichvar wrote:
> On Fri, Apr 20, 2018 at 11:01:09PM -0700, Richard Cochran wrote:
> >
> > NOTE -- Peer-to-peer clocks are normally used only in a
> > homogeneous system of peer-to-peer clocks. The provisions of
On Mon, Oct 22, 2018 at 07:38:08AM +, Anders Selhammer wrote:
> Two weeks since I send out the series and no comments so far.
>
> Sending out a gentle reminder.
On vacation ATM and can't review until later.
Sorry,
Richard
___
Linuxptp-devel
On Mon, Nov 05, 2018 at 12:00:40PM +0100, Dimitrios Katsaros wrote:
> This patch adds dedicated logic for opening and closing posix clocks.
> We will need this for adding logic to ptp4l for using clocks that
> may not be ptp clocks.
Tell us about the use case, please.
Thanks,
Richard
On Tue, Oct 23, 2018 at 12:09:47PM +, Anders Selhammer wrote:
> Signed-off-by: Anders Selhammer
> ---
> util.c | 17 +++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
Applied.
Thanks,
Richard
___
Linuxptp-devel mailing list
On Fri, Oct 12, 2018 at 04:26:59PM +, Patel, Vedang wrote:
> On Wed, 2018-10-10 at 11:01 +, Anders Selhammer wrote:
> > Correction of fault introduced in "Add BMCA config option."
> >
> > Signed-off-by: Anders Selhammer
> Sorry I missed this in my patches. Thanks for fixing it.
>
>
On Tue, Oct 30, 2018 at 12:26:46PM -0700, Cliff Spradlin via Linuxptp-devel
wrote:
> Change-Id: I64cf1d4e1728c31ced40aff865d66b5b4356560f
> Signed-off-by: Cliff Spradlin
> ---
> nullf.c | 4 ++--
> pi.c| 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
Applied.
Thanks,
Richard
On Tue, Oct 30, 2018 at 02:38:54PM -0700, Cliff Spradlin via Linuxptp-devel
wrote:
> Signed-off-by: Cliff Spradlin
> Change-Id: If0fd08df74e1cf108978266cd77768df4b49fb1f
> ---
> Adds one extra missing header. I use a tool that reports when header
> files are not individually compilable, which
On Wed, Nov 07, 2018 at 04:40:50PM +0100, Dimitrios Katsaros wrote:
> I was instead checking for the clock_gettime syscall. Would that be an
> acceptable solution?
We should check for clock_adjtime() as well.
Thanks,
Richard
___
Linuxptp-devel
On Thu, Nov 08, 2018 at 02:48:10PM +0100, Dimitrios Katsaros wrote:
> Maybe I am missing something, but from what I can see from my demo, I can
> set -S with this patch. Maybe there is something else I am not aware of?
You are right, never mind.
Thanks,
Richard
On Thu, Nov 08, 2018 at 02:09:09PM +0100, Dimitrios Katsaros wrote:
> @@ -1053,6 +1052,14 @@ struct clock *clock_create(enum clock_type type,
> struct config *config,
> return NULL;
> }
> clockadj_init(c->clkid);
> + } else if (phc_device) {
>
On Mon, Nov 12, 2018 at 07:46:11AM +, Anders Selhammer wrote:
> Yes but no. What if you change this while stack is running and ram is
> configured, then you just can set ptp_dst_mac? You need to do some
> reconfiguration, right?
Yes, you to restart in order to pick up the change in
On Mon, Nov 12, 2018 at 07:14:31AM +, Anders Selhammer wrote:
> I use more than one network namespace for the stack yes. Ports in different
> namespace.
This series really needs a cover letter that describes the use case(s)
in some detail. As it stands, we are all wondering, "why would
On Mon, Nov 12, 2018 at 06:42:37AM -0800, Richard Cochran wrote:
> On Mon, Nov 12, 2018 at 07:14:31AM +, Anders Selhammer wrote:
> > I use more than one network namespace for the stack yes. Ports in different
> > namespace.
>
> This series really needs a cover letter t
On Tue, Nov 13, 2018 at 01:16:08PM +0100, Miroslav Lichvar wrote:
> net_tstamp.h in recent kernel versions requires time.h for clockid_t.
Can you tell us which kernel exactly?
(I'll put it into the README.)
Thanks,
Richard
___
Linuxptp-devel mailing
On Tue, Nov 13, 2018 at 05:48:46AM +, Anders Selhammer wrote:
> Yes, thats true. Forgot that I have an own TLV on the side, making it
> possible to change
> settings by reading the configuration file again and change whats needed.
And remember, the TLV can set the MAC address option.
>
On Tue, Nov 06, 2018 at 08:47:47PM +, Patel, Vedang wrote:
> About the criterion, we can check the last 'n' offsets and see if all those
> are below a threshold. If that is true, we can send the signaling message to
> increase the sync interval. Both, the offset threshold and the number of
On Mon, Nov 05, 2018 at 09:24:01PM +, Patel, Vedang wrote:
> Is this series somewhere in you "TODO:" list?
Yes, right at the top for linuxptp -- but not at the global top :(
Hope to have this in before Thanksgiving, or, at the latest,
St. Nicholas' Day...
Sorry,
Richard
On Fri, Oct 05, 2018 at 04:25:06PM -0700, Vedang Patel wrote:
> This commit adds functionality to increase the sync and pdelay request
> intervals once gptp synchronization has been achieved. This is useful
> while running Automotive Profile where the network is usually static.
>
> This is done
On Fri, Oct 05, 2018 at 04:25:07PM -0700, Vedang Patel wrote:
> Add provision to disable delay requests. Designated masters who do not
> need to calculate delay can use this option. This is required by
> Automotive Profile to reduce network load.
>
> Signed-off-by: Vedang Patel
> ---
> config.c
On Wed, Nov 07, 2018 at 03:16:22PM +0100, Dimitrios Katsaros wrote:
> However, there is one issue for this setup to work correctly: fd clock
> support is limited. The kernel does provide the ability to implement your
> own POSIX clocks, but the daemons providing ptp clock support do not have
> the
On Fri, Nov 09, 2018 at 07:41:46AM +, Anders Selhammer wrote:
> Some network operators consider that the PTP messages must never be
> forwarded through PTP-unaware network equipment. The use of the
> non-forwardable multicast address 01-80-C2-00-00-0E guarantees this
> property most of the
On Wed, Oct 03, 2018 at 09:41:45AM -0700, Vedang Patel wrote:
> Changes in v3:
> ~~~
>
> There is only a couple of changes in this version of the series.
>
> - We clear out the SYNC_RX_TIMER in bc_event() only when BMCA == 'noop'.
> - Fix typo in documentation of ignore_source_id.
>
>
On Fri, Sep 14, 2018 at 10:57:30AM +0200, Anders Selhammer wrote:
> Add attribute maxStepsRemoved which is included in IEEE1588-2017 (v2.1)
> It is an optional attribute which can decide if an Announce message is
> considered in the operation of the BMCA or not.
Applied.
Thanks,
Richard
On Fri, Sep 14, 2018 at 11:14:58AM +0200, Anders Selhammer wrote:
> Currently the clockIdentity is generated from the mac address of the first
> interface/port in config file. This patch add the possibility to set it in
> config file.
> The reason is if the stack is restarted with a different set
On Tue, Aug 28, 2018 at 10:05:28PM +0200, Erez Geva wrote:
> Add global option for the hardware time stamp setting.
> The function could:
> Normally set the filters as the PTP daemon require.
> Check that the filters are proper but do not change them.
> Full, set the RX filter to all and the TX
On Tue, Sep 25, 2018 at 06:16:20PM +0200, Miroslav Lichvar wrote:
> Remove > from beginning of lines specified in the *.conf sections in
> order to allow a ptp4l-specific section (e.g. [unicast_master_table]) to
> be included there.
>
> After inserting the lines to the generated ptp4l.conf,
On Tue, Sep 25, 2018 at 06:16:19PM +0200, Miroslav Lichvar wrote:
> Don't postpone processing of a timeout if it is equal to the current
> time. This prevents an infinite loop with a simulated clock.
Applied.
Thanks,
Richard
___
Linuxptp-devel
On Thu, Sep 20, 2018 at 01:18:13PM +0200, Ethel Nilsson wrote:
> Signed-off-by: Ethel Nilsson
> ---
> snmp4lptp.8 | 119
>
> 1 file changed, 119 insertions(+)
> create mode 100644 snmp4lptp.8
Applied.
Thanks,
Richard
On Wed, Sep 26, 2018 at 02:57:32PM -0700, Vedang Patel wrote:
> Changes in v2:
> ~~~
> Following are the major changes in this patchset:
> - Do not use PS_LISTENING as a transitiory state.
> - Explicitly clear out the timer when inhibit_announce is set.
> - Expose asCapable as a config
On Sun, Sep 30, 2018 at 08:00:51PM -0700, Richard Cochran wrote:
> On Wed, Sep 26, 2018 at 02:57:36PM -0700, Vedang Patel wrote:
> > @@ -2472,6 +2480,7 @@ static enum fsm_event bc_event(struct port *p, int
> > fd_index)
> > if (p->best)
> >
On Mon, Sep 17, 2018 at 03:43:01PM +, FUSTE Emmanuel wrote:
> diff --git a/phc.h b/phc.h
> index 154e35e..2fe33c4 100644
> --- a/phc.h
> +++ b/phc.h
The diff does not apply (using git am) to the current master. Can you
please clean it up and re-submit?
Thanks,
Richard
> @@ -21,6 +21,19 @@
On Tue, Oct 02, 2018 at 04:25:32PM +, Patel, Vedang wrote:
> We still need to clear out the timer when the device transitions out of
> slave state for other events like EV_FAULT_DETECTED. So, I think we
> still need to keep it there.
So, IOW, the reset is a special case for the noop-BCMA,
On Mon, Oct 01, 2018 at 05:24:48PM +, Patel, Vedang wrote:
> I will add the comment for clearing the SYNC_RX_TIMER. It is basically
> to clear out the event returned by poll().
But why? Does the original code have a bug? Please explain.
> But, I don't understand how moving the
On Mon, Sep 03, 2018 at 01:49:47PM +0200, Michael Walle wrote:
> It's an implementation detail (in hardware, so I can't do anything about it)
> of the scheduler, that it has to be restarted if there was a clock jump. And
> additionally, if there is no grandmaster anymore, we should stop the
>
901 - 1000 of 2162 matches
Mail list logo
