Re: [Linuxptp-devel] [PATCH 1/3] pmc: long opts / cfg file

[Keller, Jacob E]

> -Original Message-
> From: Peter Schneider [mailto:pe...@psch.de]
> Sent: Sunday, March 18, 2018 10:43 AM
> To: Richard Cochran <richardcoch...@gmail.com>
> Cc: linuxptp-devel@lists.sourceforge.net
> Subject: Re: [Linuxptp-devel] [PATCH 1/3] pmc: long opts / cfg file
> 
> Am 17.03.2018 um 02:51 schrieb Richard Cochran:
> >
> > Patch fails to apply.  You sent 8 spaces where there should be tabs.
> >
> > Please check your mailer/editor/ide settings...
> Sorry about this, thunderbird seems to be not friendly to tabs. I'll
> give Claws Mail a try.
> 
> Kind Regards,
> Peter
> 

Use git send-email to avoid your mailer, rather than attempting to inline the 
patches directly into a mail message.

You should be able to set it up with most emails either directly connecting to 
your local smtp server, or the mail provider you use has an smtp server 
associated.

That will help ensure that you don't need to worry about what your mail client 
might do to mangle patches.

Thanks,
Jake


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Re: [Linuxptp-devel] [PATCH 1/3] pmc: long opts / cfg file

[Richard Cochran]

On Fri, Mar 16, 2018 at 07:31:04PM +0100, Peter Schneider wrote:
> diff --git a/pmc_common.c b/pmc_common.c
> index 91fffb3..850544c 100644
> --- a/pmc_common.c
> +++ b/pmc_common.c
> @@ -93,6 +93,10 @@ struct pmc *pmc_create(struct config *cfg, enum 
> transport_type transport_type,
> }
> 
> strncpy(iface.name, iface_name, MAX_IFNAME_SIZE);
> +   if (transport_type == TRANS_IEEE_802_3) {
> +   strncpy(iface.ts_label, iface_name, MAX_IFNAME_SIZE);
> +   }

Patch fails to apply.  You sent 8 spaces where there should be tabs.

Please check your mailer/editor/ide settings...

Thanks,
Richard

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

[Linuxptp-devel] [PATCH 1/3] pmc: long opts / cfg file

[Peter Schneider]

pmc_common: Preset uninitialized 'iface.ts_label' with
 'iface.name'

pmc_create() calls transport_create(), which sets the open function
for the interface 'iface' to raw_open(), if Layer 2 is used. The
immediate following call of transport_open() calls raw_open(), which
uses the field .ts_label for opening, instead of the field .name
(which is used the other transport layers). Therefore, the
field .name is copied here into the field .ts_label

Signed-off-by: Peter Schneider 
---
 pmc_common.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/pmc_common.c b/pmc_common.c
index 91fffb3..850544c 100644
--- a/pmc_common.c
+++ b/pmc_common.c
@@ -93,6 +93,10 @@ struct pmc *pmc_create(struct config *cfg, enum 
transport_type transport_type,
}

strncpy(iface.name, iface_name, MAX_IFNAME_SIZE);
+   if (transport_type == TRANS_IEEE_802_3) {
+   strncpy(iface.ts_label, iface_name, MAX_IFNAME_SIZE);
+   }
+
if (transport_open(pmc->transport, ,
   >fdarray, TS_SOFTWARE)) {
pr_err("failed to open transport");
-- 
2.14.3

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel