Re: [Linuxptp-devel] [PATCH RFC 14/30] interface: Introduce a method to set the name.

2020-03-05 Thread Jacob Keller
On 3/4/2020 9:06 AM, Richard Cochran wrote: > On Tue, Feb 18, 2020 at 01:07:52PM -0800, Jacob Keller wrote: >> >> Good, the name is marked as constant. Side note, for those interface_* >> functions that don't modify the interface, does it make sense to mark >> them as taking a const interface

Re: [Linuxptp-devel] [PATCH RFC 14/30] interface: Introduce a method to set the name.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 01:07:52PM -0800, Jacob Keller wrote: > > Good, the name is marked as constant. Side note, for those interface_* > functions that don't modify the interface, does it make sense to mark > them as taking a const interface pointer? I have heard C++ people insisting on this,

Re: [Linuxptp-devel] [PATCH RFC 14/30] interface: Introduce a method to set the name.

2020-02-18 Thread Jacob Keller
On 2/11/2020 6:04 AM, Richard Cochran wrote: > The name field of the interface is set in different ways by different > callers. In order to prevent users from open coding the logic that sets > the name, this patch adds an appropriate method. > > Signed-off-by: Richard Cochran Reviewed-by:

[Linuxptp-devel] [PATCH RFC 14/30] interface: Introduce a method to set the name.

2020-02-11 Thread Richard Cochran
The name field of the interface is set in different ways by different callers. In order to prevent users from open coding the logic that sets the name, this patch adds an appropriate method. Signed-off-by: Richard Cochran --- interface.c | 5 + interface.h | 8 +++- 2 files changed, 12