On 3/4/2020 9:13 AM, Richard Cochran wrote:
> On Tue, Feb 18, 2020 at 01:19:09PM -0800, Jacob Keller wrote:
>>> +bool interface_tsinfo_valid(struct interface *iface)
>>> +{
>>> + return iface->ts_info.valid ? true : false;
>>> +}
>>
>> Do you actually need the ternary here? shouldn't
On Tue, Feb 18, 2020 at 01:19:09PM -0800, Jacob Keller wrote:
> > +bool interface_tsinfo_valid(struct interface *iface)
> > +{
> > + return iface->ts_info.valid ? true : false;
> > +}
>
> Do you actually need the ternary here? shouldn't ts_info.valid get
> converted to true or false because we
On 2/11/2020 6:04 AM, Richard Cochran wrote:
> Signed-off-by: Richard Cochran
Reviewed-by: Jacob Keller
> ---
> interface.c | 5 +
> interface.h | 8
> 2 files changed, 13 insertions(+)
>
> diff --git a/interface.c b/interface.c
> index 02f63a0..7a3eddc 100644
> ---
Signed-off-by: Richard Cochran
---
interface.c | 5 +
interface.h | 8
2 files changed, 13 insertions(+)
diff --git a/interface.c b/interface.c
index 02f63a0..7a3eddc 100644
--- a/interface.c
+++ b/interface.c
@@ -42,3 +42,8 @@ void interface_set_name(struct interface *iface, const
