Re: [Linuxptp-devel] [PATCH RFC V5 00/83] New configuration implementation

2015-08-28 Thread Miroslav Lichvar
On Sun, Aug 23, 2015 at 10:05:01PM +0200, Richard Cochran wrote: Changes in V5: - Add a string type - Convert every last option - Lightly refactor the pasring code Awesome! The new code looks good to me. I did some testing and I see no problems. ptp4l/phc2sys/pmc work as expected, valgrind

Re: [Linuxptp-devel] [PATCH RFC V5 00/83] New configuration implementation

2015-08-28 Thread Richard Cochran
On Fri, Aug 28, 2015 at 03:36:23PM +0200, Miroslav Lichvar wrote: The new code looks good to me. I did some testing and I see no problems. ptp4l/phc2sys/pmc work as expected, valgrind reports no errors. Ok, I'll go ahead push this series out. (Then, you can add that UDPv6 option you had

[Linuxptp-devel] [PATCH RFC V5 00/83] New configuration implementation

2015-08-23 Thread Richard Cochran
Changes in V5: - Add a string type - Convert every last option - Lightly refactor the pasring code Changes in V4: - Added missing calls to config_get_double() for: pi_integral_exponent pi_integral_norm_max pi_integral_scale pi_proportional_exponent pi_proportional_norm_max Changes in