Re: [Linuxptp-devel] [PATCH v3 4/5] phc_ctl: Use pr_notice instead of pr_err for displaying adjusted frequency

2023-11-09 Thread Richard Cochran
On Mon, Sep 25, 2023 at 10:03:12AM -0700, Rahul Rameshbabu via Linuxptp-devel 
wrote:
> Adjusted frequency value displayed by do_freq is not an error, but a
> notication to the user. pr_err should not be used for providing notices
> with information about successful operations.
> 
> Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC 
> devices")
> Signed-off-by: Rahul Rameshbabu 

Applied.

Thanks,
Richard


___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel


[Linuxptp-devel] [PATCH v3 4/5] phc_ctl: Use pr_notice instead of pr_err for displaying adjusted frequency

2023-09-25 Thread Rahul Rameshbabu via Linuxptp-devel
Adjusted frequency value displayed by do_freq is not an error, but a
notication to the user. pr_err should not be used for providing notices
with information about successful operations.

Fixes: bdb6a35883b0 ("linuxptp: add phc_ctl program to help debug PHC devices")
Signed-off-by: Rahul Rameshbabu 
---
 phc_ctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/phc_ctl.c b/phc_ctl.c
index a814648..34d9e0c 100644
--- a/phc_ctl.c
+++ b/phc_ctl.c
@@ -249,7 +249,7 @@ static int do_freq(clockid_t clkid, int cmdc, char *cmdv[])
 
if (cmdc < 1 || name_is_a_command(cmdv[0])) {
ppb = clockadj_get_freq(clkid);
-   pr_err("clock frequency offset is %lfppb", ppb);
+   pr_notice("clock frequency offset is %lfppb", ppb);
 
/* no argument was used */
return 0;
@@ -272,7 +272,7 @@ static int do_freq(clockid_t clkid, int cmdc, char *cmdv[])
}
 
clockadj_set_freq(clkid, ppb);
-   pr_err("adjusted clock frequency offset to %lfppb", ppb);
+   pr_notice("adjusted clock frequency offset to %lfppb", ppb);
 
/* consumed one argument to determine the frequency adjustment value */
return 1;
-- 
2.40.1



___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel