Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Richard Cochran
On Mon, Jul 19, 2021 at 11:00:40AM +, Geva, Erez wrote: > This looks like a call to send the a patch with these options. > > Richard, How do you think these options should be implemented? > A single enumerator, separate integer for each? Whichever is easier. Maybe a single code like 8n1 pars

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Geva, Erez
Hi, Do you mean this one, page 20? http://www.leapsecond.com/museum/z3801a/097-z3801-01-iss-1.pdf Erez -Original Message- From: Richard Cochran Sent: Monday, 19 July 2021 04:13 To: Hal Murray Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH 4/4] ts2phc

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Geva, Erez
;D 3) Cc: linuxptp-devel@lists.sourceforge.net; Hal Murray Subject: Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option erez.geva@siemens.com said: > Do you mean this one, page 20? > http://www.leapsecond.com/museum/z3801a/097-z3801-01-iss-1.pdf Yes, but look down

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-19 Thread Hal Murray
erez.geva@siemens.com said: > Do you mean this one, page 20? > http://www.leapsecond.com/museum/z3801a/097-z3801-01-iss-1.pdf Yes, but look down on page 93 (or 5-3) > Baud Rate: 19200--7 data bits, 1 start bit, 1 stop bit, odd parity > (fixed configuration). -- These are my opinions.

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-18 Thread Richard Cochran
On Sun, Jul 18, 2021 at 07:09:54PM -0700, Richard Cochran wrote: > Otherwise, the patch is fine. I'll fix the order myself. Also, I set a minimum of 300. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lis

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 10:16:02AM -0700, Hal Murray wrote: > > > I did think of that, yet of the many serial devices I have used they have > > all > > been running with the setting 8/N/1 and no HW flow control. > > The HP Z3801A is 19200 baud, 7 data bits, odd parity Looks like it is configura

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-07-18 Thread Richard Cochran
On Fri, May 14, 2021 at 01:33:44PM +0200, Lars Munch wrote: > Add serial baudrate configuration option. Default to 9600 bps. > > Signed-off-by: Lars Munch > --- > config.c | 1 + > ts2phc.8 | 23 --- > ts2phc_nmea_master.c | 10 +- > 3 files c

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-05-14 Thread Hal Murray
> I did think of that, yet of the many serial devices I have used they have all > been running with the setting 8/N/1 and no HW flow control. The HP Z3801A is 19200 baud, 7 data bits, odd parity -- These are my opinions. I hate spam. ___ Linu

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-05-14 Thread Lars Munch
On Fri, May 14, 2021 at 4:45 PM Geva, Erez wrote: > > A great idea to add baud-rate. > > Just a suggestion, > As I remember from gtkterm application. > > It provide setting: port name, Baud rate, parity, bits, stop bit, and flow > control. > > What do you think of adding all of the setting? I di

Re: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-05-14 Thread Geva, Erez
May 2021 13:34 To: linuxptp-devel@lists.sourceforge.net Subject: [Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option Add serial baudrate configuration option. Default to 9600 bps. Signed-off-by: Lars Munch --- config.c | 1 + ts2phc.8 | 23

[Linuxptp-devel] [PATCH 4/4] ts2phc: Add serial baudrate option

2021-05-14 Thread Lars Munch
Add serial baudrate configuration option. Default to 9600 bps. Signed-off-by: Lars Munch --- config.c | 1 + ts2phc.8 | 23 --- ts2phc_nmea_master.c | 10 +- 3 files changed, 18 insertions(+), 16 deletions(-) diff --git a/config.c b/config.c