On Thu, 17 Apr 2014 07:19:05 +0200, Richard Cochran wrote:
> I don't see why you need to call into the transport twice.
>
> Can't you pass addr=NULL in order to get the default address?
Makes sense.
Jiri
--
Jiri Benc
---
Jiri,
I think this series brings a nice improvement, on second look. But the
change in this patch could be better yet?
See below...
On Fri, Apr 11, 2014 at 12:25:54PM +0200, Jiri Benc wrote:
> diff --git a/transport.c b/transport.c
> index cb799a68aa9f..25d569607f71 100644
> --- a/transport.c
>
On Fri, Apr 11, 2014 at 06:13:22PM +0200, Jiri Benc wrote:
>
> It's the first member of the union. I originally had only struct
> sockaddr_storage here but it led to horrible typecasting in the code
> (which is quite error prone when you accidentally put an extra & before
> the variable). In the e
On Fri, 11 Apr 2014 14:08:16 +0200, Richard Cochran wrote:
> > +struct address {
> > + socklen_t len;
> > + union {
> > + struct sockaddr_storage ss;
> > + struct sockaddr_in sin;
> > + struct sockaddr_in6 sin6;
> > + struct sockaddr_un sun;
> > +
On Fri, Apr 11, 2014 at 12:25:54PM +0200, Jiri Benc wrote:
> This modifies all transports to use a new common address type, struct
> address. This address is stored in a ptp_message for all received messages.
>
> For sending, the "default" address is used with the default sending
> functions, tran
This modifies all transports to use a new common address type, struct
address. This address is stored in a ptp_message for all received messages.
For sending, the "default" address is used with the default sending
functions, transport_send and transport_peer. The default address depends on
the tra
