Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-18 Thread Delio Brignoli
On Dec 18, 2013, at 9:06 AM, Richard Cochran wrote: > On Tue, Dec 17, 2013 at 12:44:22PM +0100, Delio Brignoli wrote: >> Hello Richard, >> >> Any news about this series? Let me know if you'd like me to respin it >> instead. > > I will push this out later today. Thank you! -- Delio --

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-18 Thread Richard Cochran
On Tue, Dec 17, 2013 at 12:44:22PM +0100, Delio Brignoli wrote: > Hello Richard, > > Any news about this series? Let me know if you'd like me to respin it instead. I will push this out later today. Thanks, Richard -- Ra

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-17 Thread Delio Brignoli
Hello Richard, Any news about this series? Let me know if you'd like me to respin it instead. Thanks -- Delio On Dec 4, 2013, at 3:59 PM, Delio Brignoli wrote: > On Dec 3, 2013, at 6:21 PM, Richard Cochran wrote: >> On Tue, Dec 03, 2013 at 11:39:30AM +0100, Delio Brignoli wrote: >>> >>> As wou

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-04 Thread Delio Brignoli
On Dec 3, 2013, at 6:21 PM, Richard Cochran wrote: > On Tue, Dec 03, 2013 at 11:39:30AM +0100, Delio Brignoli wrote: >> >> As would I. Thank you Richard for taking the time to prepare this patch >> series. > > So does this fix the issue you were seeing? It does fix that particular issue. > If

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-03 Thread Richard Cochran
On Tue, Dec 03, 2013 at 11:39:30AM +0100, Delio Brignoli wrote: > > As would I. Thank you Richard for taking the time to prepare this patch > series. So does this fix the issue you were seeing? If so, I'll respin it, adjusted for the comments. Thanks, Richard -

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-03 Thread Delio Brignoli
On Dec 2, 2013, at 10:22 PM, Keller, Jacob E wrote: > On Mon, 2013-12-02 at 22:01 +0100, Richard Cochran wrote: >> On Mon, Dec 02, 2013 at 07:37:44PM +, Keller, Jacob E wrote: >>> >>> Is there a specific reason that port_capable and port_incapable are not >>> the same function? >> >> The por

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-02 Thread Keller, Jacob E
On Mon, 2013-12-02 at 22:01 +0100, Richard Cochran wrote: > On Mon, Dec 02, 2013 at 07:37:44PM +, Keller, Jacob E wrote: > > > > Is there a specific reason that port_capable and port_incapable are not > > the same function? > > The port_capable function is used in a few different places in th

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-02 Thread Richard Cochran
On Mon, Dec 02, 2013 at 07:37:44PM +, Keller, Jacob E wrote: > > Is there a specific reason that port_capable and port_incapable are not > the same function? The port_capable function is used in a few different places in the code (including in port_tx_announce), but port_incapable is only use

Re: [Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-02 Thread Keller, Jacob E
On Sun, 2013-12-01 at 21:09 +0100, Richard Cochran wrote: > According to 802.1AS, ports are always expected to transmit announce > messages, even if they never want to become the grand master. Instead > of using a slave only BMC state machine as in 1588, 802.1AS offers a > "grand master capable" fl

[Linuxptp-devel] [PATCH RFC 2/3] Inhibit sync messages from unwilling 802.1AS ports.

2013-12-01 Thread Richard Cochran
According to 802.1AS, ports are always expected to transmit announce messages, even if they never want to become the grand master. Instead of using a slave only BMC state machine as in 1588, 802.1AS offers a "grand master capable" flag which allows clocks to not send sync messages. This patch keep