On Thu, 29 Dec 2022 at 08:02, Devasish Dey
wrote:
> Hi Erez,
>
>
>> > + goto failed;
>> > + }
>>
>> I think it is better to merge this ioctl and the socket creation with
>> sk_get_ts_info().
>> No reason for duplication.
>> You can use a static function or inline one.
>
> The
Hi Erez,
> > + goto failed;
> > + }
>
> I think it is better to merge this ioctl and the socket creation with
> sk_get_ts_info().
> No reason for duplication.
> You can use a static function or inline one.
The existing code seems to be more readable. One socket creation
On Tue, Dec 13, 2022 at 10:39:59AM +0530, Devasish Dey wrote:
> > +struct sk_if_info {
> > + bool valid;
> It is better not to use bool in a structure, as the size is usually
> int, i.e. 64 bits to hold 1 bit.
Because we don't have huge arrays of these structs, the size isn't
critical IMO.
On Tue, 2022-12-13 at 10:39 +0530, Devasish Dey wrote:
> + goto failed;
> + }
I think it is better to merge this ioctl and the socket creation with
sk_get_ts_info().
No reason for duplication.
You can use a static function or inline one.
> +
> + if
On Tue, 2022-12-13 at 17:39 +0100, Erez Geva wrote:
On Tue, 2022-12-13 at 10:39 +0530, Devasish Dey wrote:
> + goto failed;
> + }
I think it is better to merge this ioctl and the socket creation with
sk_get_ts_info().
No reason for duplication.
You can use a static function or
>
> > + goto failed;
> > + }
>
> I think it is better to merge this ioctl and the socket creation with
> sk_get_ts_info().
> No reason for duplication.
> You can use a static function or inline one.
>
> > +
> > + if (ecmd.req.link_mode_masks_nwords >= 0 ||
> > +
On Wed, 2022-12-07 at 17:34 +0530, SyncMonk Technologies wrote:
> When master and slave instance interacting with each other operating
> at different interface speed, delay assymetry needs to be compensated
> as described in G.8271 appendix V.
>
> In this patch we are adding changes to get the
When master and slave instance interacting with each other operating
at different interface speed, delay assymetry needs to be compensated
as described in G.8271 appendix V.
In this patch we are adding changes to get the interface speed using
ethtool.
v1: initial commit.
v2: updating comments
