Re: [Linuxptp-devel] [PATCH v6 00/11] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017

2023-02-22 Thread Magnus Armholt via Linuxptp-devel
Hi,

Could  you please provide an example how to use linux vlan interfaces in order 
to live up
to the required behaviour by the Power profile 2011 (receive 802.1Q tagged and 
untagged frames, send tagged frames - configurable VID, default 4).
I tried to achieve this with linux vlan interfaces but failed, I foresee that 
others might have the same question if support is claimed.
Clearly you have successfully tested this functionality.

In general, good work and great to see power profile support being added in 
the official code base.

BR,
Magnus Armholt


> -Original Message-
> From: Miroslav Lichvar 
> Sent: tiistai 21. helmikuuta 2023 11.05
> To: Richard Cochran 
> Cc: linuxptp-devel@lists.sourceforge.net
> Subject: Re: [Linuxptp-devel] [PATCH v6 00/11] Profile support for IEEE 
> C37.238-
> 2011 and IEEE C37.238-2017
> 
> BeSecure!   This email comes from outside of ABB. Make sure you verify the
> sender before clicking any links or downloading/opening attachments.
> If this email looks suspicious, report it by clicking 'Report Phishing' 
> button in
> Outlook or raising a ticket on MyIS.
> 
> 
> On Mon, Feb 20, 2023 at 12:57:48PM -0800, Richard Cochran wrote:
> > ChangeLog
> > ~
> > v6:
> >  Add new configuration options into default.cfg and man page  Make pmc
> > SET command ready for 2106 (Miroslav)  Use SPDX tag for new file tz.h
> 
> Looks good to me.
> 
> Thanks,
> 
> --
> Miroslav Lichvar
> 
> 
> 
> ___
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourceforge.net
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.sour
> ceforge.net%2Flists%2Flistinfo%2Flinuxptp-
> devel&data=05%7C01%7Cmagnus.armholt%40fi.abb.com%7Ccff08f0bba844f40
> ed5208db13eb24b6%7C372ee9e09ce04033a64ac07073a91ecd%7C0%7C0%7C6
> 38125672876103996%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi
> LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd
> ata=lzDukSknih0pel%2Bk384ccv3%2BI5iT82cbI%2Bkpgdnjl84%3D&reserved=0


___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel


Re: [Linuxptp-devel] [PATCH v6 00/11] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017

2023-02-21 Thread Miroslav Lichvar
On Mon, Feb 20, 2023 at 12:57:48PM -0800, Richard Cochran wrote:
> ChangeLog
> ~
> v6:
>  Add new configuration options into default.cfg and man page
>  Make pmc SET command ready for 2106 (Miroslav)
>  Use SPDX tag for new file tz.h 

Looks good to me.

Thanks,

-- 
Miroslav Lichvar



___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel


[Linuxptp-devel] [PATCH v6 00/11] Profile support for IEEE C37.238-2011 and IEEE C37.238-2017

2023-02-20 Thread Richard Cochran
ChangeLog
~
v6:
 Add new configuration options into default.cfg and man page
 Make pmc SET command ready for 2106 (Miroslav)
 Use SPDX tag for new file tz.h 
v5:
 Rename tztool to tz2alt
 Provide man page for tz2alt
 Fix year 2106 bug
v4:
 Preserve all 48 bits of "next jump" (v3 review feedback from Erez Geva)
 Accept the full range for domainNumber (suggested by v.nosikov)
v3:
 Initial RFC
v2, v1:
 never published

The Power Profile specifies two new TLVs:

1. IEEE_C37_238 TLV

   - New configuration option to enable the TLV.

   - New configuration options for grandmasterID and default
 totalTimeInaccuracy.

   - New custom management message for changing totalTimeInaccuracy at
 run time. This message allows switching the TLV from the 2017
 format into the 2011 format by specifying grandmasterTimeInaccuracy
 and networkTimeInaccuracy.

2. ALTERNATE_TIME_OFFSET_INDICATOR TLV

   - New custom management message for enabling the TLV and setting
 the TLV values.

   - New helper program that computes the values from the local time
 and the Linux time zone data base and then sends the values to
 ptp4l. This method assumes that the local Linux system time and
 the PHC clock are synchronized.

Thanks,
Richard


Richard Cochran (11):
  Accept the full range for domainNumber.
  tlv: Encode and decode power profile TLVs.
  Introduce the power profile.
  Add a custom management message for power profile settings.
  tlv: Encode and decode alternate time offset indicator TLVs.
  Prepare clock based storage of up to four time zones.
  Add the ALTERNATE_TIME_OFFSET_PROPERTIES management message.
  Add the ALTERNATE_TIME_OFFSET_NAME management message.
  Implement the ALTERNATE_TIME_OFFSET_ENABLE management message.
  pmc: Convert internal helper function into global method.
  Introduce a time zone helper program.

 clock.c | 188 --
 clock.h |   8 +
 config.c|  17 +-
 configs/default.cfg |   5 +
 makefile|   7 +-
 pmc.c   |  49 ++
 pmc_common.c| 136 +++-
 pmc_common.h|   2 +
 port.c  |  76 -
 port_private.h  |   3 +
 power_profile.h |  31 
 ptp4l.8 |  38 +
 tlv.c   | 146 +
 tlv.h   |  64 
 tz.h|  13 ++
 tz2alt.8| 126 +++
 tz2alt.c| 379 
 util.h  |   7 +
 18 files changed, 1278 insertions(+), 17 deletions(-)
 create mode 100644 power_profile.h
 create mode 100644 tz.h
 create mode 100644 tz2alt.8
 create mode 100644 tz2alt.c

-- 
2.30.2



___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel