Re: [Linuxptp-devel] Port down and sde

2021-05-04 Thread Luigi 'Comio' Mantellini
Hi Richard, not a problem, of course. I'm just speaking about code cleanup. luigi Il giorno mar 4 mag 2021 alle ore 14:00 Richard Cochran < richardcoch...@gmail.com> ha scritto: > On Mon, May 03, 2021 at 06:45:56PM +0200, Luigi 'Comio' Mantellini wrote: > > /* > > * A port going down can

Re: [Linuxptp-devel] Port down and sde

2021-05-04 Thread Richard Cochran
On Mon, May 03, 2021 at 06:45:56PM +0200, Luigi 'Comio' Mantellini wrote: > /* > * A port going down can affect the BMCA result. > * Force a state decision event. > */ > if (p->link_status & LINK_DOWN) > clock_set_sde(p->clock, 1); > > I think that should be removed Why? What problem does it

[Linuxptp-devel] Port down and sde

2021-05-03 Thread Luigi 'Comio' Mantellini
Hi Richard, Hi All, I noticed the following code inside port_link_status(): /* * A port going down can affect the BMCA result. * Force a state decision event. */ if (p->link_status & LINK_DOWN) clock_set_sde(p->clock, 1); I think that should be removed because the calling code look like this: