Re: [Linuxptp-devel] [PATCH v2 01/27] Move check of TLV length for management COMMAND messages

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:18AM +0100, Jiri Benc wrote: Currently, it is assumed that the management TLV data of management COMMAND messages is always empty. This is not true for the INITIALIZE command and also for a custom command we'll be introducing. Move the check to msg_post_recv and

Re: [Linuxptp-devel] [PATCH v2 04/27] uds: don't output Connection refused

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:21AM +0100, Jiri Benc wrote: When phc2sys is started before ptp4l or it is interrupted before ptp4l has a chance to reply to its query, the uds: sendto failed: Connection refused message is output. This is not an interesting message. Also, don't output the

Re: [Linuxptp-devel] [PATCH v2 06/27] Include TLV in replies to management commands

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:23AM +0100, Jiri Benc wrote: The standard requires management TLV in replies to commands: An acknowledge management message is a response to a command management message. The value of the managementId shall be identical to that in the command

Re: [Linuxptp-devel] [PATCH v2 10/27] Custom management TLV PORT_ENUMERATION_NP

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:27AM +0100, Jiri Benc wrote: Used to enumerate all ports. With the future dynamic port adding/removal, there may be holes in the port number sequence. For now, just fill it with the sequence numbers. Signed-off-by: Jiri Benc jb...@redhat.com --- clock.c |

Re: [Linuxptp-devel] [PATCH v2 11/27] Event notification: port addition/removal

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:28AM +0100, Jiri Benc wrote: Add an event number for port adding/removal. As currently the ports are static, this event is not emitted for now. Then this patch should wait unit dynamic ports are ready. Thanks, Richard

Re: [Linuxptp-devel] [PATCH v2 12/27] Custom management TLV PORT_PROPERTIES_NP

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:29AM +0100, Jiri Benc wrote: Will be used by phc2sys to find out interfaces corresponding to ports. This looks okay to me. Same nits as before... Signed-off-by: Jiri Benc jb...@redhat.com --- clock.c |9 + port.c | 16 tlv.c

Re: [Linuxptp-devel] [PATCH v2 26/27] Subscription time limit

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:43AM +0100, Jiri Benc wrote: Require subscriptions to be renewed regularly. This way, the subscription automatically times out when phc2sys is killed. Signed-off-by: Jiri Benc jb...@redhat.com --- clock.c | 24 phc2sys.c | 10

Re: [Linuxptp-devel] [PATCH v2 26/27] Subscription time limit

2014-04-05 Thread Richard Cochran
On Mon, Mar 24, 2014 at 09:53:43AM +0100, Jiri Benc wrote: Require subscriptions to be renewed regularly. This way, the subscription automatically times out when phc2sys is killed. Can't this patch go before all of the phc2sys stuff? Thanks, Richard