[Linuxptp-devel] Missing man page for nsm?

2018-04-04 Thread Miroslav Lichvar
I was packaging 1.9 and noticed that the make install command fails with: install: cannot stat 'nsm.8': No such file or directory Could you please consider adding a (short) man page, or fix the makefile to check if the man page is present before calling install? -- Miroslav Lichvar

Re: [Linuxptp-devel] [PATCH RFC 1/8] port: Make the data set comparison algorithm into a function variable.

2018-04-04 Thread Anders Selhammer
Saturday, March 31, 2018 11:33 PM > + int (*dscmp)(struct dataset *a, struct dataset *b); > - else if (dscmp(&fc->dataset, &p->best->dataset) > 0) > + else if (p->dscmp(&fc->dataset, &p->best->dataset) > 0) > + p->dscmp = dscmp; > + int (*dscmp)(struct dataset

Re: [Linuxptp-devel] Missing man page for nsm?

2018-04-04 Thread Richard Cochran
On Wed, Apr 04, 2018 at 02:48:24PM +0200, Miroslav Lichvar wrote: > I was packaging 1.9 and noticed that the make install command fails > with: > install: cannot stat 'nsm.8': No such file or directory > > Could you please consider adding a (short) man page, or fix the > makefile to check if

Re: [Linuxptp-devel] Missing man page for nsm?

2018-04-04 Thread Miroslav Lichvar
On Wed, Apr 04, 2018 at 07:38:19AM -0700, Richard Cochran wrote: > Oh man, I never, ever run 'make install', and so this bug got into the > release. (/me adds that into the pre-release checklist.) > > What is better, to release 1.9.1 or 1.10 ? > > We never used the third digit before... My prefe

Re: [Linuxptp-devel] [PATCH RFC 1/8] port: Make the data set comparison algorithm into a function variable.

2018-04-04 Thread Richard Cochran
On Wed, Apr 04, 2018 at 11:56:32AM +, Anders Selhammer wrote: > Should it be possible to have different data set comparison algorithms in > clock and port struct? No, that doesn't make sense. > Otherwise, why not use the dscmp in clock struct? You are right. The dscmp() function is needles