Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-18 Thread Patel, Vedang
Thanks Richard for the response. I will work on this and send you a patch soon. Just one question below. On Tue, 2018-09-18 at 06:06 -0700, Richard Cochran wrote: > diff --git a/designated_fsm.c b/designated_fsm.c > index a56f962..9ccf4c9 100644 > --- a/designated_fsm.c > +++ b/designated_fsm.c >

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-18 Thread Richard Cochran
On Tue, Sep 18, 2018 at 11:21:55PM +, Patel, Vedang wrote: > Is there any particular reason you removed this? This is needed to > process the FD_SYNC_RX_TIMER expiration when the master disconnects > unexpectedly. AFAICT there is no point in handling that timer in any special way. After all,

Re: [Linuxptp-devel] [PATCH] clock: Remove subscriber if an error occured.

2018-09-18 Thread Richard Cochran
On Thu, Sep 06, 2018 at 09:41:22AM +0200, Michael Walle wrote: > btw. reading the code again, shouldn't it be LIST_FOREACH_SAFE() in > clock_update_subscription()? Yes. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] [PTPBASE-MIB 0/3] Partial support of PTPBASE-MIB

2018-09-18 Thread Richard Cochran
On Thu, Sep 13, 2018 at 09:33:14AM +0200, Anders Selhammer wrote: > This series adds the support for the implemented data sets in ptp4l > described in PTPBASE-MIB. > The snmp4lptp is used as a subagent to netsnamp master agent. The > infrmation is collected directly from ptp4l program using the

Re: [Linuxptp-devel] [PATCH RFC 0/4] Support for dropping root privileges

2018-09-18 Thread Richard Cochran
On Fri, Aug 10, 2018 at 04:37:04PM +0200, Miroslav Lichvar wrote: > This patchset implements a support for dropping all root privileges > except adjusting the clock and binding to a privileged port, using the > libcap library. I haven't forgotten about this, but I wanted to see how we could avoid

Re: [Linuxptp-devel] [PATCH v1 3/6] Add BMCA config option.

2018-09-18 Thread Richard Cochran
On Thu, Aug 30, 2018 at 04:54:37PM -0700, Vedang Patel wrote: > diff --git a/clock.c b/clock.c > index 0f2e319a19c7..eef534aea718 100644 > --- a/clock.c > +++ b/clock.c > @@ -1136,6 +1136,15 @@ struct clock *clock_create(enum clock_type type, > struct config *config, > > LIST_FOREACH(p,

Re: [Linuxptp-devel] [PATCH v1 0/6] Adding support for Automotive Profile

2018-09-18 Thread Richard Cochran
On Thu, Sep 13, 2018 at 08:35:22PM -0700, Richard Cochran wrote: > Yes, I'll get to it as soon as I can. Overall I'm happy with this > series, but I wanted to sit down and think through the automatic > switch to MASTER state that we discussed. Okay, I took your series and hacked the following

Re: [Linuxptp-devel] [PATCH v1 3/6] Add BMCA config option.

2018-09-18 Thread Richard Cochran
On Thu, Aug 30, 2018 at 04:54:37PM -0700, Vedang Patel wrote: > diff --git a/bmc.c b/bmc.c > index 3c3db828764b..b0a80c2198cb 100644 > --- a/bmc.c > +++ b/bmc.c > @@ -126,6 +126,17 @@ enum port_state bmc_state_decision(struct clock *c, > struct port *r, > port_best = port_best_foreign(r); >

Re: [Linuxptp-devel] [PATCH RFC 0/4] Support for dropping root privileges

2018-09-18 Thread Miroslav Lichvar
On Tue, Sep 18, 2018 at 03:56:37AM -0700, Richard Cochran wrote: > On Fri, Aug 10, 2018 at 04:37:04PM +0200, Miroslav Lichvar wrote: > > This patchset implements a support for dropping all root privileges > > except adjusting the clock and binding to a privileged port, using the > > libcap

Re: [Linuxptp-devel] [PTPBASE-MIB 0/3] Partial support of PTPBASE-MIB

2018-09-18 Thread Richard Cochran
On Thu, Sep 13, 2018 at 09:33:14AM +0200, Anders Selhammer wrote: > This series adds the support for the implemented data sets in ptp4l > described in PTPBASE-MIB. > The snmp4lptp is used as a subagent to netsnamp master agent. The > infrmation is collected directly from ptp4l program using the