Re: [Linuxptp-devel] [PATCH RFC 07/30] Convert call sites to the proper method for getting interface names.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 11:38:43AM -0800, Jacob Keller wrote: > > Is there a way to generate the network of how interconnected the various > object files are? The .d files have the includes. I once wrote a script to turn the .d files into a dotty graph. But I guess the utility is low. Thanks,

Re: [Linuxptp-devel] [PATCH RFC 24/30] interface: Introduce methods to create and destroy instances.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 01:25:00PM -0800, Jacob Keller wrote: > > I still think it would be good to have the functions guarantee the NULL > by manually assigning or using one of the string copy implementations > that will guarantee it. That way they don't have to rely on this assumption. In the

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-04 Thread Richard Cochran
On Fri, Feb 14, 2020 at 01:23:44PM +0200, Ville Heikkinen wrote: > In case there is no connection to the server, notify the kernel > that the clock is currently unsynchronized. > > Signed-off-by: Ville Heikkinen Applied. Thanks, Richard ___

Re: [Linuxptp-devel] [PATCH RFC 20/30] interface: Introduce a method to test the time stamping information validity.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 01:19:09PM -0800, Jacob Keller wrote: > > +bool interface_tsinfo_valid(struct interface *iface) > > +{ > > + return iface->ts_info.valid ? true : false; > > +} > > Do you actually need the ternary here? shouldn't ts_info.valid get > converted to true or false because we

Re: [Linuxptp-devel] [PATCH RFC 14/30] interface: Introduce a method to set the name.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 01:07:52PM -0800, Jacob Keller wrote: > > Good, the name is marked as constant. Side note, for those interface_* > functions that don't modify the interface, does it make sense to mark > them as taking a const interface pointer? I have heard C++ people insisting on this,

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-04 Thread Richard Cochran
On Mon, Feb 17, 2020 at 01:46:26PM +0100, Miroslav Lichvar wrote: > On Mon, Feb 17, 2020 at 02:34:14PM +0200, Heikkinen, Ville (Nokia - FI/Espoo) > wrote: > > (https://www.eecis.udel.edu/~mills/database/reports/kern/kernb.pdf). In > > there, it's specified that "STA_UNSYNC set/cleared by the

Re: [Linuxptp-devel] [PATCH RFC 06/30] interface: Introduce an access method for the name field.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 11:33:32AM -0800, Jacob Keller wrote: > So the interface.o isn't being added to something like $(CONFIG)? I like the idea, but I'll leave that as a follow-on task. Thanks, Richard ___ Linuxptp-devel mailing list

Re: [Linuxptp-devel] [PATCH RFC 00/30] Convert open coded interface into proper module.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 10:03:38AM -0800, Jacob Keller wrote: > > Nice. A lot of patches, but they sound reasonable. Will review them this > afternoon. I really appreciate your careful review. It is quite a chore. Thanks, Richard ___

Re: [Linuxptp-devel] [PATCH RFC 28/30] interface: Hide the implementation details.

2020-03-04 Thread Richard Cochran
On Tue, Feb 18, 2020 at 01:32:01PM -0800, Jacob Keller wrote: > I'd appreciate if there was some way to ensure we catch the interface > structure layout changing such that the definitions in clock.c and > config.c aren't compatible with interface.c anymore. > > Perhaps there isn't a good solution

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-04 Thread Miroslav Lichvar
On Wed, Mar 04, 2020 at 08:49:45AM -0800, Richard Cochran wrote: > On Mon, Feb 17, 2020 at 01:46:26PM +0100, Miroslav Lichvar wrote: > > On Mon, Feb 17, 2020 at 02:34:14PM +0200, Heikkinen, Ville (Nokia - > > FI/Espoo) wrote: > > >