Re: [Linuxptp-devel] [PATCH] Add support for DELAY_REQ and SYNC packets rx_filter

2023-11-15 Thread IlorDash
> > >> Device driver can only get info about the current PTP port state >> from ptp4l, because it doesn’t have direct access to it. >> > > And this helps? > Yes, with dynamically switching RX filters I was able to change my Ethernet controller state from Master to Slave and vice versa. I meant a

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > @@ -1129,6 +1130,27 @@ static int port_management_fill_response(struct port > *target, > memcpy(pwr, >pwr, sizeof(*pwr)); > datalen = sizeof(*pwr); > break; > + case MID_CMLDS_INFO_NP:

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > @@ -490,6 +491,15 @@ static int mgt_post_recv(struct management_tlv *m, > uint16_t data_len, > if (data_len != 0) > goto bad_length; > break; > + case MID_CMLDS_INFO_NP: > +

Re: [Linuxptp-devel] [RFC PATCH v2 3/9] Add DM_COMMON_P2P

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:06PM -0400, Kishen Maloor wrote: > This change adds COMMON_P2P (IEEE 802.1AS-2020, clause 14.8.5) to the > enumeration of delay mechanisms and incorporates it into existing code > paths pertaining to DM_P2P to (where appropriate) maintain parity with > DM_P2P. > >

Re: [Linuxptp-devel] [RFC PATCH v2 6/9] Add plumbing for interacting with the CMLDS

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:09PM -0400, Kishen Maloor wrote: > This change furnishes the plumbing for interacting with CMLDS > Link Ports (i.e. ports with "run_cmlds=1"). > > It adds internal functions for PTP Ports which employ the > COMMON_P2P delay mechanism to issue requests to a CMLDS Link

Re: [Linuxptp-devel] CMLDS Patches

2023-11-15 Thread Richard Cochran
On Mon, Aug 21, 2023 at 10:44:27AM +0200, Walfred Tedeschi wrote: > On 11.08.23 19:13, Richard Cochran wrote: > > The CMLDS series will require careful review. My superficial review > > gave me the impression that the approach was too complex. > Do you have an indication on how it could be

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv { > UInteger16numberOfBitsAfterTimestamp; > } PACKED; > > +struct cmlds_info_np { > + Integer8 serviceMeasurementValid; > + TimeInterval meanLinkDelay; >

Re: [Linuxptp-devel] [RFC PATCH v2 2/9] Add configuration options for CMLDS

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:05PM -0400, Kishen Maloor wrote: > 'cmlds_clockIdentity': This global setting assigns a CMLDS > clockIdentity to be used by a ptp4l instance on a PTP node that exposes > CMLDS over one or more links. Don't really need this. I know it is specified in 1588, but it is

Re: [Linuxptp-devel] [RFC PATCH v2 5/9] Add port_cmlds_ignore()

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:08PM -0400, Kishen Maloor wrote: > port_cmlds_ignore() assesses incoming messages per the following > policy: > > * All messages that bear the CMLDS sdoid/domainNumber are directed > to a CMLDS Link Port context and processed by this function. All other > messages go

Re: [Linuxptp-devel] [RFC PATCH v2 6/9] Add plumbing for interacting with the CMLDS

2023-11-15 Thread Richard Cochran
On Wed, Nov 15, 2023 at 09:05:45PM -0800, Richard Cochran wrote: > I'd like to have this: > > 1. provide the new TLV via the PUSH mechanism. > > 2. let clients using DM_COMMON_P2P subscribe to the new TLV. > > 3. let the client update their peer delay values based on an incoming TLV. For

Re: [Linuxptp-devel] [RFC PATCH v2 4/9] Update the PdelayReq/Res flows for CMLDS Link Ports

2023-11-15 Thread Richard Cochran
On Wed, Nov 15, 2023 at 08:58:58PM -0800, Richard Cochran wrote: > The text of 1588 strongly suggests that the CMLDS service be stand > alone daemon. However, we can provide the same functionality without > the extra complexity, by simply letting ptp4l serve the measured peer > delay to any local

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-15 Thread Richard Cochran
On Wed, Nov 15, 2023 at 09:45:52PM -0800, Richard Cochran wrote: > On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > > > @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv { > > UInteger16numberOfBitsAfterTimestamp; > > } PACKED; > > > > +struct cmlds_info_np { > > +

Re: [Linuxptp-devel] [RFC PATCH v2 9/9] Make allowedLostResponses configurable

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:12PM -0400, Kishen Maloor wrote: > This change adds 'allowedLostResponses' as a per-port parameter > with a default value of 3 (per IEEE 802.1AS-2011, clause 11.5.3). > (Note that this matches the value of the previously #define'd > ALLOWED_LOST_RESPONSES, so this

Re: [Linuxptp-devel] [PATCH v4 0/4] add get_pins_cfg command to display pin functions

2023-11-15 Thread Richard Cochran
On Mon, Jun 26, 2023 at 12:03:29PM -0700, Jacob Keller wrote: > Extend phc_ctl with a new get_pins_cfg command which calls the > PTP_PIN_GETFUNC ioctl on a PHC clock and prints the pin configuration for > each pin. > > Changes since v3: > * remove use of PTP_PIN_SETFUNC2 and PTP_PIN_GETFUNC2 at

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > @@ -651,6 +652,18 @@ static void pmc_show(struct ptp_message *msg, FILE *fp) > fprintf(fp, "LOG_MIN_PDELAY_REQ_INTERVAL " > IFMT "logMinPdelayReqInterval %hhd", mtd->val); > break; >

Re: [Linuxptp-devel] [RFC PATCH v2 4/9] Update the PdelayReq/Res flows for CMLDS Link Ports

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:07PM -0400, Kishen Maloor wrote: > For ports that are configured with "run_cmlds=1", i.e. CMLDS Link > Ports, this change updates port_pdelay_request(), process_pdelay_req() and > port_peer_delay() to utilize the CMLDS sdoid/domainNumber/portId > along code paths

Re: [Linuxptp-devel] [RFC PATCH v2 7/9] Implement the COMMON_P2P delay mechanism

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:10PM -0400, Kishen Maloor wrote: > From: Andrew Zaborowski > > This change implements the COMMON_P2P DM by issuing a request > to the CMLDS for CommonMeanLinkDelayInformation upon expiry of > the delay timer and handles the response to assimilate the > received

Re: [Linuxptp-devel] [RFC PATCH v2 4/9] Update the PdelayReq/Res flows for CMLDS Link Ports

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:07PM -0400, Kishen Maloor wrote: > For ports that are configured with "run_cmlds=1", i.e. CMLDS Link > Ports, this change updates port_pdelay_request(), process_pdelay_req() and > port_peer_delay() to utilize the CMLDS sdoid/domainNumber/portId > along code paths

Re: [Linuxptp-devel] [RFC PATCH v2 1/9] Add new TLV for CommonMeanLinkDelayInformation

2023-11-15 Thread Richard Cochran
On Mon, May 15, 2023 at 06:26:04PM -0400, Kishen Maloor wrote: > @@ -473,6 +476,14 @@ struct msg_interface_rate_tlv { > UInteger16numberOfBitsAfterTimestamp; > } PACKED; > > +struct cmlds_info_np { > + Integer8 serviceMeasurementValid; > + TimeInterval meanLinkDelay; >