Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-06 Thread Richard Cochran
On Thu, Mar 05, 2020 at 08:29:03AM +0100, Miroslav Lichvar wrote: > > I'd stick with the meaning "the clock has is believed to have an error > larger than 16 seconds". With ptp4l/phc2sys, if someone needs to check > if the clock was updated in the last X seconds, they can check the > maxerror

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-04 Thread Miroslav Lichvar
On Wed, Mar 04, 2020 at 08:49:45AM -0800, Richard Cochran wrote: > On Mon, Feb 17, 2020 at 01:46:26PM +0100, Miroslav Lichvar wrote: > > On Mon, Feb 17, 2020 at 02:34:14PM +0200, Heikkinen, Ville (Nokia - > > FI/Espoo) wrote: > > >

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-04 Thread Richard Cochran
On Fri, Feb 14, 2020 at 01:23:44PM +0200, Ville Heikkinen wrote: > In case there is no connection to the server, notify the kernel > that the clock is currently unsynchronized. > > Signed-off-by: Ville Heikkinen Applied. Thanks, Richard ___

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-03-04 Thread Richard Cochran
On Mon, Feb 17, 2020 at 01:46:26PM +0100, Miroslav Lichvar wrote: > On Mon, Feb 17, 2020 at 02:34:14PM +0200, Heikkinen, Ville (Nokia - FI/Espoo) > wrote: > > (https://www.eecis.udel.edu/~mills/database/reports/kern/kernb.pdf). In > > there, it's specified that "STA_UNSYNC set/cleared by the

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-02-17 Thread Heikkinen, Ville (Nokia - FI/Espoo)
On 2/17/20 11:06 AM, Miroslav Lichvar wrote: On Fri, Feb 14, 2020 at 01:23:44PM +0200, Ville Heikkinen wrote: In case there is no connection to the server, notify the kernel that the clock is currently unsynchronized. Is the idea to use the flag for monitoring phc2sys? The idea is to

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-02-17 Thread Miroslav Lichvar
On Mon, Feb 17, 2020 at 02:34:14PM +0200, Heikkinen, Ville (Nokia - FI/Espoo) wrote: > (https://www.eecis.udel.edu/~mills/database/reports/kern/kernb.pdf). In > there, it's specified that "STA_UNSYNC set/cleared by the caller to indicate > clock unsynchronized (e.g., when no peers are

Re: [Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-02-17 Thread Miroslav Lichvar
On Fri, Feb 14, 2020 at 01:23:44PM +0200, Ville Heikkinen wrote: > In case there is no connection to the server, notify the kernel > that the clock is currently unsynchronized. Is the idea to use the flag for monitoring phc2sys? I'm not sure if that's how the UNSYNC flag is supposed to be used.

[Linuxptp-devel] [PATCH] phc2sys: Notify kernel if clock is not in sync

2020-02-14 Thread Ville Heikkinen
In case there is no connection to the server, notify the kernel that the clock is currently unsynchronized. Signed-off-by: Ville Heikkinen --- clockadj.c | 11 +++ clockadj.h | 5 + phc2sys.c | 4 +++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/clockadj.c